zaks.anna added inline comments. ================ Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:136 @@ +135,3 @@ + auto NodeIt = G.eop_begin(); + const auto NodeEndIt = G.eop_end(); + ---------------- Alexander_Droste wrote: > zaks.anna wrote: > > The analyzer does not do a good job tracking global variables. You might > > get false positives, specifically, where the variable is released in > > another translation unit or by calling function that the analyzer does not > > inline. > > > So shall we remove or keep the function? I think you will get false positives of the nature I describe above if you keep it. If so, you should remove it. The user experience is much better if you avoid false positives.
http://reviews.llvm.org/D12761 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
