Author: mps
Date: Wed Mar 16 09:27:50 2016
New Revision: 263638
URL: http://llvm.org/viewvc/llvm-project?rev=263638&view=rev
Log:
Add visualizers for more clang types. Create more C++-like visualizations for
existing Clang types
Created visualizer for PointerType, LValueReferenceType, RValueRefe
mspertus added a comment.
I think the code is correct as written, see response in comment
Comment at: clang.natvis:77
@@ +76,3 @@
+
+
+
aaron.ballman wrote:
> The only hard-wiring I see uses 3 bits, so is this comment still accurate?
I think the code is co
hintonda updated this revision to Diff 50930.
hintonda added a comment.
Fixed comment per Dave's recommendation.
http://reviews.llvm.org/D18123
Files:
include/clang/AST/UnresolvedSet.h
include/clang/Sema/Lookup.h
Index: include/clang/Sema/Lookup.h
==
Author: bruno
Date: Thu Mar 17 16:30:55 2016
New Revision: 263750
URL: http://llvm.org/viewvc/llvm-project?rev=263750&view=rev
Log:
Revert "Reapply [VFS] Add 'overlay-relative' field to YAML files"
Tests failing on
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/46102
This reverts comm
rsmith added a comment.
Note that the diagnostic wording has already been fixed compared with the
diagnostic reported in that bug report. Do we actually need more changes here?
http://reviews.llvm.org/D16965
___
cfe-commits mailing list
cfe-commits
etienneb updated this revision to Diff 51046.
etienneb marked 2 inline comments as done.
etienneb added a comment.
Added test.
http://reviews.llvm.org/D18262
Files:
ClangTidy.cpp
misc-macro-parentheses-cmdline.cpp
Index: misc-macro-parentheses-cmdline.cpp
==
Author: d0k
Date: Fri Mar 18 08:31:00 2016
New Revision: 263785
URL: http://llvm.org/viewvc/llvm-project?rev=263785&view=rev
Log:
Make LookupResult movable again.
We lost copy semantics in r263730, because it only worked for a few very
specific cases. Move semantics don't have this issue. Sadly t
Prazek updated this revision to Diff 51087.
http://reviews.llvm.org/D18274
Files:
clang-tidy/CMakeLists.txt
clang-tidy/boost/BoostTidyModule.cpp
clang-tidy/boost/CMakeLists.txt
clang-tidy/plugin/CMakeLists.txt
clang-tidy/tool/CMakeLists.txt
clang-tidy/tool/ClangTidyMain.cpp
docs/cla
samsonov added a comment.
Cool, great to see this coming. I'll let Kuba sign this off.
Comment at: test/Driver/fsanitize.c:220
@@ -219,1 +219,3 @@
+// RUN: %clang -target x86_64-apple-darwin10 -fsanitize=thread %s -### 2>&1 |
FileCheck %s --check-prefix=CHECK-TSAN-X86-64-DARW
jyknight added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:305
@@ +304,3 @@
+if (TypeWidth == TypeAlign && (TypeWidth & (TypeWidth - 1)) == 0 &&
+TypeWidth <= InlineWidth)
+ return Always;
jfb wrote:
> bcraig wrote:
> > On some
pxli168 added inline comments.
Comment at: test/CodeGenOpenCL/spir_version.cl:15
@@ +14,2 @@
+// CL20: !opencl.ocl.version = !{[[SPIR:![0-9]+]]}
+// CL20: [[SPIR]] = !{i32 2, i32 0}
Anastasia wrote:
> Forgotten to check OpenCL version here?
The metadate will be me
pxli168 updated this revision to Diff 51126.
http://reviews.llvm.org/D17596
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/spir_version.cl
Index: test/CodeGenOpenCL/spir_version.cl
===
--- /dev/null
+++ test/CodeGenOpenCL/
pxli168 marked 2 inline comments as done.
pxli168 added a comment.
http://reviews.llvm.org/D17596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Sun Mar 20 05:33:40 2016
New Revision: 263895
URL: http://llvm.org/viewvc/llvm-project?rev=263895&view=rev
Log:
P0184R0: Allow types of 'begin' and 'end' expressions in range-based for loops
to differ.
Modified:
cfe/trunk/include/clang/AST/StmtCXX.h
cfe/trunk/include
Author: rsmith
Date: Sun Mar 20 05:37:12 2016
New Revision: 263896
URL: http://llvm.org/viewvc/llvm-project?rev=263896&view=rev
Log:
Mark C++ features implemented in Clang 3.8 as done now that 3.8 has released.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
U
JVApen accepted this revision.
JVApen added a comment.
This revision is now accepted and ready to land.
I'm not sure if I'm the right person to do reviews, as I'm mostly a user of the
tool and have not yet done any developments or bug fixes to it.
However, from what I know from coding, this looks
Hi Daniel,
I'm not sure I understand the logic behind modifying 'AlwaysBreak' to be
'AlwaysBreakExceptForSingleArgument'.
AlwaysBreak is always going to lead to "wasted space".
Some consider consistently break to not be a waste but actually contribute
to readability, it seems that was what 'Alway
r263746.
> On 2016-Mar-17, at 13:36, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
>>
>> On 2016-Mar-16, at 15:41, Eric Fiselier wrote:
>>
>> EricWF accepted this revision.
>> EricWF added a comment.
>> This revision is now accepted and ready to land.
>>
>> LGTM after change in inline
Nice! Thanks Benjamin
On Thu, Mar 17, 2016 at 9:19 AM, Benjamin Kramer via cfe-commits
wrote:
> Author: d0k
> Date: Thu Mar 17 11:19:51 2016
> New Revision: 263718
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263718&view=rev
> Log:
> Use a simpler set of mock headers for the vfs+modules crash
On Sun, Mar 20, 2016 at 3:08 AM, Bruno Cardoso Lopes via cfe-commits
wrote:
> Author: bruno
> Date: Sat Mar 19 21:08:48 2016
> New Revision: 263893
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263893&view=rev
> Log:
> Reapply [2] [VFS] Add 'overlay-relative' field to YAML files
>
> This reappl
On Fri, Mar 18, 2016 at 05:11:19PM +, Richard Smith via cfe-commits wrote:
> rsmith added a comment.
>
> Can you explain a bit more about the problem? It seems to me that if I have:
>
> struct Base {
> char k[1];
> };
> struct Derived : Base {};
>
> ... then the 'k' subobject of a
On Fri, Mar 18, 2016 at 12:11:22PM -0500, Craig, Ben via cfe-commits wrote:
> A lot of it is a frontend decision. What goes in the libcall feels an awful
> lot like the 386 vs 486 example that I hear a lot. If I want one binary
> that can run on both a 386 (very limited atomic support) and a 486
rnk added a comment.
I'm not sure your example is in scope for -Wshadow, though. Any function call
that takes a non-const reference to the parameter could modify it. I guess I'm
thinking something like:
void trim_in_place(std::string &s);
struct A {
std::string s;
A(std::string s) :
Author: hahnfeld
Date: Thu Mar 17 05:00:24 2016
New Revision: 263699
URL: http://llvm.org/viewvc/llvm-project?rev=263699&view=rev
Log:
[libcxxabi] Disable cxa_thread_atexit_test if unavailable
The feature check is already in place when building the library but wasn't
honored for the tests.
Diffe
On 3/18/2016 11:54 AM, JF Bastien wrote:
Some architectures support byte granularity memory protection.
Accessing unsolicited bytes can cause a trap on those architectures.
I think it makes sense for atomic and Atomic to get
turned into the 4 byte __atomic intrinsics. Those 4
On 20 March 2016 at 11:33, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Sun Mar 20 05:33:40 2016
> New Revision: 263895
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263895&view=rev
> Log:
> P0184R0: Allow types of 'begin' and 'end' expressions in range-based for
> loops to di
Author: d0k
Date: Sun Mar 20 09:24:49 2016
New Revision: 263900
URL: http://llvm.org/viewvc/llvm-project?rev=263900&view=rev
Log:
[clang-tidy] Update check for API change in r263895.
for range stmts now have split begin and ends, just apply OR to the
condition. Should unbreak the build.
Modified
mspertus added a comment.
Committed as revision 263638. At Chandler's suggestion, I am going to send an
announcement to cfe-dev letting people know of all of the recent improvements
to native visualizers
http://reviews.llvm.org/D18163
___
cfe-comm
fowles marked 4 inline comments as done.
fowles added a comment.
http://reviews.llvm.org/D18149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a subscriber: aaron.ballman.
Comment at: cppcoreguidelines/ProTypeMemberInitCheck.cpp:183
@@ +182,3 @@
+ // Skip delayed template instantiation declarations.
+ const auto *Body = Ctor->getBody();
+ if (!Body)
Please do not use auto here sinc
Author: dblaikie
Date: Thu Mar 17 13:05:07 2016
New Revision: 263730
URL: http://llvm.org/viewvc/llvm-project?rev=263730&view=rev
Log:
Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated
passed.
Fix implicit copy ctor and copy assignment operator warnings
when -Wdeprec
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:94
@@ +93,3 @@
+ bool Bool{false};
+ // CHECK-FIXES: bool Bool{false};
+};
Why is this checking
On Sat, Mar 19, 2016 at 8:29 PM, Mike Spertus wrote:
> mspertus added a comment.
>
> Based on Aaron's agreement to conducting post-commit reviews, I've committed
> this as revision 263890. Please let me know if I should not have done so.
> (This change is a lot smaller and simpler than I feared
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
Displays a FunctionDecl in the Visual Studio Locals Window something like:
void g(int, double d, struct A && arr)
http://reviews.llvm.org/D18303
Files:
clang.natvis
I
baloghadamsoftware updated this revision to Diff 50932.
baloghadamsoftware added a comment.
Previous patch generation failed.
http://reviews.llvm.org/D17986
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index
bcraig added a comment.
Visual Studio has a flag, /Zc:wchar_t-, that turns wchar_t into a short. This
flag is for people that need to maintain ABI compatibility with ancient Visual
Studios (MSVC6? MSVC5?). It is definitely non-conformant, and many things
support it poorly.
I still have night
ryee88 added a comment.
In http://reviews.llvm.org/D16965#377864, @dblaikie wrote:
> Not sure I fully understand the issue with the existing diagnostic/change in
> wording.
>
> '::' is a nested name specifier, even if it's a degenerate case, I think - so
> the old wording doesn't seem wrong, as
sfantao added a comment.
Hi Richard,
Thanks for your review. I partitioned some of the stuff I am proposing here in
smaller patches:
http://reviews.llvm.org/D18170
http://reviews.llvm.org/D18171
http://reviews.llvm.org/D18172
These patches already try to incorporate the feedback I got in
http
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
If we can find a way to do DisplayString loops, then such a cleanup would be
welcome here as well. However, that can always be a follow-up patch if someone
discovers a good way t
Author: rksimon
Date: Sun Mar 20 11:25:23 2016
New Revision: 263908
URL: http://llvm.org/viewvc/llvm-project?rev=263908&view=rev
Log:
Fixed -Wdocumentation warning
Modified:
cfe/trunk/include/clang/Frontend/FrontendAction.h
Modified: cfe/trunk/include/clang/Frontend/FrontendAction.h
URL:
ht
flx added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:94
@@ +93,3 @@
+ bool Bool{false};
+ // CHECK-FIXES: bool Bool{false};
+};
aaron.ballman wrote:
> Why is this checking a fix? I thought that point was that this sho
Author: bogner
Date: Sun Mar 20 11:58:03 2016
New Revision: 263909
URL: http://llvm.org/viewvc/llvm-project?rev=263909&view=rev
Log:
AST: Fix some bogus indentation. NFC
Noticed by Liu Xin. Thanks!
Modified:
cfe/trunk/lib/AST/ASTImporter.cpp
Modified: cfe/trunk/lib/AST/ASTImporter.cpp
URL:
Author: bruno
Date: Sun Mar 20 13:08:32 2016
New Revision: 263912
URL: http://llvm.org/viewvc/llvm-project?rev=263912&view=rev
Log:
[VFS] Fix test to use more restrict set of headers
Modified:
cfe/trunk/test/Modules/crash-vfs-relative-overlay.m
Modified: cfe/trunk/test/Modules/crash-vfs-rela
>> // RUN: not env FORCE_CLANG_DIAGNOSTICS_CRASH= TMPDIR=%t TEMP=%t TMP=%t \
>> -// RUN: %clang -fsyntax-only %s -I %S/Inputs/crash-recovery -isysroot
>> %/t/i/\
>> +// RUN: %clang -fsyntax-only %s -I %S/Inputs/System -isysroot %/t/i/\
>
> Is this an intentional revert? Test fails for me
bruno created this revision.
bruno added reviewers: bob.wilson, dexonsmith.
bruno added a subscriber: cfe-commits.
Previously only 3 digits were valid. Increase it to 5.
http://reviews.llvm.org/D18304
Files:
include/clang/Driver/Driver.h
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Dr
Author: dcoughlin
Date: Sun Mar 20 13:24:33 2016
New Revision: 263913
URL: http://llvm.org/viewvc/llvm-project?rev=263913&view=rev
Log:
[tsan] Allow -fsanitize=thread for iOS-style simulator targets
Update the clang driver to allow -fsanitize=thread when targeting x86_64 iOS
and tvOS
simulators.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263913: [tsan] Allow -fsanitize=thread for iOS-style
simulator targets (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D18280?vs=51076&id=51132#toc
Repository:
rL LLVM
http
mspertus accepted this revision.
mspertus added a reviewer: mspertus.
mspertus added a comment.
This revision is now accepted and ready to land.
Accepting revision based on Aaron's LGTM email to reviews.llvm.org.
http://reviews.llvm.org/D18297
___
c
mspertus closed this revision.
mspertus added a comment.
Closing committed revision. Further discussion as needed on mailing list
http://reviews.llvm.org/D18297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
mspertus accepted this revision.
mspertus added a reviewer: mspertus.
mspertus added a comment.
This revision is now accepted and ready to land.
Per Aaron, I want to close the committed diff, but I seem to need to accept it
first. Further discussion as needed on mailing list
http://reviews.llvm
mspertus closed this revision.
mspertus added a comment.
Closing committed revision
http://reviews.llvm.org/D18299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mps
Date: Sun Mar 20 15:15:23 2016
New Revision: 263915
URL: http://llvm.org/viewvc/llvm-project?rev=263915&view=rev
Log:
Visual Studio Visualizers for clang::FunctionDecl
Readably displays a FunctionDecl in the Visual Studio Locals Window something
like:
void g(int, double d, struct A
mspertus added a comment.
Committed as revision 263915.
http://reviews.llvm.org/D18303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus closed this revision.
mspertus added a comment.
Closing accepted revision
http://reviews.llvm.org/D18303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Sun, Mar 20, 2016 at 7:05 AM, Renato Golin wrote:
> On 20 March 2016 at 11:33, Richard Smith via cfe-commits
> wrote:
>> Author: rsmith
>> Date: Sun Mar 20 05:33:40 2016
>> New Revision: 263895
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=263895&view=rev
>> Log:
>> P0184R0: Allow types o
On Sun, Mar 20, 2016 at 6:25 AM, Joerg Sonnenberger via cfe-commits
wrote:
> On Fri, Mar 18, 2016 at 05:11:19PM +, Richard Smith via cfe-commits wrote:
>> rsmith added a comment.
>>
>> Can you explain a bit more about the problem? It seems to me that if I have:
>>
>> struct Base {
>> cha
Author: nico
Date: Sun Mar 20 21:48:05 2016
New Revision: 263920
URL: http://llvm.org/viewvc/llvm-project?rev=263920&view=rev
Log:
clang-cl: Add a comment about /Oy- (see r245913).
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
Modified: cfe/trunk/include/clang/Driver/CLCompatOp
Samuel, this is true for device part of codegen. But what about host? If
this code must be executed on host, will it be handled correctly?
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
18.03.2016 23:03, Samuel Antao пишет:
> sfantao added a comment.
>
> Hi Alexe
ABataev added inline comments.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:913-929
@@ -912,9 +912,19 @@
});
- } else if (auto *ASE = dyn_cast(IRef)) {
-auto *Base = ASE->getBase()->IgnoreParenImpCasts();
-while (auto *TempASE = dyn_cast(Base))
-
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:53-57
@@ -52,2 +52,7 @@
auto &&CodeGen = [&D](CodeGenFunction &CGF) {
+CodeGenFunction::OMPPrivateScope PrivateScope(CGF);
+(void)CGF.EmitOMPFirstprivateClause(D, PrivateScope);
+CGF.Emi
pxli168 updated this revision to Diff 51140.
pxli168 added a comment.
Refine other check using the changed diag.
Change test as well.
http://reviews.llvm.org/D17955
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl
I
61 matches
Mail list logo
