danielmarjamaki updated this revision to Diff 46235.
danielmarjamaki added a comment.
Refactoring the AST matching
http://reviews.llvm.org/D16310
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MisplacedWideningCastCheck.cpp
clang-tidy/misc/Mispl
danielmarjamaki added a comment.
In http://reviews.llvm.org/D16310#337563, @LegalizeAdulthood wrote:
> In http://reviews.llvm.org/D16310#335844, @danielmarjamaki wrote:
>
> > There were some new interesting warnings and imho they were TP.
>
>
> TP?
Sorry.. True Positive
Comme
danielmarjamaki marked an inline comment as done.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:33
@@ +32,3 @@
+ Finder->addMatcher(varDecl(has(Cast)), this);
+ Finder->addMatcher(binaryOperator(hasOperatorName("="), hasRHS(Cast)), this);
+}
I have
DmitryPolukhin added a comment.
LGTM
http://reviews.llvm.org/D16607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ygribov
Date: Thu Jan 28 03:27:46 2016
New Revision: 259030
URL: http://llvm.org/viewvc/llvm-project?rev=259030&view=rev
Log:
Small refactor in isBeforeInTranslationUnit.
Differential Revision: http://reviews.llvm.org/D15804
Modified:
cfe/trunk/lib/Basic/SourceManager.cpp
Modified:
Author: ygribov
Date: Thu Jan 28 03:28:18 2016
New Revision: 259031
URL: http://llvm.org/viewvc/llvm-project?rev=259031&view=rev
Log:
Fix isBeforeInTranslationUnit to not abort on macros defined in cmdline.
Differential Revision: http://reviews.llvm.org/D15804
Modified:
cfe/trunk/lib/Basic/S
Author: olista01
Date: Thu Jan 28 04:07:34 2016
New Revision: 259036
URL: http://llvm.org/viewvc/llvm-project?rev=259036&view=rev
Log:
Add backend dignostic printer for unsupported features
Re-commit of r258950 after fixing layering violation.
Add backend dignostic printer for unsupported featur
olista01 added a comment.
This was reverted last night, I've re-committed it as r259036 with the layering
violation fixed.
Repository:
rL LLVM
http://reviews.llvm.org/D16591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
rmaprath added inline comments.
Comment at: test/support/noexcept.h:23
@@ +22,3 @@
+// tests use multiple catch statements, in those cases we have to use the
+// _LIBCPP_NO_EXCEPTIONS macro and exclude the additional catch statements.
+#ifndef _LIBCPP_NO_EXCEPTIONS
---
Author: olista01
Date: Thu Jan 28 07:09:49 2016
New Revision: 259043
URL: http://llvm.org/viewvc/llvm-project?rev=259043&view=rev
Log:
Revert r259036, it introduces a cyclic library dependency
Removed:
cfe/trunk/test/CodeGen/backend-unsupported-error.ll
Modified:
cfe/trunk/include/clang/B
ichesnokov updated this revision to Diff 46229.
ichesnokov marked 2 inline comments as done.
http://reviews.llvm.org/D16351
Files:
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/implicit-typedef.cl
tools/driver/driver.cpp
Index: tools/driver/driver.cpp
==
joelkevinjones added a comment.
Did you mean remove the duplication from addPassesToEmitFile mentioned in the
FIXME or something else?
http://reviews.llvm.org/D16538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: dsanders
Date: Thu Jan 28 07:49:33 2016
New Revision: 259046
URL: http://llvm.org/viewvc/llvm-project?rev=259046&view=rev
Log:
[libcxx] Work around for clang calling GAS after having already failed.
Summary:
This is a workaround to a clang bug which causes libcxx tests to fail in the 3.8
Hi Hans,
Is it ok to merge this into 3.8? Eric Fiselier has already approved on the
review.
From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Daniel
Sanders via cfe-commits [cfe-commits@lists.llvm.org]
Sent: 28 January 2016 13:49
To: cfe
AndyG added a comment.
Yes, but only for the "data argument not used" warning. All other warnings are
unaffected by the change, for example:
test.cpp:9:51: warning: format specifies type 'char *' but the argument has
type 'int' [-Wformat]
rmaprath updated this revision to Diff 46264.
rmaprath added a comment.
Addressing review comments by @rjmccall:
Moved all the AAPCS specific tweaks to EmitLValueForField(), this simplified
the patch a lot (now there is no mucking about a de-constructed GEP at
load/store points). In order to do
rmaprath marked 2 inline comments as done.
rmaprath added a comment.
http://reviews.llvm.org/D16586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vkalintiris updated this revision to Diff 46272.
vkalintiris added a comment.
Don't use LLVM's CheckAtomic cmake module. Instead, use a libcxx-specific one
that allows checking for 64-bit atomics too.
http://reviews.llvm.org/D16613
Files:
cmake/Modules/CheckLibcxxAtomic.cmake
cmake/config-i
Test case?
On Thu, Jan 28, 2016 at 1:28 AM, Yury Gribov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ygribov
> Date: Thu Jan 28 03:28:18 2016
> New Revision: 259031
>
> URL: http://llvm.org/viewvc/llvm-project?rev=259031&view=rev
> Log:
> Fix isBeforeInTranslationUnit to not abo
uweigand added a subscriber: uweigand.
uweigand added a comment.
Now that our build bot is up and running again, I noticed that the newly added
test pipe_types.cl fails on SystemZ:
/home3/uweigand/llvm/llvm-head/tools/clang/test/CodeGenOpenCL/pipe_types.cl:26:11:
error: expected string not f
Would this patch be more reasonable? It follows what
RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this
adds an update record far less often.
--Vassil
On 12/12/15 16:13, Vassil Vassilev wrote:
I couldn't find GetDecl routine in the ASTWriter. Could you elaborate?
Assuming
joerg added a comment.
Thanks for working on it. I think it might be slightly better to explicitly
test uintmax_t and uintptr_t as well. They could be larger than long long int
and there are tests depending on the existance.
Do we have any test cases for arbitrary sized trivally copyable struct
Author: dsanders
Date: Thu Jan 28 10:51:36 2016
New Revision: 259058
URL: http://llvm.org/viewvc/llvm-project?rev=259058&view=rev
Log:
Merging r258920:
r258920 | dsanders | 2016-01-27 10:45:07 + (Wed, 27 Jan 2016) | 11 li
vkalintiris updated this revision to Diff 46286.
vkalintiris added a comment.
Check for atomcis on uintmax_t/uintptr_t instead of long long int.
http://reviews.llvm.org/D16613
Files:
cmake/Modules/CheckLibcxxAtomic.cmake
cmake/config-ix.cmake
lib/CMakeLists.txt
test/CMakeLists.txt
tes
yaxunl created this revision.
yaxunl added reviewers: Anastasia, pxli168, pekka.jaaskelainen.
yaxunl added subscribers: tstellarAMD, cfe-commits.
Add codegen and diagnostics for opencl_unroll_hint attribute.
The code is based on Khronos OpenCL compiler
(https://github.com/KhronosGroup/SPIR/tree/
Manman Ren via cfe-commits writes:
> manmanren created this revision.
> manmanren added reviewers: echristo, rafael, ahatanak.
> manmanren added a subscriber: cfe-commits.
>
> It can happen that frontend emits error message when releasing the
> builder. When that happens, we emit the error message
Author: vedantk
Date: Thu Jan 28 11:52:18 2016
New Revision: 259061
URL: http://llvm.org/viewvc/llvm-project?rev=259061&view=rev
Log:
[Coverage] Use a set to track visited FileIDs (NFC)
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.
Yes, go ahead.
Thanks,
Hans
On Thu, Jan 28, 2016 at 5:57 AM, Daniel Sanders
wrote:
> Hi Hans,
>
> Is it ok to merge this into 3.8? Eric Fiselier has already approved on the
> review.
>
> From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of
xur added a comment.
I'll send an updated patch shortly.
Comment at: include/clang/Frontend/CodeGenOptions.def:106
@@ -105,3 +105,3 @@
-CODEGENOPT(ProfileInstrGenerate , 1, 0) ///< Instrument code to generate
-///< execution counts to us
Anastasia added a comment.
No, this shouldn't happen! There shouldn't be any difference in emitted IR
depending on a platform. I also don't see any code in CodeGen that could
specialize.
Is there a way to reproduce your compilation? Passing any triple?
http://reviews.llvm.org/D15603
__
Author: nico
Date: Thu Jan 28 12:06:31 2016
New Revision: 259063
URL: http://llvm.org/viewvc/llvm-project?rev=259063&view=rev
Log:
Fix strange indent.
Modified:
cfe/trunk/lib/CodeGen/CGStmt.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib
bcraig updated this revision to Diff 46291.
bcraig added a comment.
CloudABI doesn't define __unix__, so stop blacklisting it explicitly and let
the whitelist filter it out.
http://reviews.llvm.org/D16639
Files:
include/__config
include/locale
Index: include/locale
===
bcraig updated this revision to Diff 46292.
bcraig added a comment.
CloudABI doesn't define unix, so stop blacklisting it explicitly and let the
whitelist filter it out.
http://reviews.llvm.org/D16634
Files:
src/thread.cpp
Index: src/thread.cpp
==
bcraig added a comment.
I plan on submitting this tomorrow morning (my time) so that I have lots of
time to monitor build failures.
http://reviews.llvm.org/D16634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
jlebar updated this revision to Diff 46293.
jlebar added a comment.
Address echristo's review comments.
http://reviews.llvm.org/D16664
Files:
lib/CodeGen/CGCUDABuiltin.cpp
test/CodeGenCUDA/printf.cu
Index: test/CodeGenCUDA/printf.cu
=
jlebar marked an inline comment as done.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:109
@@ -106,1 +108,3 @@
+// stacksave/stackrestore intrinsics, which cause ptxas to choke.
+auto *Alloca = new llvm::AllocaInst(
llvm::Type::getInt8Ty(Ctx), llvm::ConstantInt::get(I
jlebar marked an inline comment as done.
jlebar added a comment.
http://reviews.llvm.org/D16664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: davidxl
Date: Thu Jan 28 12:25:53 2016
New Revision: 259067
URL: http://llvm.org/viewvc/llvm-project?rev=259067&view=rev
Log:
[PGO] test case cleanups
1. Make test case more focused and robust by focusing on what to be tested
(linkage, icall) -- make it easier to validate
2. Testing link
uweigand added a comment.
In http://reviews.llvm.org/D15603#338488, @Anastasia wrote:
> No, this shouldn't happen! There shouldn't be any difference in emitted IR
> depending on a platform. I also don't see any code in CodeGen that could
> specialize.
>
> Is there a way to reproduce your compil
Author: mren
Date: Thu Jan 28 12:49:28 2016
New Revision: 259070
URL: http://llvm.org/viewvc/llvm-project?rev=259070&view=rev
Log:
Class Property: class property and instance property can have the same name.
Add "enum ObjCPropertyQueryKind" to a few APIs that used to only take the name
of the pro
tra added inline comments.
Comment at: include/clang/Driver/Options.td:1807
@@ +1806,3 @@
+"CUDA compilation without --save-temps.">;
+def nostop_on_failure : Flag<["-"], "nostop-on-failure">,
Flags<[DriverOption]>;
+
I'd use 'no-' prefix.
C
Author: nico
Date: Thu Jan 28 13:12:32 2016
New Revision: 259077
URL: http://llvm.org/viewvc/llvm-project?rev=259077&view=rev
Log:
Remove unused parameter.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/
Alexey: you're the owner of openmp in Clang.
Can you comment on what should be merged here?
On Tue, Jan 26, 2016 at 3:43 PM, Jack Howarth
wrote:
> Tested the attached patch which contains a back port of the net
> changes from both r258307 and
>
> Author: abataev
> Date: Fri Jan 22 02:56:50 2016
I don't think we have a specific code owner for OpenCL in Clang, which
means Richard is the owner.
Richard, what do you think?
On Wed, Jan 27, 2016 at 10:08 PM, xiuli pan wrote:
> Hi hans,
>
> Request to merge it to release 38
>
> It adds Pipe BIFs to be used along with Pipe type committed earli
Sorry for the slow reply.
I've replied on the r258782 thread.
On Tue, Jan 26, 2016 at 10:29 AM, Anastasia Stulova
wrote:
> Could you please merge Clang commit r258782 into release 3.8.
>
>
>
> It adds Pipe BIFs to be used along with Pipe type committed earlier (in
> r257254).
>
>
>
> Thanks,
>
>
Author: nico
Date: Thu Jan 28 13:25:00 2016
New Revision: 259079
URL: http://llvm.org/viewvc/llvm-project?rev=259079&view=rev
Log:
Include RecordDecls from anonymous unions in the AST.
For
void f() {
union { int i; };
}
clang used to omit the RecordDecl from the anonymous union from the
jlebar updated this revision to Diff 46300.
jlebar marked an inline comment as done.
jlebar added a comment.
Address tra's review comment (rename flag).
http://reviews.llvm.org/D16514
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include/clang/Driver/Options.td
jlebar added inline comments.
Comment at: lib/Driver/Driver.cpp:650
@@ -638,3 +649,3 @@
SmallVector, 4> FailingCommands;
- C.ExecuteJobs(C.getJobs(), FailingCommands);
+ C.ExecuteJobs(C.getJobs(), /* StopOnFailure = */ false, FailingCommands);
tra wrote:
>
manmanren updated this revision to Diff 46301.
manmanren added a comment.
Addressing comments from Akira and Justin.
http://reviews.llvm.org/D16564
Files:
lib/CodeGen/ModuleBuilder.cpp
test/CodeGen/target-builtin-error-3.c
Index: test/CodeGen/target-builtin-error-3.c
==
I'm also just curious how we got all the way to here without having the
error emitted and compilation stopped?
-eric
On Thu, Jan 28, 2016 at 9:53 AM Justin Bogner wrote:
> Manman Ren via cfe-commits writes:
> > manmanren created this revision.
> > manmanren added reviewers: echristo, rafael, a
Anastasia added a comment.
Yes, I see that it happens only for some vector types. The CodeGen follows
quite different paths for both targets. And in the case of s390x-linux-gnu it
ends up in ABIArgInfo::Indirect case of the second switch statement where an
additional pointer will be added here:
Hello everyone,
LLVM buildmaster will be taken off-line today after 5 PM Pacific for short
time for maintenance and also will be updated.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
rnk added inline comments.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:105-108
@@ -104,2 +104,6 @@
} else {
-BufferPtr = Builder.Insert(new llvm::AllocaInst(
+// Insert our alloca not into the current BB, but into the function's entry
+// block. This is important bec
Anastasia added a comment.
Btw, just to be clear in my previous comment I was referring to the 2nd switch
statement in CodeGenTypes::GetFunctionType that contains the line:
ArgTypes[FirstIRArg] = LTy->getPointerTo();
http://reviews.llvm.org/D15603
_
thakis added a comment.
rnk, I added you because you hacked in this general area a while ago in
r187528. Since Richard is out, do you think you can take a look?
http://reviews.llvm.org/D16478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
echristo added inline comments.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:109
@@ -106,1 +108,3 @@
+// stacksave/stackrestore intrinsics, which cause our nvvm backend to
choke.
+auto *Alloca = new llvm::AllocaInst(
llvm::Type::getInt8Ty(Ctx), llvm::ConstantInt::ge
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
Yep. As I said, I expect to be on the losing side of that argument - just too
much prior art :)
-eric
http://reviews.llvm.org/D15999
_
xur updated this revision to Diff 46303.
xur added a comment.
Integrated most recently comments/suggestions from David and Sean.
Thanks,
-Rong
http://reviews.llvm.org/D15829
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Optio
FYI :)
Here is the back trace when emitting the error:
* frame #0: 0x00010271ea30
clang`clang::CodeGen::CodeGenFunction::EmitBuiltinExpr(this=0x7fff5fbf8c58,
FD=0x00010f214260, BuiltinID=1483, E=0x00010f214500,
ReturnValue=ReturnValueSlot at 0x7fff5fbf5fe0) + 49360 at
CGBuil
echristo added a comment.
In general it feels like keeping 2 errors might make the most sense:
(Using a multiarch build rather than a cuda command line, but it should still
be the same behavior for consistency)
t.c:
#if _NOT_ARCH4_
#error "aiee!"
#endif
clang -arch arch1 -arch arch2 -arch arc
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/Driver/Driver.cpp:652
@@ -640,3 +651,3 @@
SmallVector, 4> FailingCommands;
- C.ExecuteJobs(C.getJobs(), FailingCommands);
+ C.ExecuteJobs(C.getJobs(), /*
rnk added a comment.
The fact that an instantiated type might point to decls from the template
pattern seems like expected behavior. The parts of the template that are the
same are supposed to be shared.
Can we dig in to what is going wrong in parent map construction?
http://reviews.llvm.org/
thakis added a comment.
In http://reviews.llvm.org/D16478#338653, @rnk wrote:
> The fact that an instantiated type might point to decls from the template
> pattern seems like expected behavior. The parts of the template that are the
> same are supposed to be shared.
>
> Can we dig in to what is
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: eugenezelenko
Date: Thu Jan 28 15:00:21 2016
New Revision: 259091
URL: http://llvm.org/viewvc/llvm-project?rev=259091&view=rev
Log:
Remove autoconf support.
Differential revision: http://reviews.llvm.org/D16651
Removed:
libcxx/trunk/Makefile
Removed: libcxx/trunk/Makefile
URL:
http
Thanks. Merged in r259092.
From: hwennb...@google.com [hwennb...@google.com] on behalf of Hans Wennborg
[h...@chromium.org]
Sent: 28 January 2016 17:56
To: Daniel Sanders
Cc: cfe-commits@lists.llvm.org; e...@efcs.ca
Subject: Re: [libcxx] r259046 - [libcxx]
Author: dsanders
Date: Thu Jan 28 15:03:16 2016
New Revision: 259092
URL: http://llvm.org/viewvc/llvm-project?rev=259092&view=rev
Log:
Merging r259046:
r259046 | dsanders | 2016-01-28 13:49:33 + (Thu, 28 Jan 2016) | 18 li
jlebar added a comment.
In http://reviews.llvm.org/D16514#338631, @echristo wrote:
> In general it feels like keeping 2 errors might make the most sense:
>
> #if _NOT_ARCH4_
> #error "aiee!"
> #endif
>
> clang -arch arch1 -arch arch2 -arch arch3 -arch arch4 t.c
>
> seems like it might be nice t
Author: ssrivastava
Date: Thu Jan 28 15:36:31 2016
New Revision: 259095
URL: http://llvm.org/viewvc/llvm-project?rev=259095&view=rev
Log:
Implementation of PS4 ABI, Round 1
Added a test to safeguard linux ABI.
Differential Revision: http://reviews.llvm.org/D16607
Modified:
cfe/trunk/test/Sem
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259095: Implementation of PS4 ABI, Round 1 (authored by
ssrivastava).
Changed prior to commit:
http://reviews.llvm.org/D16607?vs=46060&id=46310#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16607
tra added inline comments.
Comment at: lib/Driver/Driver.cpp:652
@@ -640,3 +651,3 @@
SmallVector, 4> FailingCommands;
- C.ExecuteJobs(C.getJobs(), FailingCommands);
+ C.ExecuteJobs(C.getJobs(), /* StopOnFailure = */ false, FailingCommands);
jlebar wrote:
>
thakis added a comment.
Did this ever land? Looks like it's lgtm'd and ready to go, and it looks like a
useful warning.
http://reviews.llvm.org/D3976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
The instantiated does get a new collection of ParmVarDecls while getting
the pattern Type which points to the pattern ParmVarDecls. So the
ParmVarDecls pointed in the instantiated are not the same as those pointed
by its Type.
Traversing by Type or by the Decl finds a different set of ParmVarDecls
Exactly :-)
On Thu, Jan 28, 2016 at 5:07 PM, Yaron Keren wrote:
> The instantiated does get a new collection of ParmVarDecls while getting
> the pattern Type which points to the pattern ParmVarDecls. So the
> ParmVarDecls pointed in the instantiated are not the same as those pointed
> by its Typ
ygao created this revision.
ygao added subscribers: gkistanova, sqlbyme, cfe-commits, llvm-commits.
Hi,
So this patch tries to enable tests that will output to the console. These
tests are otherwise not exercised.
Note that the outputs will stay on the console and will not be saved into the
test
Author: dcoughlin
Date: Thu Jan 28 16:23:34 2016
New Revision: 259099
URL: http://llvm.org/viewvc/llvm-project?rev=259099&view=rev
Log:
[analyzer] Suppress nullability warnings in copy, mutableCopy, and init
families.
There are multiple, common idioms of defensive nil-checks in copy,
mutableCopy
jlebar updated this revision to Diff 46314.
jlebar marked an inline comment as done.
jlebar added a comment.
Use a struct rather than an i8 buffer.
http://reviews.llvm.org/D16664
Files:
lib/CodeGen/CGCUDABuiltin.cpp
test/CodeGenCUDA/printf.cu
Index: test/CodeGenCUDA/printf.cu
=
jlebar marked 3 inline comments as done.
jlebar added a comment.
Thank you for the reviews.
Please have another look; I switched to using a struct proper. It's a lot
cleaner! We're now assuming that the struct is aligned in the same way as
vprintf wants, but if anything I expect this new code
The previous patch was not good as it failed 58 tests that use
-fprofile-instr-generate as a cc1 option.
I can see two methods to solve this:
(1) we change all the 58 tests to use -fprofile-instrument=Clang option.
(2) Fall back to my previous patch: keep -fprofile-instr-generate as
the CC1 option
xur added a comment.
The previous patch was not good as it failed 58 tests that use
-fprofile-instr-generate as a cc1 option.
I can see two methods to solve this:
(1) we change all the 58 tests to use -fprofile-instrument=Clang option.
(2) Fall back to my previous patch: keep -fprofile-instr-gene
jlebar updated this revision to Diff 46315.
jlebar marked 3 inline comments as done.
jlebar added a comment.
Pass StopOnFailure = true when running the preprocessor after an ICE.
http://reviews.llvm.org/D16514
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include
jlebar added inline comments.
Comment at: lib/Driver/Driver.cpp:652
@@ -640,3 +651,3 @@
SmallVector, 4> FailingCommands;
- C.ExecuteJobs(C.getJobs(), FailingCommands);
+ C.ExecuteJobs(C.getJobs(), /* StopOnFailure = */ false, FailingCommands);
tra wrote:
>
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Seems like a weird place to handle this, but it's been there for a long time.
That said, I see how we can get there now, thanks!
-eric
http://reviews.llvm.org/D16564
_
echristo added a comment.
> The other reason, which is less important, is that when you have one arch and
> ptxas fails -- which, it shouldn't, but we're not good enough to catch
> everything yet, and likely won't be for some time -- the error you get is
>
> ptxas: foo is not defined
>
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
One inline nit then LGTM.
-eric
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:87
@@ +86,3 @@
+ // Construct and fill the args buffer tha
Author: rafael
Date: Thu Jan 28 16:56:41 2016
New Revision: 259108
URL: http://llvm.org/viewvc/llvm-project?rev=259108&view=rev
Log:
Update for llvm change.
Modified:
cfe/trunk/test/CodeGen/pr18235.c
Modified: cfe/trunk/test/CodeGen/pr18235.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/tru
On Thu, Jan 28, 2016 at 2:34 PM, Rong Xu wrote:
> The previous patch was not good as it failed 58 tests that use
> -fprofile-instr-generate as a cc1 option.
>
> I can see two methods to solve this:
> (1) we change all the 58 tests to use -fprofile-instrument=Clang option.
My vote is on (1) -- get
davidxl added inline comments.
Comment at: lib/Driver/Tools.cpp:3232
@@ -3231,2 +3231,3 @@
CmdArgs.push_back(
Args.MakeArgString(Twine("-fprofile-instr-generate=") + Path));
+}
I also suggest changing CC1 option -fprofile-instr-generate= to b
Author: mren
Date: Thu Jan 28 17:29:02 2016
New Revision: 259116
URL: http://llvm.org/viewvc/llvm-project?rev=259116&view=rev
Log:
Check for frontend errors after releasing the Builder.
Frontend can emit errors when releaseing the Builder. If there are errors before
or when releasing the Builder,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259116: Check for frontend errors after releasing the
Builder. (authored by mren).
Changed prior to commit:
http://reviews.llvm.org/D16564?vs=46301&id=46320#toc
Repository:
rL LLVM
http://reviews.ll
Author: dcoughlin
Date: Thu Jan 28 17:34:13 2016
New Revision: 259118
URL: http://llvm.org/viewvc/llvm-project?rev=259118&view=rev
Log:
[analyzer] NullabilityChecker: Remove unused isReturnSelf() function.
Remove the now-unused isReturnSelf() function so we don't get a compiler
warning. Apologies
Author: mren
Date: Thu Jan 28 17:36:05 2016
New Revision: 259119
URL: http://llvm.org/viewvc/llvm-project?rev=259119&view=rev
Log:
Class Property: change PropertyMap to include isClassProperty.
PropertyMap used to map IdentifierInfo (name of the property) to
ObjcPropertyDecl *. Now that a class p
jlebar marked an inline comment as done.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:87
@@ +86,3 @@
+ // Construct and fill the args buffer that we'll pass to vprintf.
+ llvm::Value* BufferPtr;
+ if (Args.size() <= 1) {
echristo wrote:
> * on the wrong side ;)
Ar
This revision was automatically updated to reflect the committed changes.
jlebar marked an inline comment as done.
Closed by commit rL259122: [CUDA] Generate CUDA's printf alloca in its
function's entry block. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16664?vs=4631
Author: jlebar
Date: Thu Jan 28 17:58:28 2016
New Revision: 259122
URL: http://llvm.org/viewvc/llvm-project?rev=259122&view=rev
Log:
[CUDA] Generate CUDA's printf alloca in its function's entry block.
Summary:
This is necessary to prevent llvm from generating stacksave intrinsics
around this allo
echristo added inline comments.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:87
@@ +86,3 @@
+ // Construct and fill the args buffer that we'll pass to vprintf.
+ llvm::Value* BufferPtr;
+ if (Args.size() <= 1) {
jlebar wrote:
> echristo wrote:
> > * on the wrong s
Do you have a script that will take as input a commit range and git
commit --amend clang-tidy fixes for lines modified in that range?
Because if so,
a) I would be your best friend forever, and
b) It should be simple to convert that into a linter for arc to catch
the case when I forget to run said
Hm, well,
https://llvm.org/svn/llvm-project/cfe/trunk/tools/clang-format/git-clang-format
is close... Not sure if that triggers the bff clause, will consult my
attorney.
On Thu, Jan 28, 2016 at 4:09 PM, Justin Lebar wrote:
> Do you have a script that will take as input a commit range and git
>
kromanova created this revision.
kromanova added reviewers: dblaikie, echristo, probinson.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Hello,
The compiler always emits .debug_line version 2, though some opcodes from DWARF
3 (e.g. DW_LNS_se
+Adrian for Apple/LLDB perspective
One way to merge the tests would be to add another command line argument
into DwarfDebug (see the way the split-dwarf command line argument is
used), just for testing purposes. The command line argument can override
the value specified in the metadata - so you ca
1 - 100 of 126 matches
Mail list logo
