xur added a comment. The previous patch was not good as it failed 58 tests that use -fprofile-instr-generate as a cc1 option.
I can see two methods to solve this: (1) we change all the 58 tests to use -fprofile-instrument=Clang option. (2) Fall back to my previous patch: keep -fprofile-instr-generate as the CC1 options and check it in Frontend/CompilerInvocation.cpp. (i.e. The redundant else branch Sean was referring to). We have to do it here because we cannot assume driver will append -fprofile-instrument=Clang in the case the user uses -fprofile-instr-generate as the cc1 option. http://reviews.llvm.org/D15829 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
