Hi James,
> I reverted this change with r258894, as it breaks (at least) sparc-rtems.
Can you send me a reproducer, please?
Right now I'm at a dead end -- no tests are broken, and no buildbots
are reported any fails. Yet you claim that my patch breaks one target
-- and there is zero info how to
dsanders added a comment.
Thanks
> @dsanders: What platform are you on that doesn't have en_US.UTF-8? If your
> serious about testing libc++ you should install the locale. (but I understand
> that's not always possible).
It's Debian Jessie but it was configured for the Europe/London region du
Author: d0k
Date: Wed Jan 27 04:01:30 2016
New Revision: 258918
URL: http://llvm.org/viewvc/llvm-project?rev=258918&view=rev
Log:
Update for LLVM change.
Modified:
cfe/trunk/lib/Parse/ParseStmtAsm.cpp
cfe/trunk/tools/driver/cc1as_main.cpp
Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp
UR
Author: dsanders
Date: Wed Jan 27 04:45:07 2016
New Revision: 258920
URL: http://llvm.org/viewvc/llvm-project?rev=258920&view=rev
Log:
[libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.
Summary:
These are the tests that didn't fail in the release candidate because they w
dsanders added a comment.
Thanks. Given that you're the patch author should I wait for someone else to
LGTM too?
http://reviews.llvm.org/D16584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
nemanjai added a comment.
Thank you for the discussion on rank. I'm glad we have an agreement on the rank
of the two types.
However, considering __float128 already has a higher rank in this patch, is
there anything else that you would like me to change here before the patch is
approved?
Do you
rob.lougher added a comment.
Ping.
http://reviews.llvm.org/D16298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Wed Jan 27 05:37:12 2016
New Revision: 258925
URL: http://llvm.org/viewvc/llvm-project?rev=258925&view=rev
Log:
[clang-tidy] Use relative URL for redirection.
Modified:
clang-tools-extra/trunk/docs/clang-tidy.rst
Modified: clang-tools-extra/trunk/docs/clang-tidy.rst
URL:
Author: alexfh
Date: Wed Jan 27 05:37:08 2016
New Revision: 258924
URL: http://llvm.org/viewvc/llvm-project?rev=258924&view=rev
Log:
Add clang-tools-extra documentation to the CMake build.
Added:
clang-tools-extra/trunk/docs/CMakeLists.txt
clang-tools-extra/trunk/docs/doxygen.cfg.in
c
Author: alexfh
Date: Wed Jan 27 05:37:19 2016
New Revision: 258926
URL: http://llvm.org/viewvc/llvm-project?rev=258926&view=rev
Log:
[clang-tidy] Fix documentation.
Fixed broken links to cppcoreguidelines (anchors specified in the .md file
should be used, not automatic anchors generated by github
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
Seems sensible. LGTM!
http://reviews.llvm.org/D15721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
d.zobnin.bugzilla added a comment.
Friendly ping, please take a look.
http://reviews.llvm.org/D16219
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov marked an inline comment as done.
Comment at: lib/Sema/SemaDecl.cpp:2039
@@ +2038,3 @@
+ if (Old->isImplicit() || New->isImplicit()) {
+ return;
+ }
asl wrote:
> Please follow the LLVM's coding style guidelines. E.g. *never* use tabs.
It is no
Tested the attached patch which contains a back port of the net
changes from both r258307 and
Author: abataev
Date: Fri Jan 22 02:56:50 2016
New Revision: 258495
URL: http://llvm.org/viewvc/llvm-project?rev=258495&view=rev
Log:
[OPENMP] Generalize codegen for 'sections'-based directive.
If 'secti
Imagine there's a 2d table of values for UserLabelPrefix, each row for CPU
and column for OS. The value of many if those cells was changed by this
commit, because you stopped painting columns as "".
That is, originally, the default entry was "_", then cpu rows were filled,
and then the os columns
andreybokhanko created this revision.
andreybokhanko added reviewers: rnk, mkuper, rafael.
andreybokhanko added a subscriber: cfe-commits.
Correct setting of WIntType for MCU target
http://reviews.llvm.org/D16626
Files:
lib/Basic/Targets.cpp
test/Preprocessor/elfiamcu-predefines.c
Index: li
aaron.ballman added a comment.
In http://reviews.llvm.org/D16012#331219, @aaron.ballman wrote:
> Ping
Ping
http://reviews.llvm.org/D16012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
What's the benefit of storing this? You can get the same effect by
re-lexing. We don't guarantee that the pretty printed version of the AST
comprises the same sequence of tokens in general.
On 27 Jan 2016 3:03 p.m., "Aaron Ballman via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> aaron.ballm
olista01 removed rL LLVM as the repository for this revision.
olista01 updated this revision to Diff 46127.
olista01 added a comment.
Added a test for the new diagnostic printer.
http://reviews.llvm.org/D16591
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
lib/CodeGen/CodeGenAction.c
On Wed, Jan 27, 2016 at 9:08 AM, Richard Smith wrote:
> What's the benefit of storing this? You can get the same effect by
> re-lexing. We don't guarantee that the pretty printed version of the AST
> comprises the same sequence of tokens in general.
So we don't lose information the user wrote. Fo
hubert.reinterpretcast added a comment.
In http://reviews.llvm.org/D15120#337144, @nemanjai wrote:
> Do you suggest that we need to allow operations (or at least assignments)
> between the two types and take away the diagnostics that are part of this
> patch?
My overriding concern at this tim
hubert.reinterpretcast added a comment.
In http://reviews.llvm.org/D15120#337144, @nemanjai wrote:
> Do you suggest that we need to allow operations (or at least assignments)
> between the two types and take away the diagnostics that are part of this
> patch?
My overriding concern at this tim
sberg created this revision.
sberg added a reviewer: rnk.
sberg added a subscriber: cfe-commits.
The Microsoft compiler emits
warning C4229: anachronism used : modifiers on data are ignored
for
struct {} __cdecl s;
but ICU's gendict can generate such (and does when building LibreOffice), s
Yes, I understand this -- but the whole idea of my patch is to change
the blanket default, on the whole table.
Rafael believes this is the right thing to do (actually, he is the one
who requested the change), and judging by feedback on PR26255, he is
right.
Please let me know when you'll add the
Hahnfeld added a reviewer: mcrosier.
Hahnfeld added a comment.
Any comments on this change?
http://reviews.llvm.org/D15920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from one nitpick about the diagnostic wording, this LGTM.
Comment at: include/clang/Basic/Attr.td:882
@@ -881,3 +881,3 @@
let Spellings = [GCC<"mode">];
Author: tstellar
Date: Wed Jan 27 08:52:07 2016
New Revision: 258932
URL: http://llvm.org/viewvc/llvm-project?rev=258932&view=rev
Log:
Add _CLC_V_V_VP_VECTORIZE macro
Patch by: Pavel Ondračka
Modified:
libclc/trunk/generic/lib/clcmacro.h
Modified: libclc/trunk/generic/lib/clcmacro.h
URL:
h
Author: tstellar
Date: Wed Jan 27 08:52:10 2016
New Revision: 258933
URL: http://llvm.org/viewvc/llvm-project?rev=258933&view=rev
Log:
Implement modf math builtin
V2: use the reference implementation as suggested by Matt Arsenault
Patch By: Pavel Ondračka
Added:
libclc/trunk/generic/include
alexfh added inline comments.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:27
@@ +26,3 @@
+ // we only transform ASCII string literals
+ if (!Literal->isAscii())
+return false;
Why can't the check convert non-ascii string literals to correspond
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added reviewers: kcc, rsmith.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Fix the issue discovered by fuzzing
(https://llvm.org/bugs/show_bug.cgi?id=23057#c18) by handling nullptr in
Sema::ActOnCXXForRangeDecl and correct delayed
probinson added a comment.
Subscribed the reviewers of http://reviews.llvm.org/D14980, which had fixed the
alignment-attribute layout bug.
http://reviews.llvm.org/D16607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
sberg created this revision.
sberg added a reviewer: rnk.
sberg added a subscriber: cfe-commits.
...in cases where a member function is redeclared as a friend of a nested
class. (LibreOffice happens to get tripped up by this.)
http://reviews.llvm.org/D16632
Files:
lib/CodeGen/CodeGenModule.c
Author: cbieneman
Date: Wed Jan 27 09:51:56 2016
New Revision: 258935
URL: http://llvm.org/viewvc/llvm-project?rev=258935&view=rev
Log:
Adding back in a test that I inadvertently removed in r258862
Added:
cfe/trunk/test/SemaObjC/atomoic-property-synnthesis-rules.m
Added: cfe/trunk/test/SemaO
rnk added a subscriber: rnk.
rnk added a comment.
Hans knows all about dllexport now.
http://reviews.llvm.org/D16632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
Comment at: include/clang/AST/ASTConsumer.h:58-64
@@ -57,5 +57,9 @@
/// \brief This callback is invoked each time an inline method definition is
/// completed.
virtual void HandleInlineMethodDefinition(CXXMethodDecl *D) {}
+ /// \brief This
mclow.lists added inline comments.
Comment at: include/__config:847
@@ +846,3 @@
+}
+#define _LIBCPP_THROW(E, MSG) __libcxx_noexceptions_report(MSG)
+#else // !_LIBCPP_NO_EXCEPTIONS
I don't care for having to specify something twice. (E, MSG). Maybe
"stringify
sberg added inline comments.
Comment at: include/clang/AST/ASTConsumer.h:58-64
@@ -57,5 +57,9 @@
/// \brief This callback is invoked each time an inline method definition is
/// completed.
virtual void HandleInlineMethodDefinition(CXXMethodDecl *D) {}
+ /// \brief Th
rnk added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:1108-1110
@@ -1106,1 +1107,5 @@
+ case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229
+if (!getLangOpts().MicrosoftExt)
+ break;
+// fall through
// Type qualifiers
-
sberg added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:1107
@@ +1106,3 @@
+ // Microsoft compatibility
+ case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229
+if (!getLangOpts().MicrosoftExt)
majnemer wrote:
> What about __fas
majnemer added a subscriber: majnemer.
Comment at: lib/Parse/ParseDeclCXX.cpp:1107
@@ +1106,3 @@
+ // Microsoft compatibility
+ case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229
+if (!getLangOpts().MicrosoftExt)
What about __fastcall, e
ast accepted this revision.
ast added a comment.
This revision is now accepted and ready to land.
thanks
http://reviews.llvm.org/D16591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
rjmccall added a comment.
I think it's not unlikely that float128_t will see future standardization (as
an optional extension, of course), and it would be strange for an operation
between two types to not consistently yield the type of higher rank.
I could see an argument that we should not tre
rnk added inline comments.
Comment at: include/clang/AST/ASTConsumer.h:58-64
@@ -57,5 +57,9 @@
/// \brief This callback is invoked each time an inline method definition is
/// completed.
virtual void HandleInlineMethodDefinition(CXXMethodDecl *D) {}
+ /// \brief This
rjmccall added a comment.
Seems reasonable.
http://reviews.llvm.org/D16607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:1107
@@ +1106,3 @@
+ // Microsoft compatibility
+ case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229
+if (!getLangOpts().MicrosoftExt)
sberg wrote:
> majnemer wrote:
Author: olista01
Date: Wed Jan 27 11:30:28 2016
New Revision: 258950
URL: http://llvm.org/viewvc/llvm-project?rev=258950&view=rev
Log:
Add backend dignostic printer for unsupported features
The related LLVM patch adds a backend diagnostic type for reporting
unsupported features, this adds a print
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258950: Add backend dignostic printer for unsupported
features (authored by olista01).
Changed prior to commit:
http://reviews.llvm.org/D16591?vs=46127&id=46144#toc
Repository:
rL LLVM
http://review
hans added a comment.
Hi Stephan,
I would rather see that we could get this right in the AST.
The problem is that the Befriended::func() definition doesn't have dllexport
attached:
`-CXXMethodDecl 0x5ba1cf0 parent 0x5b4f288 prev 0x5b4f750
col:18 used func 'void (void)'
`-CompoundStmt 0
rmaprath added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:1761
@@ +1760,3 @@
+Ptr = Address(AdjustAAPCSBitfieldAccess(Dst, Info, false),
+ getContext().getTypeAlignInChars(Dst.getType()));
+
rjmccall wrote:
> This alignment computatio
On Wed, Jan 27, 2016 at 3:37 AM, Alexander Kornienko via cfe-commits
wrote:
> Author: alexfh
> Date: Wed Jan 27 05:37:08 2016
> New Revision: 258924
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258924&view=rev
> Log:
> Add clang-tools-extra documentation to the CMake build.
Merged to 3.8 in r
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
In addition to math functions, we also need to support std::malloc and
std::free to match NVCC behavior.
http://reviews.llvm.org/D16638
Files:
lib/Headers/__clang_cuda_cmath.h
lib/Headers/__clang_c
On Wed, Jan 27, 2016 at 3:37 AM, Alexander Kornienko via cfe-commits
wrote:
> Author: alexfh
> Date: Wed Jan 27 05:37:19 2016
> New Revision: 258926
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258926&view=rev
> Log:
> [clang-tidy] Fix documentation.
>
> Fixed broken links to cppcoreguidelines
Author: hans
Date: Wed Jan 27 12:29:16 2016
New Revision: 258960
URL: http://llvm.org/viewvc/llvm-project?rev=258960&view=rev
Log:
docs/conf.py: update copyright year
Modified:
clang-tools-extra/trunk/docs/conf.py
Modified: clang-tools-extra/trunk/docs/conf.py
URL:
http://llvm.org/viewvc/ll
Author: rjmccall
Date: Wed Jan 27 12:32:30 2016
New Revision: 258962
URL: http://llvm.org/viewvc/llvm-project?rev=258962&view=rev
Log:
Emit calls to objc_unsafeClaimAutoreleasedReturnValue when
reclaiming a call result in order to ignore it or assign it
to an __unsafe_unretained variable. This av
bcraig created this revision.
bcraig added reviewers: mclow.lists, ed, jfb, EricWF, jroelofs.
bcraig added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer, jfb.
Operating systems that are not unix-like are unlikely to have access to
catopen. Instead of black-
bcraig added a comment.
Added cfe-commits to subscriber list.
http://reviews.llvm.org/D16634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hubert.reinterpretcast added a comment.
In http://reviews.llvm.org/D15120#337384, @rjmccall wrote:
> I think it's not unlikely that float128_t will see future standardization (as
> an optional extension, of course), and it would be strange for an operation
> between two types to not consistentl
Sean: Adding a new CC1 option ProfileClangInstr will make things
cleaner. But this won't solve the problem. The root of all the mess is
there is no driver level option for IR instrumentation. I need to
either "hijack" the -Xclang option, or move the logic to
CompilerInvocation.cpp, which both you d
jlebar accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Headers/__clang_cuda_cmath.h:222
@@ +221,3 @@
+__DEVICE__ void free(void *__ptr) { return ::free(__ptr); }
+__DEVICE__ void *malloc(size_t __size) { return ::malloc(__size); }
+
---
xur added a comment.
Sean: Adding a new CC1 option ProfileClangInstr will make things
cleaner. But this won't solve the problem. The root of all the mess is
there is no driver level option for IR instrumentation. I need to
either "hijack" the -Xclang option, or move the logic to
CompilerInvocation
davidxl added inline comments.
Comment at: lib/Driver/Tools.cpp:5520
@@ +5519,3 @@
+A->claim();
+if ((StringRef(A->getValue(0)) == "-fprofile-ir-instr") &&
+(Args.hasArg(options::OPT_fprofile_instr_generate) ||
silvas wrote:
> This is definitely no
Author: tnorthover
Date: Wed Jan 27 13:32:40 2016
New Revision: 258976
URL: http://llvm.org/viewvc/llvm-project?rev=258976&view=rev
Log:
ARMv7k: select ABI based on v7k Arch rather than watchos OS.
Various bits we'd like to use the new ABI actually compile with "-arch armv7k
-miphoneos-version-mi
On Wed, Jan 27, 2016 at 11:31 AM, David Li wrote:
> davidxl added inline comments.
>
>
> Comment at: lib/Driver/Tools.cpp:5520
> @@ +5519,3 @@
> +A->claim();
> +if ((StringRef(A->getValue(0)) == "-fprofile-ir-instr") &&
> +(Args.hasArg(options::OPT_fprofile_instr_g
hubert.reinterpretcast added a comment.
In http://reviews.llvm.org/D15120#337384, @rjmccall wrote:
> I think it's not unlikely that float128_t will see future standardization (as
> an optional extension, of course), and it would be strange for an operation
> between two types to not consistentl
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D16310#335844, @danielmarjamaki wrote:
> There were some new interesting warnings and imho they were TP.
TP?
http://reviews.llvm.org/D16310
___
cfe-commits mailing list
cfe-commits@lis
LegalizeAdulthood added a subscriber: LegalizeAdulthood.
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D16012#337208, @rsmith wrote:
> What's the benefit of storing this? You can get the same effect by
> re-lexing. We don't guarantee that the pretty printed version of the AST
>
Author: mren
Date: Wed Jan 27 14:00:32 2016
New Revision: 258979
URL: http://llvm.org/viewvc/llvm-project?rev=258979&view=rev
Log:
Class Property: handle class properties.
At places where we handle instance properties, if necessary.
rdar://23891898
Modified:
cfe/trunk/lib/AST/DeclObjC.cpp
LegalizeAdulthood added inline comments.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:27
@@ +26,3 @@
+ // we only transform ASCII string literals
+ if (!Literal->isAscii())
+return false;
alexfh wrote:
> Why can't the check convert non-ascii st
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:57
@@ +56,3 @@
+
+ // already a raw string literal if R comes before "
+ if (Text.find_first_of("R") < Text.find_first_of(R"(")"))
LegalizeAdulthood wrote:
> alexfh w
LegalizeAdulthood added inline comments.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:107
@@ +106,3 @@
+ if (const auto *Literal = Result.Nodes.getNodeAs("lit"))
+preferRawStringLiterals(Result, Literal);
+}
alexfh wrote:
> I don't see a reason
Author: mren
Date: Wed Jan 27 14:10:32 2016
New Revision: 258980
URL: http://llvm.org/viewvc/llvm-project?rev=258980&view=rev
Log:
Class Property: create accessors (class methods) for class property.
Change a few places where we assume property accessors can only be instance
methods.
rdar://2389
Author: djasper
Date: Wed Jan 27 14:14:23 2016
New Revision: 258981
URL: http://llvm.org/viewvc/llvm-project?rev=258981&view=rev
Log:
clang-format: [Java] Remove unnecessary line break after complex annotations
Before:
@Annotation("Some"
+ " text")
List
list;
After:
@Annotation
We first need to nail the use model of the option, and then talk about
implementation. To clarify, I think the following should be the way:
(assuming the current clang instrumetnation is the default):
1) To turn on clang based instrumentation:
-fprofile-instr-generate[=]
2) To turn on clang bas
ed added a comment.
I'm usually not a big fan of using definitions such as `__unix__`, because it
is pretty vague and defined inconsistently. That said, if you're going to use
this definition, then there is some good news: CloudABI doesn't define it,
meaning that you could just remove it from t
rjmccall added a comment.
In http://reviews.llvm.org/D15120#337552, @hubert.reinterpretcast wrote:
> In http://reviews.llvm.org/D15120#337384, @rjmccall wrote:
>
> > I think it's not unlikely that float128_t will see future standardization
> > (as an optional extension, of course), and it would
bcraig marked 2 inline comments as done.
bcraig added a comment.
http://reviews.llvm.org/D16634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tnorthover
Date: Wed Jan 27 16:14:02 2016
New Revision: 258994
URL: http://llvm.org/viewvc/llvm-project?rev=258994&view=rev
Log:
ARMv7k: simplify logic for deciding sjlj-exceptions.
Slight change of behaviour in the odd armv7+watchos case, which should match
the other runtime components.
echristo added a comment.
Hi Joel,
Since you're likely going to need to start filling in the Options there anyhow,
can you lift the one from the TODO and start filling it in?
-eric
http://reviews.llvm.org/D16538
___
cfe-commits mailing list
cfe-c
Author: eugenis
Date: Wed Jan 27 16:28:56 2016
New Revision: 258997
URL: http://llvm.org/viewvc/llvm-project?rev=258997&view=rev
Log:
Strengthen cfi-check-fail test.
r258993 allows stricter testing for basic block labels by making
sure that they are always followed by ":". Use this to improve the
EricWF added a comment.
I'm OK signing off on this myself.
http://reviews.llvm.org/D16584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dblaikie added a comment.
Fair question on overloaded operators... Taking the original code:
1: int main() {
2: if (
3: tr()
4: &&
5: tr()
6: )
7: func();
8: if (
9: fa()
10: &&
11: tr()
12: )
13: func();
14: }
& making tr/fa return a user defined type with a
kromanova added a comment.
In http://reviews.llvm.org/D15999#335653, @echristo wrote:
> Honestly if they've been reviewed like that internally I'm ok with you just
> committing them - especially if they look like this.
>
> The only concerns I'd have are in the case of "This intrinsic corresponds
kromanova added a comment.
In http://reviews.llvm.org/D15999#335653, @echristo wrote:
> Honestly if they've been reviewed like that internally I'm ok with you just
> committing them - especially if they look like this.
>
> The only concerns I'd have are in the case of "This intrinsic corresponds
EricWF added a comment.
- Please add the header to `test/libcxx/double_include.sh.cpp`
- Please add a `_LIBCPP_VERSION` test in `test/libcxx/experimental/iterator`
- The `ostream_joiner` type and it's members should be given visibility
attributes.
Comment at: include/experiment
EricWF added inline comments.
Comment at: include/experimental/iterator:85
@@ +84,3 @@
+template
+ostream_joiner& operator=(const _Tp& __v)
+{
EricWF wrote:
> People are going to try and use this as an assignment operator. We either
> need to static a
Author: aizatsky
Date: Wed Jan 27 17:56:12 2016
New Revision: 259000
URL: http://llvm.org/viewvc/llvm-project?rev=259000&view=rev
Log:
[sancov] sancov tool documentation
Differential Revision: http://reviews.llvm.org/D16432
Modified:
cfe/trunk/docs/SanitizerCoverage.rst
Modified: cfe/trunk/
EricWF added a comment.
ping.
http://reviews.llvm.org/D13420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xur updated this revision to Diff 46199.
xur added a comment.
This new version implemented the usage model David proposed. We now have a cc1
option -fprofile-instrumentor={llvm | clang} to choose which instrumentation to
use. The slight difference from David's proposal is that we can use this op
davidxl added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.def:106
@@ -105,3 +105,3 @@
-CODEGENOPT(ProfileInstrGenerate , 1, 0) ///< Instrument code to generate
-///< execution counts to use with PGO.
+CODEGENOPT(Prof
silvas added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:483
@@ +482,3 @@
+Opts.ProfileIRInstr = true;
+ else
+// Opts.ClangProfInstrGen will be used for Clang instrumentation only.
davidxl wrote:
> silvas wrote:
> > This still isn't
silvas added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.def:106
@@ -105,3 +105,3 @@
-CODEGENOPT(ProfileInstrGenerate , 1, 0) ///< Instrument code to generate
-///< execution counts to use with PGO.
+CODEGENOPT(Profi
mclow.lists added inline comments.
Comment at: include/experimental/iterator:62
@@ +61,3 @@
+
+_LIBCPP_BEGIN_NAMESPACE_LFTS
+
EricWF wrote:
> Wrong namespace. This gives `std::experimental::fundamentals_v2`. This brings
> up the bigger question of how we want to
mclow.lists updated this revision to Diff 46203.
mclow.lists added a comment.
Addressed Eric's comments. (at least some of them)
http://reviews.llvm.org/D16605
Files:
test/std/experimental/iterator/nothing_to_do.pass.cpp
test/std/experimental/iterator/ostream.joiner/ostream.joiner.cons/ost
mclow.lists marked 4 inline comments as done.
mclow.lists added a comment.
http://reviews.llvm.org/D16605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
One last thing. The spec implicitly defines the copy/move/assignment operators
for "ostream_joiner" by making "_Delim" an exposition only member. Essentially
"ostream_joiner" should only copy/moveable if "_Delim" is. I think we should
add tests that ensure we actually fo
Author: gbiv
Date: Wed Jan 27 19:38:18 2016
New Revision: 259011
URL: http://llvm.org/viewvc/llvm-project?rev=259011&view=rev
Log:
[Sema] Make extended vectors of `bool` an error.
In OpenCL, `bool` vectors are a reserved type, and are therefore
illegal.
Outside of OpenCL, if we try to make an ex
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259011: [Sema] Make extended vectors of `bool` an error.
(authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D15721?vs=46088&id=46205#toc
Repository:
rL LLVM
http://reviews.llvm.org
alexfh added inline comments.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:27
@@ +26,3 @@
+ // we only transform ASCII string literals
+ if (!Literal->isAscii())
+return false;
LegalizeAdulthood wrote:
> alexfh wrote:
> > Why can't the check co
Thanks!
On Wed, Jan 27, 2016 at 7:30 PM, Hans Wennborg wrote:
> On Wed, Jan 27, 2016 at 3:37 AM, Alexander Kornienko via cfe-commits
> wrote:
> > Author: alexfh
> > Date: Wed Jan 27 05:37:19 2016
> > New Revision: 258926
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=258926&view=rev
> > L
1 - 100 of 118 matches
Mail list logo
