[PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

2016-01-25 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: bkramer, echristo, jhen, cfe-commits. Turns out the variadic function checking added in r258643 was too strict for some existing users; give them an escape valve. When -fcuda-allow-variadic-functions is passed,

r258734 - [CUDA] Don't generate aliases for static extern "C" functions.

2016-01-25 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Jan 25 16:36:37 2016 New Revision: 258734 URL: http://llvm.org/viewvc/llvm-project?rev=258734&view=rev Log: [CUDA] Don't generate aliases for static extern "C" functions. Summary: These aliases are done to support inline asm, but there's nothing we can do: NVPTX doesn't s

Re: [PATCH] D16501: [CUDA] Don't generate aliases for static extern "C" functions.

2016-01-25 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258734: [CUDA] Don't generate aliases for static extern "C" functions. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16501?vs=45781&id=45919#toc Repository: rL LLVM http://

Re: [PATCH] D16499: [CUDA] Disable ctor/dtor aliases in device code.

2016-01-25 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258733: [CUDA] Disable ctor/dtor aliases in device code. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16499?vs=45779&id=45918#toc Repository: rL LLVM http://reviews.llvm.o

r258733 - [CUDA] Disable ctor/dtor aliases in device code.

2016-01-25 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Jan 25 16:36:35 2016 New Revision: 258733 URL: http://llvm.org/viewvc/llvm-project?rev=258733&view=rev Log: [CUDA] Disable ctor/dtor aliases in device code. Summary: NVPTX doesn't support aliases, so don't generate them. Reviewers: tra Subscribers: cfe-commits, jhen, ec

r258735 - Update comments to match the implementation.

2016-01-25 Thread Manman Ren via cfe-commits
Author: mren Date: Mon Jan 25 16:37:47 2016 New Revision: 258735 URL: http://llvm.org/viewvc/llvm-project?rev=258735&view=rev Log: Update comments to match the implementation. Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp URL: http://llvm.org/vi

Re: [PATCH] D15699: [cfi] Cross-DSO CFI diagnostic mode (clang part)

2016-01-25 Thread Evgeniy Stepanov via cfe-commits
eugenis updated this revision to Diff 45920. Repository: rL LLVM http://reviews.llvm.org/D15699 Files: lib/CodeGen/CGClass.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.cpp lib/Driver/Tools.cpp test/CodeGen/cfi-check-fail.c test/CodeGen/cfi-ic

Re: [PATCH] D15699: [cfi] Cross-DSO CFI diagnostic mode (clang part)

2016-01-25 Thread Evgeniy Stepanov via cfe-commits
eugenis added inline comments. Comment at: test/CodeGen/cfi-check-fail.c:18 @@ +17,3 @@ +// CHECK: [[TRAP]] +// CHECK-NEXT: call void @llvm.trap() +// CHECK-NEXT: unreachable Right. It fails. I've removed the ":" after all label names. Repository: rL LLVM

r258737 - [CUDA] Add -target to cuda-constructor-alias.cu test so it doesn't fail on Mac.

2016-01-25 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Jan 25 16:52:31 2016 New Revision: 258737 URL: http://llvm.org/viewvc/llvm-project?rev=258737&view=rev Log: [CUDA] Add -target to cuda-constructor-alias.cu test so it doesn't fail on Mac. The test was checking that we passed -mconstructor-alias to host compilation, but th

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

2016-01-25 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. Maybe we can just remove -Wpadded from buildit's command line for now? If we decide in the future it's worthwhile to use -Wpadded, we can put it back and commit this patch. Also in that case we should make sure cmake uses the option too. http://reviews.llvm.org/D1589

r258745 - [cfi] Cross-DSO CFI diagnostic mode (clang part)

2016-01-25 Thread Evgeniy Stepanov via cfe-commits
Author: eugenis Date: Mon Jan 25 17:34:52 2016 New Revision: 258745 URL: http://llvm.org/viewvc/llvm-project?rev=258745&view=rev Log: [cfi] Cross-DSO CFI diagnostic mode (clang part) * Runtime diagnostic data for cfi-icall changed to match the rest of cfi checks * Layout of all CFI diagnostic d

Re: [PATCH] D15699: [cfi] Cross-DSO CFI diagnostic mode (clang part)

2016-01-25 Thread Evgeniy Stepanov via cfe-commits
eugenis closed this revision. eugenis added a comment. Thanks! Committed as http://reviews.llvm.org/rL258745 Repository: rL LLVM http://reviews.llvm.org/D15699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

r258749 - Fix use of constexpr std::pair that's not in C++11.

2016-01-25 Thread Evgeniy Stepanov via cfe-commits
Author: eugenis Date: Mon Jan 25 17:45:37 2016 New Revision: 258749 URL: http://llvm.org/viewvc/llvm-project?rev=258749&view=rev Log: Fix use of constexpr std::pair that's not in C++11. Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp URL: http://llvm.or

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-25 Thread Renato Golin via cfe-commits
On 25 January 2016 at 21:14, Ehsan Akhgari via cfe-commits wrote: > Author: ehsan > Date: Mon Jan 25 15:14:52 2016 > New Revision: 258720 > > URL: http://llvm.org/viewvc/llvm-project?rev=258720&view=rev > Log: > [MSVC Compat] Only warn for unknown clang-cl arguments Hi Eshan, Not sure you've see

[PATCH] D16562: Adding doxygen comments to the LLVM intrinsics (part 3, __wmmintrin_aes.h)

2016-01-25 Thread Katya Romanova via cfe-commits
kromanova created this revision. kromanova added reviewers: gribozavr, jroelofs, gaoyunzhong, craig.topper. kromanova added subscribers: silvas, echristo, cfe-commits. kromanova set the repository for this revision to rL LLVM. Hello, Here is the patch with the doxygen comments for the intrinsincs

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

2016-01-25 Thread Rong Xu via cfe-commits
xur updated this revision to Diff 45929. xur marked an inline comment as done. xur added a comment. Here is the new patch. Changes from previous patch are: (1) rename codegen option ProfileInstrGenerate to ClangProfInstrGen to avoid the name confusion (Davidxl). This option is for clang instrumen

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-25 Thread George Burgess IV via cfe-commits
george.burgess.iv updated this revision to Diff 45930. george.burgess.iv marked an inline comment as done. george.burgess.iv added a comment. - Added diagnostics that prohibit vectors of booleans in OpenCL - Added tests for extended vectors of bools in C (previously existed only in C++) - Clarifi

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-25 Thread George Burgess IV via cfe-commits
george.burgess.iv added a comment. > I am generally not clear about the scope of this patch. Is it intended for > OpenCL or C++? Sorry for the lack of clarity; I was mildly confused about what parts of the OpenCL spec apply to extended vectors when compiling code as C/C++. I think I have a be

[PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

2016-01-25 Thread Manman Ren via cfe-commits
manmanren created this revision. manmanren added reviewers: echristo, rafael, ahatanak. manmanren added a subscriber: cfe-commits. It can happen that frontend emits error message when releasing the builder. When that happens, we emit the error message and continue to invoke backend. Backend will

Re: [PATCH] D16365: Do not define GXX_RTTI macro for C

2016-01-25 Thread Yunzhong Gao via cfe-commits
ygao added a comment. A gentle ping. http://reviews.llvm.org/D16365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-25 Thread Ehsan Akhgari via cfe-commits
Ouch, sorry about that! I'm afk right now, I would appreciate if you can revert it for me. I will look at fixing this tomorrow. On Jan 25, 2016 6:49 PM, "Renato Golin" wrote: > On 25 January 2016 at 21:14, Ehsan Akhgari via cfe-commits > wrote: > > Author: ehsan > > Date: Mon Jan 25 15:14:52 201

r258762 - [MS Compat] Don't crash if __GetExceptionInfo is in global scope

2016-01-25 Thread David Majnemer via cfe-commits
Author: majnemer Date: Mon Jan 25 19:12:17 2016 New Revision: 258762 URL: http://llvm.org/viewvc/llvm-project?rev=258762&view=rev Log: [MS Compat] Don't crash if __GetExceptionInfo is in global scope __GetExceptionInfo triggered Sema::LazilyCreateBuiltin which tries to create a non-templated func

Re: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

2016-01-25 Thread Katya Romanova via cfe-commits
kromanova added a reviewer: craig.topper. kromanova added a comment. Hello, I have a lot of intrinsic header files with doxygen documentation that I will be submitting in the near future. We have been reviewing this internally at SCE to make sure the patch it in the best shape before submitting

r258768 - [Sema] Incomplete types are OK for covariant returns

2016-01-25 Thread David Majnemer via cfe-commits
Author: majnemer Date: Mon Jan 25 19:37:01 2016 New Revision: 258768 URL: http://llvm.org/viewvc/llvm-project?rev=258768&view=rev Log: [Sema] Incomplete types are OK for covariant returns Per C++14 [class.virtual]p8, it is OK for the return type's class type to be incomplete so long as the return

r258769 - [Sema] Remove stray semicolons.

2016-01-25 Thread David Majnemer via cfe-commits
Author: majnemer Date: Mon Jan 25 19:39:17 2016 New Revision: 258769 URL: http://llvm.org/viewvc/llvm-project?rev=258769&view=rev Log: [Sema] Remove stray semicolons. No functional change is intended. Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp

r258772 - Revert the test for r258720 temporarily

2016-01-25 Thread Ehsan Akhgari via cfe-commits
Author: ehsan Date: Mon Jan 25 19:51:47 2016 New Revision: 258772 URL: http://llvm.org/viewvc/llvm-project?rev=258772&view=rev Log: Revert the test for r258720 temporarily This test is failing on a bot for reasons that are unclear to me. Reverting for now... Modified: cfe/trunk/test/Driver/u

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-25 Thread Ehsan Akhgari via cfe-commits
OK, I reverted the test in r258772. Looking at the log, it's really not clear to me what's going on. I'd appreciate your help figuring this out. :-) On Mon, Jan 25, 2016 at 8:09 PM, Ehsan Akhgari wrote: > Ouch, sorry about that! I'm afk right now, I would appreciate if you can > revert it for

Re: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

2016-01-25 Thread Eric Christopher via cfe-commits
echristo added a comment. Honestly if they've been reviewed like that internally I'm ok with you just committing them - especially if they look like this. The only concerns I'd have are in the case of "This intrinsic corresponds to the instruction" (side note, use the "the"? I commented on a c

r258773 - [OpenCL] Pipe builtin functions

2016-01-25 Thread Xiuli Pan via cfe-commits
Author: pxl Date: Mon Jan 25 20:06:04 2016 New Revision: 258773 URL: http://llvm.org/viewvc/llvm-project?rev=258773&view=rev Log: [OpenCL] Pipe builtin functions Summary: Support for the pipe built-in functions for OpenCL 2.0. The pipe builtin functions may have infinite kinds of element types, o

Re: r258772 - Revert the test for r258720 temporarily

2016-01-25 Thread Nico Weber via cfe-commits
Since it isn't a -### test, the test probably just needs a `// REQUIRES: x86-registered-target`? Is adding -### a possibility? On Mon, Jan 25, 2016 at 8:51 PM, Ehsan Akhgari via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ehsan > Date: Mon Jan 25 19:51:47 2016 > New Revision: 25877

[PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

2016-01-25 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

r258775 - Revert "[OpenCL] Pipe builtin functions"

2016-01-25 Thread David Majnemer via cfe-commits
Author: majnemer Date: Mon Jan 25 20:22:31 2016 New Revision: 258775 URL: http://llvm.org/viewvc/llvm-project?rev=258775&view=rev Log: Revert "[OpenCL] Pipe builtin functions" This reverts commit r258773, it broke the build bots: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/43853 Re

r258776 - Recommit the test for r258720 using -###

2016-01-25 Thread Ehsan Akhgari via cfe-commits
Author: ehsan Date: Mon Jan 25 20:23:05 2016 New Revision: 258776 URL: http://llvm.org/viewvc/llvm-project?rev=258776&view=rev Log: Recommit the test for r258720 using -### Modified: cfe/trunk/test/Driver/unknown-arg.c Modified: cfe/trunk/test/Driver/unknown-arg.c URL: http://llvm.org/viewv

Re: r258773 - [OpenCL] Pipe builtin functions

2016-01-25 Thread David Majnemer via cfe-commits
Reverted in r258775, it broke the build bots: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/43853 On Mon, Jan 25, 2016 at 6:06 PM, Xiuli Pan via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: pxl > Date: Mon Jan 25 20:06:04 2016 > New Revision: 258773 > > URL: http://llvm.

Re: r258772 - Revert the test for r258720 temporarily

2016-01-25 Thread Ehsan Akhgari via cfe-commits
Thanks for the suggestion! I converted the test to a -### test and recommitted. Also rewrote the existing test (which I guess was failing for another reason than what the author intended since it was merely checking for an error return code...) On Mon, Jan 25, 2016 at 9:16 PM, Nico Weber wrote:

RE: r258773 - [OpenCL] Pipe builtin functions

2016-01-25 Thread xiuli pan via cfe-commits
Sorry about this broken commit. The arc tool patch fuzz seems to have something wrong and I am re-patching it by hand. From: David Majnemer [mailto:david.majne...@gmail.com] Sent: Tuesday, January 26, 2016 10:27 AM To: Xiuli Pan Cc: cfe-commits Subject: Re: r258773 - [OpenCL] Pipe builtin f

[PATCH] D16567: [Clang] Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes

2016-01-25 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. I checked this patch on my own build on RHEL 6. Regressions

r258778 - Fix -Wnull-conversion for long macros.

2016-01-25 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Mon Jan 25 20:51:55 2016 New Revision: 258778 URL: http://llvm.org/viewvc/llvm-project?rev=258778&view=rev Log: Fix -Wnull-conversion for long macros. Move the function to get a macro name from DiagnosticRenderer.cpp to Lexer.cpp so that other files can use it. Lexer now has

LLVM buildmaster will be restarted tonight

2016-01-25 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 9 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16498: AMDGPU: Add amdgcn cube builtins

2016-01-25 Thread Tom Stellard via cfe-commits
tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

2016-01-25 Thread Xiuli Pan via cfe-commits
Author: pxl Date: Mon Jan 25 22:03:48 2016 New Revision: 258782 URL: http://llvm.org/viewvc/llvm-project?rev=258782&view=rev Log: Recommit: R258773 [OpenCL] Pipe builtin functions Fix arc patch fuzz error. Summary: Support for the pipe built-in functions for OpenCL 2.0. The pipe builtin functions

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

2016-01-25 Thread Xiuli PAN via cfe-commits
pxli168 added a comment. Hi, Email was sent, hope this can be merged into llvm release3.8. Thanks Xiuli http://reviews.llvm.org/D15914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

2016-01-25 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D16553: [OpenMP] Parsing + sema for target parallel directive.

2016-01-25 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r258794 - AMDGPU: Add amdgcn cube builtins

2016-01-25 Thread Matt Arsenault via cfe-commits
Author: arsenm Date: Tue Jan 26 00:37:54 2016 New Revision: 258794 URL: http://llvm.org/viewvc/llvm-project?rev=258794&view=rev Log: AMDGPU: Add amdgcn cube builtins Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn.cl Modified: cfe/t

<    1   2