Thanks for the suggestion! I converted the test to a -### test and recommitted. Also rewrote the existing test (which I guess was failing for another reason than what the author intended since it was merely checking for an error return code...)
On Mon, Jan 25, 2016 at 9:16 PM, Nico Weber <tha...@chromium.org> wrote: > Since it isn't a -### test, the test probably just needs a `// REQUIRES: > x86-registered-target`? Is adding -### a possibility? > > On Mon, Jan 25, 2016 at 8:51 PM, Ehsan Akhgari via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ehsan >> Date: Mon Jan 25 19:51:47 2016 >> New Revision: 258772 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=258772&view=rev >> Log: >> Revert the test for r258720 temporarily >> >> This test is failing on a bot for reasons that are unclear to me. >> Reverting for now... >> >> Modified: >> cfe/trunk/test/Driver/unknown-arg.c >> >> Modified: cfe/trunk/test/Driver/unknown-arg.c >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/unknown-arg.c?rev=258772&r1=258771&r2=258772&view=diff >> >> ============================================================================== >> --- cfe/trunk/test/Driver/unknown-arg.c (original) >> +++ cfe/trunk/test/Driver/unknown-arg.c Mon Jan 25 19:51:47 2016 >> @@ -1,11 +1,5 @@ >> // RUN: not %clang %s -cake-is-lie -%0 -%d -HHHH >> -munknown-to-clang-option -print-stats -funknown-to-clang-option 2>&1 | \ >> // RUN: FileCheck %s >> -// RUN: %clang_cl -cake-is-lie -%0 -%d -HHHH -munknown-to-clang-option >> -print-stats -funknown-to-clang-option -c -- %s 2>&1 | \ >> -// RUN: FileCheck %s --check-prefix=CL >> -// RUN: not %clang_cl -cake-is-lie -%0 -%d -HHHH >> -munknown-to-clang-option -print-stats -funknown-to-clang-option -c >> -Werror=unknown-argument -- %s 2>&1 | \ >> -// RUN: FileCheck %s --check-prefix=CL >> -// RUN: %clang_cl -cake-is-lie -%0 -%d -HHHH -munknown-to-clang-option >> -print-stats -funknown-to-clang-option -c -Wno-unknown-argument -- %s 2>&1 >> | \ >> -// RUN: FileCheck %s --check-prefix=SILENT --allow-empty >> >> // CHECK: unknown argument: '-cake-is-lie' >> // CHECK: unknown argument: '-%0' >> @@ -14,15 +8,6 @@ >> // CHECK: unknown argument: '-munknown-to-clang-option' >> // CHECK: unknown argument: '-print-stats' >> // CHECK: unknown argument: '-funknown-to-clang-option' >> -// CL: unknown argument ignored in clang-cl: '-cake-is-lie' >> -// CL: unknown argument ignored in clang-cl: '-%0' >> -// CL: unknown argument ignored in clang-cl: '-%d' >> -// CL: unknown argument ignored in clang-cl: '-HHHH' >> -// CL: unknown argument ignored in clang-cl: '-munknown-to-clang-option' >> -// CL: unknown argument ignored in clang-cl: '-print-stats' >> -// CL: unknown argument ignored in clang-cl: '-funknown-to-clang-option' >> -// SILENT-NOT: error >> -// SILENT-NOT: warning >> >> >> // RUN: %clang -S %s -o %t.s -Wunknown-to-clang-option 2>&1 | FileCheck >> --check-prefix=IGNORED %s >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> > > -- Ehsan
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
