Author: danielmarjamaki
Date: Mon Jan 25 03:29:38 2016
New Revision: 258673
URL: http://llvm.org/viewvc/llvm-project?rev=258673&view=rev
Log:
[Sema] Improve constness
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
Modified: cfe/trunk/lib/Sema/SemaChecking.cpp
URL:
http://llvm.org/viewvc/llvm
olista01 added a comment.
Ping?
http://reviews.llvm.org/D15040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258679: Fix printing of types in initializers with
suppressed tags. (authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D16438?vs=45658&id=45849#toc
Repository:
rL LLVM
http://review
Author: d0k
Date: Mon Jan 25 04:34:06 2016
New Revision: 258679
URL: http://llvm.org/viewvc/llvm-project?rev=258679&view=rev
Log:
Fix printing of types in initializers with suppressed tags.
Tag and specifier printing can be suppressed in Decl::printGroup, but these
suppressions leak into the ini
danielmarjamaki marked 3 inline comments as done.
Comment at: docs/clang-tidy/checks/misc-long-cast.rst:11
@@ +10,3 @@
+
+Example code::
+
alexfh wrote:
> LegalizeAdulthood wrote:
> > Please add an example for another type other than `long`, such as casting a
> >
hokein updated this revision to Diff 45852.
hokein added a comment.
Change delimeter from "," to ";".
http://reviews.llvm.org/D16113
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/google/GlobalNamesInHeadersCheck.cpp
clang-tidy/google/GlobalNamesInHeadersCheck.h
cla
LegalizeAdulthood created this revision.
LegalizeAdulthood added a reviewer: alexfh.
LegalizeAdulthood added a subscriber: cfe-commits.
This check examines string literals and looks for those that could be more
directly expressed as a raw string literal.
Example:
```
char const *const BackSlash
pekka.jaaskelainen accepted this revision.
pekka.jaaskelainen added a comment.
LGTM too. Good job. You can try and ask the release manager if you can sneak it
in. It's rather container patch so there might be a chance, but I don't know
the policy at this stage of the release.
http://reviews.ll
arpith-jacob updated this revision to Diff 45856.
arpith-jacob added a comment.
Addressed fixes by Alexey Bataev. Thanks.
http://reviews.llvm.org/D16527
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/OpenMPKinds.def
include/clang/Bas
aaron.ballman added a comment.
In http://reviews.llvm.org/D16526#334795, @LegalizeAdulthood wrote:
> In http://reviews.llvm.org/D16526#334742, @aaron.ballman wrote:
>
> > I get the same behavior from the existing has() matcher -- how is this
> > meant to differ?
>
>
> Hmm! Good question. I sup
bcraig abandoned this revision.
bcraig added a comment.
Looks like I found an out-of-tree warning in our compiler. Sorry about the
noise. Abandoning.
http://reviews.llvm.org/D16480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
ygribov added a subscriber: ygribov.
Comment at: test/Driver/fsanitize.c:221
@@ +220,3 @@
+// RUN: %clang -target x86_64-apple-darwin10
-resource-dir=%S/Inputs/resource_dir -fsanitize=memory -fsanitize=thread,memory
%s -### 2>&1 | FileCheck %s --check-prefix=CHECK-MSAN-TSAN-MSAN
danielmarjamaki added inline comments.
Comment at: clang-tidy/misc/LongCastCheck.cpp:97
@@ +96,3 @@
+
+ if (!CastType->isIntegerType() || !SubType->isIntegerType())
+return;
LegalizeAdulthood wrote:
> danielmarjamaki wrote:
> > LegalizeAdulthood wrote:
> > >
danielmarjamaki marked 5 inline comments as done.
danielmarjamaki added a comment.
http://reviews.llvm.org/D16310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:192
@@ +191,3 @@
+ const Expr *E, bool Negated) {
+ return compareExpressionToConstant(Result, E, Negated, "nullptr");
+}
Ca
danielmarjamaki removed rL LLVM as the repository for this revision.
danielmarjamaki updated this revision to Diff 45854.
danielmarjamaki added a comment.
Fixed review comments
http://reviews.llvm.org/D16310
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-ti
danielmarjamaki closed this revision.
danielmarjamaki added a comment.
Thanks! Committed with r258673
http://reviews.llvm.org/D11035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki marked 13 inline comments as done.
danielmarjamaki added a comment.
http://reviews.llvm.org/D16310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaboud marked an inline comment as done.
aaboud added a comment.
Thanks David for the feedback.
I have some answers below, please let me know if they are not sufficient or you
are still have concerns.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1479
@@ +1478,3 @@
+void CGDebugInfo:
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/RedundantControlFlowCheck.cpp:24
@@ +23,3 @@
+const char *const RedundantReturnDiag =
+"redundant return statement at the end of void function";
+const char *const RedundantContinueDiag =
ptitei created this revision.
ptitei added a reviewer: cfe-commits.
Implementation for C only warning -Wstrict-prototypes. Function declarations
which have no parameters specified are diagnosed and also K&R function
definitions with more than 0 parameters which are not preceded by previous
prot
aaron.ballman added a comment.
In http://reviews.llvm.org/D16286#333911, @LegalizeAdulthood wrote:
> As a general comment, I am continually fascinated by the **huge** variety of
> opinion as to matters of readability within the C++ community. I don't know
> why we have so many differing opinio
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for working on this!
http://reviews.llvm.org/D16113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
aaron.ballman added a subscriber: aaron.ballman.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:35
@@ +34,3 @@
+ const bool HasBackSlash = Text.find(R"(\\)") != StringRef::npos;
+ const bool HasNewLine = Text.find(R"(\n)") != StringRef::npos;
+ const bool HasQuote =
aaron.ballman added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:30
@@ +29,3 @@
+Class = Class.trim();
+if (!Class.empty())
+ Result.push_back(Class);
alexfh wrote:
> aaron.ballman wrote:
> > > Also changed the separat
mclow.lists added a comment.
I don't have any comments on this code at this time, but I want to caution
people that this part of the standard library is **extremely** carefully
specified, and meeting all the requirements is a fiddly bit of work.
For an example of this, look at LWG issue #2464,
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp:22
@@ +21,3 @@
+void UserDefinedCopyWithoutAssignmentCheck::registerMatchers(
+MatchFinder *Finder) {
+ Finder->addMatcher(
Before registering the match
rmaprath updated this revision to Diff 45868.
rmaprath added a comment.
Re-based on trunk. Trivial.
http://reviews.llvm.org/D14653
Files:
include/__config
include/array
test/std/containers/sequences/array/at.pass.cpp
test/support/noexcept.h
test/support/test_allocator.h
Index: test/s
kubabrecka added inline comments.
Comment at: test/Driver/fsanitize.c:221
@@ +220,3 @@
+// RUN: %clang -target x86_64-apple-darwin10
-resource-dir=%S/Inputs/resource_dir -fsanitize=memory -fsanitize=thread,memory
%s -### 2>&1 | FileCheck %s --check-prefix=CHECK-MSAN-TSAN-MSAN-DA
mclow.lists closed this revision.
mclow.lists added a comment.
This was landed as r257682
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun created this revision.
xazax.hun added a reviewer: alexfh.
xazax.hun added subscribers: dkrupp, cfe-commits.
This patch adds a checker to find semicolons that are probably unintended and
modify the semantics of the program. See the examples and the documentation for
more details.
http
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM with one addition, I still would like to see this test added and passing:
EXPECT_TRUE(matchesC("void f();", functionDecl(parameterCountIs(0;
Thank you for working on these!
http://reviews.llvm.org/D8149
mclow.lists added a comment.
Not crashing is good; but silently returning a "wrong" answer rubs me the wrong
way. I'll do some research and get back to you on this, but maybe throwing an
exception is a better response.
The code looks fine, though; I'm just not sure it's the right thing to do.
Thanks for working on this!
On Mon, Jan 25, 2016 at 03:18:31PM +, Paul Titei via cfe-commits wrote:
> +// function definition with 0 params(for both cases), valid according to
> 6.7.5.3/14
> +void foo1() {}
I still want to get a warning for this. At best it is inconsistent.
> +// Function d
congliu created this revision.
congliu added a reviewer: alexfh.
congliu added a subscriber: cfe-commits.
Fix the assertion failure for the user-defined conversion method. e.g.:
operator bool()
http://reviews.llvm.org/D16536
Files:
clang-tidy/misc/VirtualNearMissCheck.cpp
test/clang-tidy/mi
aaron.ballman added a subscriber: aaron.ballman.
Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:175
@@ +174,3 @@
+/// operator TypeName()
+static bool isUserDefinedConversion(const CXXMethodDecl *MD) {
+ return StringRef(MD->getNameAsString()).find(StringRef("operator "))
mclow.lists added inline comments.
Comment at: include/regex:5390
@@ -5389,3 +5389,3 @@
size_t __i = *__fmt_first - '0';
-__out = _VSTD::copy(__matches_[__i].first,
- __matches_[__i].second, __out);
+
mclow.lists added a comment.
This looks good to me.
Comment at: include/forward_list:369
@@ +368,3 @@
+}
+__node_pointer __get_node_unchecked() const {
+return static_cast<__node_pointer>(
I would think about calling this `__get_node_dereferencab
Thanks for the fast review.
> On Mon, Jan 25, 2016 at 03:18:31PM +, Paul Titei via cfe-commits wrote:
> > +// function definition with 0 params(for both cases), valid according
> > +to 6.7.5.3/14 void foo1() {}
> I still want to get a warning for this. At best it is inconsistent.
I agree this
congliu updated this revision to Diff 45873.
congliu added a comment.
- Address the comment and clean up the code.
http://reviews.llvm.org/D16536
Files:
clang-tidy/misc/VirtualNearMissCheck.cpp
test/clang-tidy/misc-virtual-near-miss.cpp
Index: test/clang-tidy/misc-virtual-near-miss.cpp
===
congliu added inline comments.
Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:175
@@ +174,3 @@
+/// operator TypeName()
+static bool isUserDefinedConversion(const CXXMethodDecl *MD) {
+ return StringRef(MD->getNameAsString()).find(StringRef("operator ")) !=
--
AndyG added a reviewer: rtrieu.
AndyG added a comment.
Richard, you have been recommended to me as a suitable reviewer by David. If
that's not ok with you, please could you recommend another! Thanks, Andy.
http://reviews.llvm.org/D15636
___
cfe-c
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D16536
___
cfe-commits mailing list
cfe-com
thakis added a subscriber: thakis.
thakis added a comment.
(This is http://llvm.org/PR20796, which has some discussion and test cases. If
you haven't, maybe you want to look at the test cases there. It's possible
they're a subset of your test though.)
http://reviews.llvm.org/D16533
mdaniels added a comment.
I dont have commit access, so if the change still looks good, and someone is
feeling generous.. :)
http://reviews.llvm.org/D16344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: marshall
Date: Mon Jan 25 11:29:55 2016
New Revision: 258697
URL: http://llvm.org/viewvc/llvm-project?rev=258697&view=rev
Log:
Implement LWG#2385; remove the allocator-aware std::function::assign call. It
was useless, and didn't actually *do anything* with the allocator. Now it's
gone.
ygribov added inline comments.
Comment at: test/Driver/fsanitize.c:221
@@ +220,3 @@
+// RUN: %clang -target x86_64-apple-darwin10
-resource-dir=%S/Inputs/resource_dir -fsanitize=memory -fsanitize=thread,memory
%s -### 2>&1 | FileCheck %s --check-prefix=CHECK-MSAN-TSAN-MSAN-DARWI
Anastasia added a comment.
I am generally not clear about the scope of this patch. Is it intended for
OpenCL or C++?
As for OpenCL, boolean vector types are not permitted (Table 6.2). Also
conversions between vector types are disallowed in general (Section 6.2.2) but
unfortunately Clang doesn'
Ping!
On Wed, Jan 20, 2016 at 11:22 AM, Bruno Cardoso Lopes
wrote:
> bruno updated this revision to Diff 45421.
> bruno added a comment.
>
> Update patch after Richard comments
>
>
> http://reviews.llvm.org/D15173
>
> Files:
> include/clang/Lex/Preprocessor.h
> lib/Lex/PPCaching.cpp
> lib/P
rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D16469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
rafael added a subscriber: rafael.
rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D16094
___
cfe-commits mailing list
cfe-commits@
Anastasia added a comment.
Could you please copy us in CC?
@Pekka, do you think it would make sense to include a description of the new
OpenCL features in the release note too? Or shall we wait for the completion of
OpenCL 2.0 support (hopefully in next release)? Could do both as well I guess.
hjl.tools added a comment.
Can you check it in for me? Thanks.
http://reviews.llvm.org/D16469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.
LGTM assuming you can get the test to fail by reverting the fix
http://reviews.llvm.org/D15705
___
cfe-commits m
> On 2016-Jan-25, at 08:49, Marshall Clow wrote:
>
> mclow.lists added inline comments.
>
>
> Comment at: include/regex:5390
> @@ -5389,3 +5389,3 @@
> size_t __i = *__fmt_first - '0';
> -__out = _VSTD::copy(__matches_[__i].first,
> -
Given your follow-up review, and the behaviour of
match_results::operator[], do you still have reservations?
> On 2016-Jan-25, at 08:19, Marshall Clow wrote:
>
> mclow.lists added a comment.
>
> Not crashing is good; but silently returning a "wrong" answer rubs me the
> wrong way. I'll do som
cfe-commits added a comment.
Given your follow-up review, and the behaviour of
match_results::operator[], do you still have reservations?
http://reviews.llvm.org/D16467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
dexonsmith created this revision.
dexonsmith added a reviewer: mclow.lists.
dexonsmith added a subscriber: cfe-commits.
This entire test was effectively disabled in r187636 with no relevant
explanation. The test passes for me just by removing the comment
markers.
http://reviews.llvm.org/D16541
dexonsmith updated this revision to Diff 45879.
dexonsmith added a comment.
Addressed Marshall's review comments: deferring to match_results::operator[]()
rather than duplicating the logic.
http://reviews.llvm.org/D16467
Files:
include/regex
test/std/re/re.results/re.results.form/form1.pas
Author: rafael
Date: Mon Jan 25 12:29:16 2016
New Revision: 258698
URL: http://llvm.org/viewvc/llvm-project?rev=258698&view=rev
Log:
Pass --wrap=pthread_create to linker for -fsplit-stack.
From
https://gcc.gnu.org/ml/gcc-patches/2010-09/msg01807.html
-fsplit-stack should pass --wrap=pthread_cre
rafael closed this revision.
rafael added a comment.
258698
http://reviews.llvm.org/D16469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pekka.jaaskelainen added a comment.
> @Pekka, do you think it would make sense to include a description of the new
> OpenCL features in the release note too? Or shall we wait for the completion
> of OpenCL 2.0 support (hopefully in next release)? Could do both as well I
> guess. :)
Yes I th
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm other than the warning group.
Comment at: test/Misc/warning-flags.c:21
@@ -20,3 +20,3 @@
-CHECK: Warnings without flags (84):
+CHECK: Warnings without flags (85):
CHECK-NEXT
On Fri, Jan 22, 2016 at 1:43 PM, Sean Silva wrote:
> silvas added a comment.
>
> In http://reviews.llvm.org/D15829#333902, @davidxl wrote:
>
>> For the longer term, one possible solution is to make FE based
>> instrumentation only used for coverage testing which can be turned on
>> with -fcovera
ygao added a comment.
Thanks, Rafael!
I did verify that the test would fail without my fix. But what do I need to do
to make buildbots turn on the new lit parameter?
http://reviews.llvm.org/D15705
___
cfe-commits mailing list
cfe-commits@lists.llvm
bcraig created this revision.
bcraig added reviewers: mclow.lists, EricWF, jroelofs.
bcraig added a subscriber: cfe-commits.
NOTE: related libc++abi changes are in a different patch that will be posted
shortly.
Tested with static libcxx and libcxxabi against custom embedded target.
Tested with st
bcraig created this revision.
bcraig added reviewers: mclow.lists, jroelofs, EricWF.
bcraig added a subscriber: cfe-commits.
This change leverages framework changes made in libcxx. See those changes for
more details. (http://reviews.llvm.org/D16544)
Some Mac specific logic for testing against l
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D16499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added a comment.
Failing silently is not a good idea. At the very least there should produce an
error.
The right thing to do here, IMO, would be to generate a stub with alias name
that just jumps to or calls aliasee.
http://reviews.llvm.org/D16501
___
hans added a subscriber: hans.
hans added a comment.
Maybe this behavior should be called out in the Command-Line Options section
under clang-cl in docs/UsersManual.rst?
http://reviews.llvm.org/D16511
___
cfe-commits mailing list
cfe-commits@lists.
Joerg, do you want to go ahead and merge this to 3.8 with
utils/release/merge.sh? (Or let me know if you'd prefer me to do it.)
On Sun, Jan 24, 2016 at 11:29 PM, Richard Smith wrote:
> Approved for branch.
>
> On 23 Jan 2016 11:56 p.m., "Joerg Sonnenberger"
> wrote:
>>
>> On Sat, Jan 16, 2016 at
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258712: LTO via the gold plugin needs to be told about
debugger tuning. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D16094?vs=44575&id=45893#toc
Repository:
rL LLVM
htt
Author: probinson
Date: Mon Jan 25 13:46:40 2016
New Revision: 258712
URL: http://llvm.org/viewvc/llvm-project?rev=258712&view=rev
Log:
LTO via the gold plugin needs to be told about debugger tuning.
Differential Revision: http://reviews.llvm.org/D16094
Modified:
cfe/trunk/lib/Driver/Tools.c
jlebar added a comment.
In http://reviews.llvm.org/D16501#335225, @tra wrote:
> Failing silently is not a good idea. At the very least there should produce
> an error.
> The right thing to do here, IMO, would be to generate a stub with alias name
> that just jumps to or calls aliasee.
Discus
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
OK. If someone attempts to rely on this feature in CUDA it will be obviously
broken due to the missing C-style mangled name. We can deal with it then.
http://reviews.llvm.org/D16501
Author: aaronballman
Date: Mon Jan 25 14:00:53 2016
New Revision: 258714
URL: http://llvm.org/viewvc/llvm-project?rev=258714&view=rev
Log:
Add support to the misc-assert-side-effect check for MSVC-style assert macros,
which use !! instead of an if statement or a conditional operator.
Modified:
davidxl added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:440
@@ +439,3 @@
+ if (CodeGenOpts.ProfileIRInstr) {
+// Should not have ProfileInstrGenerate set -- it is for clang
+// instrumentation only.
xur wrote:
> silvas wrote:
> > Then chang
rtrieu added a comment.
Hi Andy,
Could you give some motivation for this patch? From your example:
printf(minimal ? "%i\n" : "%i: %s\n", code, msg);
I would expect the first format string to produce a warning that msg is not
used.
http://reviews.llvm.org/D15636
thakis created this revision.
thakis added a reviewer: rsmith.
thakis added a subscriber: cfe-commits.
libstdc++ is using `= default` instead of `{}` for more and more of its
container classes, because they think DR 253 should be accepted
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60284). Sin
kromanova removed rL LLVM as the repository for this revision.
kromanova updated this revision to Diff 45902.
kromanova added a comment.
SCE's techinical writer, Craig Flores, did the code review and suggested a few
changes to the documentation.
http://reviews.llvm.org/D15999
Files:
lib/Head
arpith-jacob marked 5 inline comments as done.
arpith-jacob added a comment.
Patch fixed.
http://reviews.llvm.org/D16527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Merged in r258715.
On Mon, Jan 25, 2016 at 11:39 AM, Hans Wennborg wrote:
> Joerg, do you want to go ahead and merge this to 3.8 with
> utils/release/merge.sh? (Or let me know if you'd prefer me to do it.)
>
> On Sun, Jan 24, 2016 at 11:29 PM, Richard Smith wrote:
>> Approved for branch.
>>
>> O
kimgr added a subscriber: kimgr.
kimgr added a comment.
Cool check, I like how it pays attention to indentation!
I found some minor doc nits, see inline.
Comment at: docs/clang-tidy/checks/misc-suspicious-semicolon.rst:8-9
@@ +7,4 @@
+the code. More specifically, it looks for `
silvas added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:487
@@ +486,3 @@
+ // Opts.ProfileInstrGenerate will be used for Clang instrumentation only.
+ if (!Opts.ProfileIRInstr)
+Opts.ProfileInstrGenerate = Args.hasArg(OPT_fprofile_instr_generate) ||
---
ebaker355 added a comment.
Ping. Anyone have an opinion on this?
http://reviews.llvm.org/D16066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
OK. Now I understand what you meant. I was trying to avoid driver changes.
It seems you are saying I can change the driver to support cc1 options more
cleanly. This can be done.
Thanks,
Rong
On Jan 25, 2016 12:43, "Sean Silva" wrote:
> silvas added inline comments.
>
>
> Commen
xur added a subscriber: xur.
xur added a comment.
OK. Now I understand what you meant. I was trying to avoid driver changes.
It seems you are saying I can change the driver to support cc1 options more
cleanly. This can be done.
Thanks,
Rong
http://reviews.llvm.org/D15829
___
On Mon, Jan 25, 2016 at 12:52 PM, Rong Xu wrote:
> OK. Now I understand what you meant. I was trying to avoid driver changes.
> It seems you are saying I can change the driver to support cc1 options more
> cleanly. This can be done.
>
Great! Sorry for the confusion.
-- Sean Silva
> Thanks,
>
>
On Mon, Jan 25, 2016 at 11:00 AM, Xinliang David Li
wrote:
> On Fri, Jan 22, 2016 at 1:43 PM, Sean Silva wrote:
> > silvas added a comment.
> >
> > In http://reviews.llvm.org/D15829#333902, @davidxl wrote:
> >
> >> For the longer term, one possible solution is to make FE based
> >> instrumentat
Thanks for the reviews! Will address both when landing.
On Mon, Jan 25, 2016 at 2:34 PM, Hans Wennborg wrote:
> hans added a subscriber: hans.
> hans added a comment.
>
> Maybe this behavior should be called out in the Command-Line Options
> section under clang-cl in docs/UsersManual.rst?
>
>
>
On 25 January 2016 at 11:03, Yunzhong Gao
wrote:
> ygao added a comment.
>
> Thanks, Rafael!
> I did verify that the test would fail without my fix. But what do I need to
> do to make buildbots turn on the new lit parameter?
That I do not know. Mike?
Cheers,
Rafael
_
Author: ehsan
Date: Mon Jan 25 15:14:52 2016
New Revision: 258720
URL: http://llvm.org/viewvc/llvm-project?rev=258720&view=rev
Log:
[MSVC Compat] Only warn for unknown clang-cl arguments
Summary:
MSVC's driver accepts all unknown arguments but warns about them. clang
by default rejects all unkno
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258720: [MSVC Compat] Only warn for unknown clang-cl
arguments (authored by ehsan).
Changed prior to commit:
http://reviews.llvm.org/D16511?vs=45796&id=45906#toc
Repository:
rL LLVM
http://reviews.l
Alexander_Droste added inline comments.
Comment at: tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:662
@@ +661,3 @@
+else if (auto SV =
+ER->getIndex().getAs()) {
+llvm::SmallString<8> buf;
xazax.hun wrote:
> These are the only cases that ca
ahatanak added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:1954
@@ +1953,3 @@
+ // Erase all allocas and their users.
+ for (auto I = EntryBB->begin(); &*I != &*AllocaInsertPt; ++I)
+if (auto Alloca = dyn_cast(&*I))
hans wrote:
> would decla
ahatanak updated this revision to Diff 45910.
ahatanak added a comment.
Address review comments from Hans and Manman.
http://reviews.llvm.org/D15599
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGStmt.cpp
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGen/attr-nak
Eugene.Zelenko added a comment.
Just encountered next situation in my work code base:
void Function() {
...
if (Condition) {
}
else
return;
}
http://reviews.llvm.org/D16259
___
cfe-commits mailing list
cfe-commits@lists.l
Author: mren
Date: Mon Jan 25 15:52:26 2016
New Revision: 258727
URL: http://llvm.org/viewvc/llvm-project?rev=258727&view=rev
Log:
Move ObjCPropertyDecl to before ObjCContainerDecl.
After we add ObjCPropertyDecl::isClassProperty, we can use it in
ObjCContainerDecl to define filter to iterate over
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/CodeGen/cfi-check-fail.c:17
@@ +16,3 @@
+
+// CHECK: [[TRAP]]:
+// CHECK-NEXT: call void @llvm.trap()
Does this match in a -asserts build?
manmanren added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:1998
@@ +1997,3 @@
+ if (auto *T = EntryBB->getTerminator())
+T->eraseFromParent();
+
Yes, you are right.
http://reviews.llvm.org/D15599
1 - 100 of 145 matches
Mail list logo
