Given your follow-up review, and the behaviour of match_results::operator[], do you still have reservations?
> On 2016-Jan-25, at 08:19, Marshall Clow <mclow.li...@gmail.com> wrote: > > mclow.lists added a comment. > > Not crashing is good; but silently returning a "wrong" answer rubs me the > wrong way. I'll do some research and get back to you on this, but maybe > throwing an exception is a better response. > > The code looks fine, though; I'm just not sure it's the right thing to do. > > > http://reviews.llvm.org/D16467 > > > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
