Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

DmitryPolukhin added a comment. John and Richard, I would like to proceed with this patch one way or another. If this patch cannot be accepted in upstream, I'll discard it. On the other hand I'm ready to improve this patch further if it is OK in principle but needs more work. Please let me kno

Re: [PATCH] D15888: [Analyzer] Change the default SA checkers for PS4

ygribov added a subscriber: ygribov. ygribov added a comment. What's the problem with Vfork though? http://reviews.llvm.org/D15888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

pxli168 created this revision. pxli168 added reviewers: Anastasia, pekka.jaaskelainen. pxli168 added subscribers: bader, cfe-commits. Add Sema checks for opencl 2.0 new features: Block, pipe, atomic etc. Also fix some old Sema check like pointer to image. This patch is based on bader's patch in S

r257318 - AnalysisConsumer: use canonical decl for both lookup and store of

Author: ygribov Date: Mon Jan 11 03:38:48 2016 New Revision: 257318 URL: http://llvm.org/viewvc/llvm-project?rev=257318&view=rev Log: AnalysisConsumer: use canonical decl for both lookup and store of visited decls. Due to redeclarations, the function may have different declarations used in CallEx

Re: [PATCH] D15410: AnalysisConsumer: use canonical decl for both lookup and store of visited decls

This revision was automatically updated to reflect the committed changes. Closed by commit rL257318: AnalysisConsumer: use canonical decl for both lookup and store of (authored by ygribov). Changed prior to commit: http://reviews.llvm.org/D15410?vs=43726&id=6#toc Repository: rL LLVM htt

Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too

kfunk updated this revision to Diff 9. kfunk added a comment. Update, add (non-working) test Just uploading my WIP patch, now that the branching comes close. I added a test, unfortunately it doesn't do what I expect. Please see the FIXME. Didn't have the time to investigate yet, so any hint

Re: [PATCH] D12901: [Static Analyzer] Assertion "System is over constrained" after truncating 64 bits integers to 32 bits. (PR25078)

pgousseau added a comment. In http://reviews.llvm.org/D12901#320680, @zaks.anna wrote: > > This patch also fixes a bug in 'RangeSet::pin' causing single value ranges > > to not be considered conventionally ordered. > > > Can that fix be submitted as a separate patch? Is there a test for it? Ye

Re: [PATCH] D15743: Fix assert hit when tree-transforming template template parameter packs.

klimek updated this revision to Diff 44451. klimek added a comment. Expand test. http://reviews.llvm.org/D15743 Files: lib/Sema/TreeTransform.h test/SemaTemplate/temp_arg_template.cpp Index: test/SemaTemplate/temp_arg_template.cpp ===

Re: [PATCH] D15743: Fix assert hit when tree-transforming template template parameter packs.

klimek added a reviewer: bkramer. Comment at: test/SemaTemplate/temp_arg_template.cpp:80 @@ +79,3 @@ +#if __cplusplus >= 201103L + static constexpr int N = sizeof...(Templates); +#endif dblaikie wrote: > It would be good if we tested for some specific behavior he

[clang-tools-extra] r257320 - [clang-tidy] Fix a false positive in google-runtime-memset

Author: alexfh Date: Mon Jan 11 04:26:29 2016 New Revision: 257320 URL: http://llvm.org/viewvc/llvm-project?rev=257320&view=rev Log: [clang-tidy] Fix a false positive in google-runtime-memset google-runtime-memset no longer issues a warning if the fill char value is known to be an invalid fill ch

r257325 - clang-format: Slightly row back on r257257.

Author: djasper Date: Mon Jan 11 05:01:05 2016 New Revision: 257325 URL: http://llvm.org/viewvc/llvm-project?rev=257325&view=rev Log: clang-format: Slightly row back on r257257. r257257 change the way clang-format enforces line breaks after a templated type has been line-wrapped. This was to fix

r257324 - clang-format: [JS] Improve line-flow when calling functions on array literals.

Author: djasper Date: Mon Jan 11 05:00:58 2016 New Revision: 257324 URL: http://llvm.org/viewvc/llvm-project?rev=257324&view=rev Log: clang-format: [JS] Improve line-flow when calling functions on array literals. Before: return [ aa ].aaa(function() { // })

Re: [PATCH] D16044: getVariableName() for MemRegion

xazax.hun added inline comments. Comment at: tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:643 @@ +642,3 @@ + const clang::ento::MemRegion *R = this; + llvm::SmallString<200> buf; + llvm::raw_svector_ostream os(buf); Do you think 200 is a reasonable size he

Re: [PATCH] D15743: Fix assert hit when tree-transforming template template parameter packs.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good. getAsTemplateOrTemplatePattern mirrors the existing switch in TreeTransform. http://reviews.llvm.org/D15743 ___ cfe-commits m

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

nemanjai updated the summary for this revision. nemanjai updated this revision to Diff 44459. nemanjai added a comment. Addressed the review comments: - Added the requested test cases - Disabled promotion of long double to __float128 - Disabled operations between long double and __float128 if the

Re: [PATCH] D15743: Fix assert hit when tree-transforming template template parameter packs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257326: Fix assert hit when tree-transforming template template parameter packs. (authored by klimek). Changed prior to commit: http://reviews.llvm.org/D15743?vs=44451&id=44460#toc Repository: rL LLV

r257326 - Fix assert hit when tree-transforming template template parameter packs.

Author: klimek Date: Mon Jan 11 05:39:00 2016 New Revision: 257326 URL: http://llvm.org/viewvc/llvm-project?rev=257326&view=rev Log: Fix assert hit when tree-transforming template template parameter packs. Covers significantly more code in the template template pack argument test and fixes the re

[PATCH] D16056: [Gold] Pass -mllvm options to the gold plugin

jmolloy created this revision. jmolloy added a reviewer: rafael. jmolloy added a subscriber: cfe-commits. jmolloy set the repository for this revision to rL LLVM. Herald added a subscriber: joker.eph. The gold plugin can take LLVM options, but the syntax is confusing: -Wl,-plugin-opt= or -Xlinker

r257327 - [WebAssembly] Fix a typo in a comment.

Author: djg Date: Mon Jan 11 05:49:44 2016 New Revision: 257327 URL: http://llvm.org/viewvc/llvm-project?rev=257327&view=rev Log: [WebAssembly] Fix a typo in a comment. Modified: cfe/trunk/test/Driver/wasm-toolchain.c Modified: cfe/trunk/test/Driver/wasm-toolchain.c URL: http://llvm.org/vie

r257330 - clang-format: Fix overloading "operator, " definitions more thoroughly.

Author: djasper Date: Mon Jan 11 06:55:33 2016 New Revision: 257330 URL: http://llvm.org/viewvc/llvm-project?rev=257330&view=rev Log: clang-format: Fix overloading "operator," definitions more thoroughly. Before: aa operator,(a &

[PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer created this revision. bkramer added a reviewer: djasper. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. As soon as a comment had whitespace changes inside of the token, we couldn't identify the whole comment as a trailing comment anymore and alignment stopped

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.h:145 @@ +144,3 @@ +// comment. +bool IsTrailingCommentContinuation; + I find the term "continuation" a bit confusing here. How about something like "IsInsideToken"? http://reviews.

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

klimek added inline comments. Comment at: lib/Format/WhitespaceManager.h:145 @@ +144,3 @@ +// comment. +bool IsTrailingCommentContinuation; + djasper wrote: > I find the term "continuation" a bit confusing here. How about something like > "IsInsideToken"?

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer updated this revision to Diff 44472. bkramer added a comment. Why not both? http://reviews.llvm.org/D16058 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ===

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.h:145 @@ +144,3 @@ +// comment. +bool IsTrailingCommentContinuation; + klimek wrote: > djasper wrote: > > I find the term "continuation" a bit confusing here. How about something > >

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

ABataev added a comment. Kelvin, thanks for the patch! One more comment: what about nesting of regions? You need to add a corresponding code and tests Comment at: include/clang/AST/OpenMPClause.h:3196 @@ -3195,1 +3195,3 @@ +/// \brief This represents clause 'from' in the '#pr

[PATCH] D16062: [analyzer] Rename kind-enumeration values of SVal, SymExpr, MemRegion classes, for consistency.

NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin. NoQ added a subscriber: cfe-commits. Based on discussion in D15448. - For every sub-class `C`, its kind in the relevant enumeration is `CKind` (or `C##Kind` in preprocessor-ish terms), eg: `MemRegionKind` -> `MemRegionValKin

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

aaron.ballman added a comment. In http://reviews.llvm.org/D15443#323043, @adek05 wrote: > I think this won't work. If there is a problem with the expression inside > `throw` or `noexcept` specifier, it will be highlighted inside the parens, > never trying to actually access the end location of

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

aaron.ballman added a comment. Ping http://reviews.llvm.org/D15796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16044: getVariableName() for MemRegion

Alexander_Droste updated this revision to Diff 44476. Alexander_Droste added a comment. - reduced buffer size for variable name - simplified `R->getAs()->getSuperRegion()` to `ER->getSuperRegion()`. http://reviews.llvm.org/D16044 Files: tools/clang/include/clang/StaticAnalyzer/Core/PathSensi

Re: [PATCH] D15448: [analyzer] SVal Visitor.

NoQ updated this revision to Diff 44475. NoQ marked 5 inline comments as done. NoQ added a comment. Renamed the kinds for consistency (review http://reviews.llvm.org/D16062), this diff is updated to use the new naming convention. The 'kind' column gets removed from the def-files. http://review

Re: [PATCH] D16044: getVariableName() for MemRegion

Alexander_Droste marked 2 inline comments as done. Comment at: tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:643 @@ +642,3 @@ + const clang::ento::MemRegion *R = this; + llvm::SmallString<50> buf; + llvm::raw_svector_ostream os(buf); You're right, 200 was a

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

alexfh added a comment. Sorry for the delay and thanks for pinging me. Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:6 @@ +5,3 @@ +cert-dcl54-cpp +== + aaron.ballman wrote: > > We need to teach add_new_check.py to retain (or automatically gen

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:6 @@ +5,3 @@ +cert-dcl54-cpp +== + alexfh wrote: > aaron.ballman wrote: > > > We need to teach add_new_check.py to retain (or automatically generate) > > > thes

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

aaron.ballman updated this revision to Diff 44492. aaron.ballman added a comment. Adding newlines to the end of some files, per feedback. http://reviews.llvm.org/D15796 Files: docs/clang-tidy/checks/cert-dcl03-c.rst docs/clang-tidy/checks/cert-dcl54-cpp.rst docs/clang-tidy/checks/cert-dcl

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. http://reviews.llvm.org/D15796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16063: [Analyzer] Use a wider integer type for an array index

a.sidorin created this revision. a.sidorin added reviewers: zaks.anna, dcoughlin, xazax.hun. a.sidorin added a subscriber: cfe-commits. a.sidorin set the repository for this revision to rL LLVM. Currently, a default index type in CSA is 'int'. However, this assumption seems to be incorrect for 64

Re: [PATCH] D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973.

mclow.lists updated this revision to Diff 44496. mclow.lists added a comment. Updated to address Tim's comments. http://reviews.llvm.org/D15862 Files: include/algorithm include/iterator include/string test/std/strings/basic.string/string.modifiers/string_append/initializer_list.pass.cp

Re: [PATCH] D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973.

mclow.lists marked 2 inline comments as done. Comment at: include/string:2677-2678 @@ +2676,4 @@ +#endif +for (; __first != __last; ++__first) +push_back(*__first); + tcanens wrote: > If an exception is thrown after a `push_back()` causes reall

Re: [PATCH] D14277: [Analyzer] Make referenced SymbolMetadata live even if its region is dead

a.sidorin added a comment. Ping? Repository: rL LLVM http://reviews.llvm.org/D14277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16065: Fix infinite recursion for invalid declaration

DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: rsmith. DmitryPolukhin added subscribers: cfe-commits, kcc. Fix for a case found by fuzzing PR23057 (comment #25 https://llvm.org/bugs/show_bug.cgi?id=23057#c25). http://reviews.llvm.org/D16065 Files: lib/AST/Decl.cpp te

Re: [PATCH] D16063: [Analyzer] Use a wider integer type for an array index

xazax.hun added a comment. How is this array index type used? Should it support negative values? If the answer is no, ASTContext has a getSizeType method. If it is yes, it also has a getPointerDiffType method (although it returns a QualType not a CanQualType). Is there a reason not to use them?

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

alexfh added inline comments. Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:7 @@ +6,3 @@ +== + +The cert-dcl54-cpp checker is an alias, please see This seems to do what we need (full file is here {F1298675}): ``` diff --git a/clang-tidy/add_ne

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

alexfh added inline comments. Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:7 @@ +6,3 @@ +== + +The cert-dcl54-cpp checker is an alias, please see alexfh wrote: > This seems to do what we need (full file is here {F1298675}): > > ``` > diff --g

[PATCH] D16066: Add BeforeWhileInDoWhile BraceWrapping option

ebaker355 created this revision. ebaker355 added a subscriber: cfe-commits. Herald added a subscriber: klimek. Adds a new BraceWrapping option called BeforeWhileInDoWhile. Code like this: do { // Some code } while (1); becomes: do { // Some code } while (1);

Re: [PATCH] D16066: Add BeforeWhileInDoWhile BraceWrapping option

ebaker355 updated this revision to Diff 44506. ebaker355 added a comment. Remove unintended blank line change. http://reviews.llvm.org/D16066 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer updated this revision to Diff 44508. bkramer added a comment. - Renamed flag to IsInsideToken and enabled it for all in-token replacements. - TokenLength now gets updated to contain all changes on the same line if they're in the same token. http://reviews.llvm.org/D16058 Files: lib/F

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

aaron.ballman updated this revision to Diff 44507. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Adds the add_new_check.py changes from Alex, regenerates list.rst from the Python script. http://reviews.llvm.org/D15796 Files: clang-tidy/add_new_check.py docs

Re: [PATCH] D16063: [Analyzer] Use a wider integer type for an array index

a.sidorin added a comment. In http://reviews.llvm.org/D16063#323462, @xazax.hun wrote: > How is this array index type used? This type is used to make all the symbolic values for indices to have the same integer type (in SValBuilder). In http://reviews.llvm.org/D16063#323462, @xazax.hun wrote:

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. I think this looks good, but I'd also like Manuel to take a look. http://reviews.llvm.org/D16058 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

Anastasia added inline comments. Comment at: include/clang/Basic/Builtins.def:1260 @@ +1259,3 @@ + +LANGBUILTIN(reserve_read_pipe, "i.", "tn", OCLC_LANG) +LANGBUILTIN(reserve_write_pipe, "i.", "tn", OCLC_LANG) Ok, this way it means variable number of arg which isn

Re: [PATCH] D16063: [Analyzer] Use a wider integer type for an array index

xazax.hun added a comment. In http://reviews.llvm.org/D16063#323513, @a.sidorin wrote: > As I described before, PtrDiffType is signed and is limited to SIZE_MAX/2. > However, we are allowed to create arrays with the size more than SIZE_MAX/2 > (see testIndexTooBig() test for details). But we sh

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4934 @@ +4933,3 @@ +const Type *DeclTy = PDecl->getType().getCanonicalType().getTypePtr(); +if (AccessAttr->isReadWrite()) { + if (DeclTy->isPipeType() || In the case of failure, w

Re: [PATCH] D15823: Support virtual-near-miss check.

alexfh added a comment. A few minor comments. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:23 @@ +22,3 @@ +/// Finds out if the given method overrides some method. +bool isOverrideMethod(const CXXMethodDecl *MD) { + return MD->size_overridden_methods() > 0 || MD->hasAtt

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer updated this revision to Diff 44513. bkramer added a comment. - Moved newline check into replaceWhitespaceInToken - Removed duplicated TokenLength computation http://reviews.llvm.org/D16058 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Format/For

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. lg Comment at: lib/Format/WhitespaceManager.h:113 @@ -113,1 +112,3 @@ + bool ContinuesPPDirective, bool IsStartOfDeclName, + bool IsInsideTrailingCommentToken);

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > resistor created this revision. > resistor added reviewers: chandlerc, bkramer, klimek. > resistor added a subscriber: cfe-commits. > resistor set the repository for this revision to rL LLVM. > H

r257341 - [clang-format] Fix comment aligning when there are changes within the comment

Author: d0k Date: Mon Jan 11 10:27:16 2016 New Revision: 257341 URL: http://llvm.org/viewvc/llvm-project?rev=257341&view=rev Log: [clang-format] Fix comment aligning when there are changes within the comment As soon as a comment had whitespace changes inside of the token, we couldn't identify the

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

This revision was automatically updated to reflect the committed changes. Closed by commit rL257341: [clang-format] Fix comment aligning when there are changes within the comment (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D16058?vs=44513&id=44517#toc Repository: rL L

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! http://reviews.llvm.org/D15796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Ping! http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r257347 - Add documentation redirects for clang-tidy checkers that are exposed under multiple checker names. Updates the Python script for adding checks to properly handle these al

Author: aaronballman Date: Mon Jan 11 10:48:26 2016 New Revision: 257347 URL: http://llvm.org/viewvc/llvm-project?rev=257347&view=rev Log: Add documentation redirects for clang-tidy checkers that are exposed under multiple checker names. Updates the Python script for adding checks to properly ha

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r257347. http://reviews.llvm.org/D15796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

rjmccall added a comment. Sorry, holidays. I'm comfortable with taking this patch as-is. http://reviews.llvm.org/D14980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rL257357: [Sema] Issue a warning for integer overflow in struct initializer (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D15097?vs=41451&id=44521#toc Repository: rL LLVM ht

r257357 - [Sema] Issue a warning for integer overflow in struct initializer

Author: ahatanak Date: Mon Jan 11 11:22:01 2016 New Revision: 257357 URL: http://llvm.org/viewvc/llvm-project?rev=257357&view=rev Log: [Sema] Issue a warning for integer overflow in struct initializer Clang wasn't issuing a warning when compiling the following code: struct s { unsigned x; } s

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

Any feedback? Thanks, --Serge 2015-12-11 20:24 GMT+06:00 Serge Pavlov : > sepavloff created this revision. > sepavloff added a subscriber: cfe-commits. > > Llvm module object is shared between CodeGenerator and BackendConsumer, > in both classes it is stored as std::unique_ptr, which is not a go

Re: r257357 - [Sema] Issue a warning for integer overflow in struct initializer

On Mon, Jan 11, 2016 at 05:22:01PM -, Akira Hatanaka via cfe-commits wrote: > Author: ahatanak > Date: Mon Jan 11 11:22:01 2016 > New Revision: 257357 > > URL: http://llvm.org/viewvc/llvm-project?rev=257357&view=rev > Log: > [Sema] Issue a warning for integer overflow in struct initializer >

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

pekka.jaaskelainen added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5733 @@ +5732,3 @@ + +#if 0 + Is this intentionally included in the patch? Comment at: lib/Sema/SemaDecl.cpp:6759 @@ +6758,3 @@ + +#if 0 + // OpenCL v2.0 s6.9.b ---

Re: [PATCH] D12901: [Static Analyzer] Assertion "System is over constrained" after truncating 64 bits integers to 32 bits. (PR25078)

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Sounds good. Please, split this into 2 patches (each fixing the separate problem) and commit. Thanks! Anna. http://reviews.llvm.org/D12901 __

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pekka.jaaskelainen added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:2033 @@ +2032,3 @@ + *Arg1 = EmitScalarExpr(E->getArg(1)); +llvm::Type *ReservedIDTy = ConvertType(getContext().OCLReserveIDTy); + Anastasia wrote: > Why do we need to mod

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

Anastasia added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:2033 @@ +2032,3 @@ + *Arg1 = EmitScalarExpr(E->getArg(1)); +llvm::Type *ReservedIDTy = ConvertType(getContext().OCLReserveIDTy); + pekka.jaaskelainen wrote: > Anastasia wrote: > >

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pekka.jaaskelainen added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:2033 @@ +2032,3 @@ + *Arg1 = EmitScalarExpr(E->getArg(1)); +llvm::Type *ReservedIDTy = ConvertType(getContext().OCLReserveIDTy); + Anastasia wrote: > pekka.jaaskelainen wr

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

rnk added a subscriber: rnk. rnk added a comment. In http://reviews.llvm.org/D15363#321941, @samsonov wrote: > Interesting. Do we run test/asan/TestCases/suppressions-interceptor.cc on > Windows? Seems so: I don't see an XFAIL there, and it also uses > suppressions, but with single quote, follo

Re: [PATCH] D16062: [analyzer] Rename kind-enumeration values of SVal, SymExpr, MemRegion classes, for consistency.

zaks.anna added a comment. > MemSpaceRegion is now an abstract base What prevents it from being instantiated? http://reviews.llvm.org/D16062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: > > > > On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits > wrote: > resistor created this revision. > resistor added reviewers: chandlerc, bkramer, klimek. > resistor added a subscriber: cfe-commits. > resistor set the reposi

[libcxx] r257368 - Preemptively disable unsigned integer sanitization in 32 and 64 bit versions of __murmur2_or_cityhash. This lets people use the unsigned integer overflow checker in UBSAN w/o gettin

Author: marshall Date: Mon Jan 11 13:27:10 2016 New Revision: 257368 URL: http://llvm.org/viewvc/llvm-project?rev=257368&view=rev Log: Preemptively disable unsigned integer sanitization in 32 and 64 bit versions of __murmur2_or_cityhash. This lets people use the unsigned integer overflow checker

Re: r257357 - [Sema] Issue a warning for integer overflow in struct initializer

It triggers in dead branches and so does an initialization of an integer variable declared in a function. I’ll look into fixing it. > On Jan 11, 2016, at 9:54 AM, Joerg Sonnenberger via cfe-commits > wrote: > > On Mon, Jan 11, 2016 at 05:22:01PM -, Akira Hatanaka via cfe-commits > wrote:

Re: [PATCH] D15858: Warn undeclared identifiers in CUDA kernel calls

jhen updated this revision to Diff 44538. jhen added a comment. - Handle unexpanded parameter packs The changes for instantiation dependence also fix a bug with unexpanded parameter packs, so add a unit test for unexpanded parameter packs as well. http://reviews.llvm.org/D15858 Files: inc

Re: [PATCH] D15921: [analyzer] Utility to match function calls.

zaks.anna added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:312 @@ +311,3 @@ + /// calls. + bool isCalled(const CallEvent &Call, const CallDescription &CD); + The API is a bit awkward. Maybe it would be better if

r257383 - Fix -Wmicrosoft-enum-value warning

Author: rnk Date: Mon Jan 11 14:55:16 2016 New Revision: 257383 URL: http://llvm.org/viewvc/llvm-project?rev=257383&view=rev Log: Fix -Wmicrosoft-enum-value warning Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h URL: http://llvm.org/viewv

Re: [PATCH] D16062: [analyzer] Rename kind-enumeration values of SVal, SymExpr, MemRegion classes, for consistency.

dcoughlin added a comment. Looks good to me. Thanks for making this more consistent! Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:102 @@ -103,1 +101,3 @@ +BEGIN_TYPED_REGIONS, +FunctionTextRegionKind = BEGIN_TYPED_REGIONS, BlockTextRegionK

Re: r257357 - [Sema] Issue a warning for integer overflow in struct initializer

On Mon, Jan 11, 2016 at 12:28:36PM -0800, Akira Hatanaka via cfe-commits wrote: > It triggers in dead branches and so does an initialization of an integer > variable declared in a function. I'm more interested in the case of global initialisers here. There is a long standing history of not checki

[PATCH] D16078: Add an Action* member to InputInfo.

jlebar created this revision. jlebar added a reviewer: echristo. jlebar added subscribers: cfe-commits, tra, jhen. Herald added subscribers: dschuff, jfb. The CUDA toolchain needs to know which Actions created which InputInfos, because it needs to attach GPU archs to the various InputInfos. http:

[PATCH] D16080: [CUDA] Add tests for compiling CUDA files with -E.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: jhen, cfe-commits. http://reviews.llvm.org/D16080 Files: test/Driver/cuda-preprocess.cu Index: test/Driver/cuda-preprocess.cu === --- /dev/null

[PATCH] D16081: [CUDA] Add test for compiling CUDA code with -S.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: jhen, cfe-commits. http://reviews.llvm.org/D16081 Files: test/Driver/cuda-options.cu test/Driver/cuda-output-asm.cu Index: test/Driver/cuda-output-asm.cu

[PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: echristo, jhen, cfe-commits. http://reviews.llvm.org/D16079 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp lib/Driver/Driver.cpp test/Driver/cuda-bad-arch.cu Index: test/Driver/cuda-bad-arch

[PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

jlebar created this revision. jlebar added reviewers: tra, echristo. jlebar added subscribers: jhen, cfe-commits. Previously we compiled CUDA device code to PTX assembly and embedded that asm as text in our host binary. Now we compile to PTX assembly and then invoke ptxas to assemble the PTX into

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig added a comment. ping http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. FOAD: Ball's in @mclow.lists's court, not mine. I don't feel comfortable signing off on this. http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

r257392 - PR26087: Use nonstandard MSVC extension for VS2015 as well.

Author: jyknight Date: Mon Jan 11 16:00:22 2016 New Revision: 257392 URL: http://llvm.org/viewvc/llvm-project?rev=257392&view=rev Log: PR26087: Use nonstandard MSVC extension for VS2015 as well. In r256564, I had conditioned the workaround in has_getDecl to only be used for MSVC before the 2015 r

[PATCH] D16087: Add some overview doxygen comments to lib/Format.

thakis created this revision. thakis added a reviewer: djasper. thakis added a subscriber: cfe-commits. Herald added a subscriber: klimek. It always takes me a while to understand how clang-format's pieces fit together -- hopefully this will save me some time the next time I need it. http://revi

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

On Mon, Jan 11, 2016 at 8:08 PM, Owen Anderson wrote: > >> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: >> >> >> >> On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits >> wrote: >> resistor created this revision. >> resistor added reviewers: chandlerc, bkramer, klimek. >> resis

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

> On Jan 11, 2016, at 2:13 PM, Benjamin Kramer wrote: > > On Mon, Jan 11, 2016 at 8:08 PM, Owen Anderson > wrote: >> >>> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: >>> >>> >>> >>> On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits >>> wrote: >

Re: [PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. LGTM. -eric http://reviews.llvm.org/D16079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

tra added a comment. Make sure it works with -save-temps and -fintegrated-as/-fno-integrated-as. They tend to throw wrenches into pipeline construction. Comment at: lib/Driver/Driver.cpp:1380 @@ +1379,3 @@ + C.MakeAction(DeviceActions, types::TY_CUDA_FATBIN), + /* Gpu

Re: [PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

echristo added a comment. One question inline, one nit, and one more question here: You've got a couple of checks inline for null names/architectures, where do you expect those to come from and can you test for them? Or, another question, is if they're multiple architectures shouldn't we be abl

Re: [PATCH] D16078: Add an Action* member to InputInfo.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Sure. Seems reasonable. -eric http://reviews.llvm.org/D16078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

r257403 - When a tag is declared in prototype scope in C, if we've decided that it

Author: rsmith Date: Mon Jan 11 16:41:53 2016 New Revision: 257403 URL: http://llvm.org/viewvc/llvm-project?rev=257403&view=rev Log: When a tag is declared in prototype scope in C, if we've decided that it redeclares an existing tag but are creating a new declaration anyway (because it has attribu

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren added a comment. Ping :] http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >