mclow.lists marked 2 inline comments as done. ================ Comment at: include/string:2677-2678 @@ +2676,4 @@ +#endif + for (; __first != __last; ++__first) + push_back(*__first); + ---------------- tcanens wrote: > If an exception is thrown after a `push_back()` causes reallocation, existing > iterators/pointers/references would have been invalidated, and the `catch` > block can't do anything about it. > > It looks like a temporary string is also needed here. Dang, you're right. Thanks.
http://reviews.llvm.org/D15862 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
