Author: yrnkrn
Date: Tue Dec 1 02:14:39 2015
New Revision: 254392
URL: http://llvm.org/viewvc/llvm-project?rev=254392&view=rev
Log:
Remove superfluous StringRef casts, NFC.
Modified:
cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp
Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp
URL:
http://
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
There is another copy of getEffectiveDeclContext in MicrosoftMangle.cpp which
pre-commit was identical to this one.
Should it get this commit as well to keep both identical?
If so, could both copies of getEffectiveDeclConte
Author: xazax
Date: Tue Dec 1 03:00:41 2015
New Revision: 254394
URL: http://llvm.org/viewvc/llvm-project?rev=254394&view=rev
Log:
[analyzer] Fix IssueHash generation.
Differential Revision: http://reviews.llvm.org/D14919
Original patch by: Gyorgy Orban!
Modified:
cfe/trunk/include/clang/
NoQ added a subscriber: NoQ.
NoQ added a comment.
Yeah, that's what i had in mind. Additionally, `Decl` can be obtained as
`Context.getStackFrame().getDecl()` (and in fact the `getStackFrame()` thing
itself is of interest as well), so there's no need to pass it as an extra
argument. On the othe
xazax.hun closed this revision.
xazax.hun added a comment.
Committed in r254394.
http://reviews.llvm.org/D14919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs requested changes to this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
This revision now requires changes to proceed.
I'm getting a couple of test failures from this patch:
Clang :: Driver/linux-header-search.cpp
Clang :: Driver/solaris-header-search.cpp
DmitryPolukhin updated this revision to Diff 41481.
DmitryPolukhin added a comment.
Added more testcases to cover combination of explicit alignment of bit-filed
with packed attribute. Also added testing on ARM for bit-filed layout test.
http://reviews.llvm.org/D14980
Files:
lib/AST/RecordLay
DmitryPolukhin added a comment.
I added more testcases and they all pass identically on GCC and clang with my
patch. Please let me know if you think, that some cases are not covered or
doesn't work with my patch. Perhaps we can reduce number of test-cases because
some of them almost duplicates
Hi Eric,
While I agree with you in principle, Alexandros has just pointed out to me
that all the other NEON intrinsics have such -O3 tests, and thinking about
it I do think they add value. They test the full-trip through the compiler
and ensure that Clang and LLVM have matching ideas of the IR int
Author: djasper
Date: Tue Dec 1 06:00:43 2015
New Revision: 254406
URL: http://llvm.org/viewvc/llvm-project?rev=254406&view=rev
Log:
This fixes https://llvm.org/bugs/show_bug.cgi?id=25329, as well as
misalignments like the following:
int a, b = 2;
int c= 3;
Patch by Beren Minor, thanks!
djasper closed this revision.
djasper added a comment.
Submitted as r254406.
Note that I had to make the struct "Change" public. How did this compile on
your end?
http://reviews.llvm.org/D14325
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
rmaprath added a comment.
Ping?
http://reviews.llvm.org/D14653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Tue Dec 1 06:05:04 2015
New Revision: 254407
URL: http://llvm.org/viewvc/llvm-project?rev=254407&view=rev
Log:
clang-format: treat Q_SIGNALS as an access modifier
Patch by Alexander Richardson, thank you!
Modified:
cfe/trunk/lib/Format/FormatToken.h
cfe/trunk/lib/F
DmitryPolukhin added a comment.
This is another GCC ABI compatibility issue. If there is no more comments,
could someone please approve this CL?
http://reviews.llvm.org/D14872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
xazax.hun added a comment.
In http://reviews.llvm.org/D15007#298086, @dcoughlin wrote:
> Gabor, thanks for taking a look at this!
>
> I'm not sure `RegionStore::getBinding()` is the right place to put this logic.
>
> First, not all dereferences of a `std::nullptr_t` value go through
> `getBindin
On 1 December 2015 at 11:44, James Molloy via cfe-commits
wrote:
> In summary, I agree with you that we need tests for both Clang and LLVM
> separately. However I also think the full-trip tests add significant value
> and wouldn't like to see them removed, and there's significant prior art in
> th
xazax.hun updated this revision to Diff 41494.
xazax.hun added a comment.
- Added the test case Devin suggested.
- Implemented the fix Devin suggested.
- Updated to latest trunk.
http://reviews.llvm.org/D15007
Files:
lib/StaticAnalyzer/Core/SValBuilder.cpp
test/Analysis/nullptr.cpp
Index:
Author: djasper
Date: Tue Dec 1 07:28:53 2015
New Revision: 254414
URL: http://llvm.org/viewvc/llvm-project?rev=254414&view=rev
Log:
clang-format: Make it possible to turn off comment reflowing.
Modified:
cfe/trunk/include/clang/Format/Format.h
cfe/trunk/lib/Format/ContinuationIndenter.c
berenm added a comment.
I don't have any compilation error with GCC 5.2.1. I tried again with Clang 3.8
and indeed there is this error:
tools/clang/lib/Format/WhitespaceManager.cpp:155:51: error: 'Change' is a
private member of 'clang::format::WhitespaceManager'
SmallVect
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:1046
@@ +1045,3 @@
+ diag::note_attribute_packed_for_bitfield_offset_changed)
+<< FD->getDeclName();
+
No need to call getDeclName(), the diagnostic can accept a NamedDe
Author: aaronballman
Date: Tue Dec 1 08:05:39 2015
New Revision: 254415
URL: http://llvm.org/viewvc/llvm-project?rev=254415&view=rev
Log:
Add a new checker, cert-err58-cpp, that checks for static or thread_local
objects that use a throwing constructor.
This check corresponds to the CERT secure
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r254415.
Comment at: clang-tidy/utils/Matchers.h:26
@@ -25,1 +25,3 @@
+AST_MATCHER(FunctionDecl, isNoThrow) {
+ const auto *FnTy = Node.getType()->getAs();
alexfh wrote:
> Anything w
spetrovic added a comment.
Comments addressed.
http://reviews.llvm.org/D14871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spetrovic updated this revision to Diff 41498.
spetrovic marked 3 inline comments as done.
http://reviews.llvm.org/D14871
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/ppc-varargs-struct.c
test/CodeGen/x86_64-arguments.c
Index: test/CodeGen/x86_64-arguments.c
=
DmitryPolukhin updated this revision to Diff 41510.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
Don't call getDeclName() that it is not required. PTAL
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.
aturetsk updated this revision to Diff 41511.
aturetsk added a comment.
Enable X87 back for all X86 processors.
http://reviews.llvm.org/D13980
Files:
lib/Basic/Targets.cpp
test/CodeGen/attr-target-x86-mmx.c
test/CodeGen/attr-target-x86.c
Index: test/CodeGen/attr-target-x86.c
aturetsk added inline comments.
Comment at: lib/Basic/Targets.cpp:2551
@@ -2547,3 +2550,3 @@
case CK_i386:
case CK_i486:
case CK_i586:
"x87 instructions probably work" is more like it, and having feature x87
disabled would mean "x87 instructions definite
Hi James,
I disagree with you completely on every point except that you need to write
new tests.
There is absolutely, as I said in the thread where I noticed this for the
x86 intrinsics, that you cannot supply this test up and test it in the
front and the back end separately. If you believe this
Author: aaronballman
Date: Tue Dec 1 11:15:13 2015
New Revision: 254423
URL: http://llvm.org/viewvc/llvm-project?rev=254423&view=rev
Log:
It appears that this horrible mutating copy constructor is unused. Kill it with
fire.
Modified:
cfe/trunk/include/clang/Sema/AttributeList.h
Modified: c
Hi Eric,
This isn't just a NEON intrinsics thing, and this isn't just an ARM/AArch64
thing. There needs to be some way to test the compiler from start to
finish. Not being able to do so leaves serious coverage holes.
Unit testing is great, but integration testing is required sometimes to
ensure m
rnk added a comment.
In http://reviews.llvm.org/D14180#299183, @martell wrote:
> I tried testing __has_builtin(_InterlockedCompareExchangeAdd) as it seem to
> not exist even when -fms-extensions is passed
> Is this a bug or it is intended ?
Neither Clang nor MSDN have anything by that name. D
On 1 December 2015 at 17:23, James Molloy via cfe-commits
wrote:
> This isn't just a NEON intrinsics thing, and this isn't just an ARM/AArch64
> thing. There needs to be some way to test the compiler from start to finish.
> Not being able to do so leaves serious coverage holes.
Just for the sake
probinson added a comment.
Thanks Michael! Moving the mm256 stuff to immintrin.h ought to work. What
actually motivates this is mucking around with modularizing the intrinsic
headers, and the immediate problem is the duplicate typedefs for __v8sf and
__m256 (which are in both f16cintrin.h and
nemanjai created this revision.
nemanjai added reviewers: hfinkel, wschmidt, kbarton, rsmith.
nemanjai added a subscriber: cfe-commits.
nemanjai set the repository for this revision to rL LLVM.
Herald added a subscriber: klimek.
This patch adds support for the __float128 keyword and literals for I
Hi,
On Tue, Dec 1, 2015 at 7:45 PM, Reid Kleckner via cfe-commits
wrote:
> rnk added a comment.
>
> In http://reviews.llvm.org/D14180#299183, @martell wrote:
>
>> I tried testing __has_builtin(_InterlockedCompareExchangeAdd) as it seem to
>> not exist even when -fms-extensions is passed
>> Is t
On Tue, Dec 1, 2015 at 8:06 PM, Ismail Donmez wrote:
> Hi,
>
> On Tue, Dec 1, 2015 at 7:45 PM, Reid Kleckner via cfe-commits
> wrote:
>> rnk added a comment.
>>
>> In http://reviews.llvm.org/D14180#299183, @martell wrote:
>>
>>> I tried testing __has_builtin(_InterlockedCompareExchangeAdd) as it
mclow.lists created this revision.
mclow.lists added reviewers: klimek, aaron.ballman, chandlerc.
mclow.lists added a subscriber: cfe-commits.
Motivation: LLVM has many overloads of `std::swap` for its own types. This is
technically forbidden by the standard, but is pervasive in the LLVM code bas
On Tue, Dec 1, 2015 at 9:23 AM James Molloy wrote:
> Hi Eric,
>
> This isn't just a NEON intrinsics thing, and this isn't just an
> ARM/AArch64 thing. There needs to be some way to test the compiler from
> start to finish. Not being able to do so leaves serious coverage holes.
>
> Unit testing is
On Tue, Dec 1, 2015 at 9:56 AM, Renato Golin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 1 December 2015 at 17:23, James Molloy via cfe-commits
> wrote:
> > This isn't just a NEON intrinsics thing, and this isn't just an
> ARM/AArch64
> > thing. There needs to be some way to test th
Hi,
> That would sort of defeat the point of having the testing and projects
separated though - it would tie the tests together and produce most of the
undesirable outcomes of having single end-to-end tests.
End to end tests have significant disadvantages as we all know. However
they do have some
On 1 December 2015 at 18:29, David Blaikie wrote:
> Are they things the test-suite couldn't (either technically or
> philosophically) cover, or only that it doesn't cover it at the moment, but
> could do so?
IMO, it's a philosophical issue. The test-suite is a whole-program
execution, and all tha
mclow.lists added a comment.
Also, even though the `--fix` done by the tool is (almost) correct, the display
of the fixit hint by clang is really confusing, even wrong
http://reviews.llvm.org/D15121
___
cfe-commits mailing list
cfe-commits@lists.ll
On Tue, Dec 1, 2015 at 10:43 AM James Molloy via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> > That would sort of defeat the point of having the testing and projects
> separated though - it would tie the tests together and produce most of the
> undesirable outcomes of having single
You cannot test the intrinsic emission with the same quality when splitting
the test in two. You miss testing the producer consumer relationship
between the two components.
I'm sorry that this use case appears to you as not qualifying.
On Tue, 1 Dec 2015 at 18:45, Eric Christopher wrote:
> On Tu
On Tue, Dec 1, 2015 at 10:43 AM, Renato Golin
wrote:
> On 1 December 2015 at 18:29, David Blaikie wrote:
> > Are they things the test-suite couldn't (either technically or
> > philosophically) cover, or only that it doesn't cover it at the moment,
> but
> > could do so?
>
> IMO, it's a philosoph
Could you provide an example proving this? I answered your question with
exactly how to split it up.
On Tue, Dec 1, 2015, 10:54 AM James Molloy wrote:
> You cannot test the intrinsic emission with the same quality when
> splitting the test in two. You miss testing the producer consumer
> relatio
tejohnson marked an inline comment as done.
tejohnson added a comment.
Updated patch coming shortly.
Comment at: lib/CodeGen/BackendUtil.cpp:308
@@ +307,3 @@
+return;
+ }
+
joker.eph wrote:
> It does not seem to be nicely integrated within the context of th
Hi,
FWIW, I'm happy with moving these tests into the test-suite. They do make
sense to be expressed in a compiler-neutral manner, even though some may
test clang-specific behaviour.
There is a UnitTests directory already, and adding the ability to run LIT
tests should be simple within the new CMa
Author: majnemer
Date: Tue Dec 1 13:13:51 2015
New Revision: 254439
URL: http://llvm.org/viewvc/llvm-project?rev=254439&view=rev
Log:
[MS ABI] Correctly mangle nullptr member pointers for variable templates
Variable templates behave the same as class templates with regard to
nullptr memeber poin
On Tue, Dec 1, 2015 at 10:45 AM Eric Christopher wrote:
> On Tue, Dec 1, 2015 at 10:43 AM James Molloy via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi,
>>
>> > That would sort of defeat the point of having the testing and projects
>> separated though - it would tie the tests togeth
tejohnson updated this revision to Diff 41542.
tejohnson added a comment.
- Address Mehdi's comments.
http://reviews.llvm.org/D15025
Files:
include/clang/CodeGen/CodeGenAction.h
include/clang/Driver/Options.td
include/clang/Driver/Types.h
include/clang/Frontend/CodeGenOptions.h
lib/Co
rjmccall added a comment.
I don't mean the actual layout used by Windows targets; I mean the layout used
by the ms_struct pragma / attribute.
Comment at: lib/AST/RecordLayoutBuilder.cpp:1606
@@ -1605,1 +1605,3 @@
+} else if (ExplicitFieldAlign)
+ FieldOffset = llvm::Ro
rjmccall added a comment.
Please feel free to commit after you make this last change.
Comment at: lib/CodeGen/TargetInfo.cpp:216
@@ +215,3 @@
+ }
+ else {
+Addr = Address(Ptr, SlotSize);
LLVM code style is to put the else on the same line as the closing b
On 1 December 2015 at 19:09, David Blaikie wrote:
> Not sure I follow - I'm not suggesting adding objdump/instruction checking
> to existing large programs in the test-suite, but adding other tests to the
> test-suite that do this and have appropriate input for it to be a
> reliable/useful form of
Hi Renato,
> by a non-trivial amount.
Why do you think it would be non trivial? Some simple lit tests aren't
exactly arduous on most targets.
James
On Tue, 1 Dec 2015 at 19:39, Renato Golin wrote:
> On 1 December 2015 at 19:09, David Blaikie wrote:
> > Not sure I follow - I'm not suggesting a
Author: d0k
Date: Tue Dec 1 13:42:07 2015
New Revision: 254446
URL: http://llvm.org/viewvc/llvm-project?rev=254446&view=rev
Log:
Avoid picking up system headers in unittest by providing a fake libstdc++ with
a ridiculously high version number.
The host libstdc++ may be horribly broken and we wa
On Tue, Dec 1, 2015 at 11:39 AM, Renato Golin
wrote:
> On 1 December 2015 at 19:09, David Blaikie wrote:
> > Not sure I follow - I'm not suggesting adding objdump/instruction
> checking
> > to existing large programs in the test-suite, but adding other tests to
> the
> > test-suite that do this
rjmccall added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2790
@@ -2790,1 +2789,3 @@
+ "version 4.4 - the newer offset is used here">,
+ InGroup>;
def warn_transparent_union_attribute_field_size_align : Warning<
No, this diagnostic
On 1 December 2015 at 19:42, James Molloy wrote:
> Why do you think it would be non trivial? Some simple lit tests aren't
> exactly arduous on most targets.
I mean having more points in the testing matrix.
Clang check-all is cheaper than running the test-suite, but if we
start moving more tests
Author: rafael
Date: Tue Dec 1 13:51:03 2015
New Revision: 254450
URL: http://llvm.org/viewvc/llvm-project?rev=254450&view=rev
Log:
Update for llvm api change.
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL:
http://llvm.org/viewvc/ll
Ok, understood.
I think I'd be OK with demoting these tests to the test-suite, and dealing
with the slightly lower amount of testing that comes with it if it means we
can keep the clang tests in a nice shape.
We'd need to ensure there were equivalent tests written that test only
clang produced IR
On 1 December 2015 at 19:45, David Blaikie wrote:
> These cases I don't understand - if they're features LLVM supports we'd just
> test them straight up. If you run our test suite against another compiler it
> should tell you if it's compatible with our compiler (does it offer the same
> functiona
On 1 December 2015 at 19:53, James Molloy wrote:
> I think I'd be OK with demoting these tests to the test-suite, and dealing
> with the slightly lower amount of testing that comes with it if it means we
> can keep the clang tests in a nice shape.
If the tests are independent of sub-architecture
Author: adrian
Date: Tue Dec 1 13:54:07 2015
New Revision: 254451
URL: http://llvm.org/viewvc/llvm-project?rev=254451&view=rev
Log:
Add an accessor to Decl::LoadedFieldsFromExternalStorage for LLDB.
Patch by Greg Clayton
Reviewed by Doug Gregor
Modified:
cfe/trunk/include/clang/AST/Decl.h
On 1 December 2015 at 10:42, James Molloy via cfe-commits
wrote:
> W.r.t the test-suite, that is a possibility. There are currently no
> codegen-filecheck tests in the test-suite but there seems to be no reason I
> can see why not. The disadvantage there for me is that we take short
> running, sim
carlo.bertolli created this revision.
carlo.bertolli added reviewers: hfinkel, ABataev, rjmccall.
carlo.bertolli added subscribers: sfantao, cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
This patch includes parsing and semantic analysis for 'omp distribute'
directiv
Author: adrian
Date: Tue Dec 1 14:19:44 2015
New Revision: 254455
URL: http://llvm.org/viewvc/llvm-project?rev=254455&view=rev
Log:
Clang-format an 80-column violation.
Modified:
cfe/trunk/include/clang/AST/Decl.h
Modified: cfe/trunk/include/clang/AST/Decl.h
URL:
http://llvm.org/viewvc/llv
probinson created this revision.
probinson added a reviewer: mkuper.
probinson added a subscriber: cfe-commits.
This more closely matches their locations as described by Intel documentation,
and lets us remove a pair of redundant typedefs.
http://reviews.llvm.org/D15127
Files:
lib/Headers/f16
probinson added a comment.
Patch posted as http://reviews.llvm.org/D15127. please follow up there.
Repository:
rL LLVM
http://reviews.llvm.org/D13015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
rizsotto.mailinglist marked 3 inline comments as done.
rizsotto.mailinglist added a comment.
updated comments before upload a new diff.
Comment at: tools/scan-build-py/MANIFEST.in:1
@@ +1,2 @@
+include README.md
+include *.txt
dcoughlin wrote:
> rizsotto.mailing
zaks.anna added a comment.
> An analysis of llvm+clang+compiler-rt now only generates 16 excessive padding
> reports in index.html.
Should those be fixed or are they all false positives?
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:48
@@ +47,3 @@
+// The cal
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:1844-1857
@@ -1843,4 +1843,16 @@
// Happens for function pointer type arguments for example.
-for (const QualType &Arg : Proto->param_types())
- mangleArgumentType(Arg, Range);
+for (unsigned
mclow.lists updated the summary for this revision.
mclow.lists updated this revision to Diff 41559.
mclow.lists added a comment.
Suggestions from @AaronBallman; now does the substitution correctly, and passes
the tests.
Note: The diagnostics that clang emits are still whacko.
http://reviews.ll
srhines commandeered this revision.
srhines added a reviewer: ADodds.
srhines added a comment.
Commandeering, since I am going to upload a version with the updated tests.
Repository:
rL LLVM
http://reviews.llvm.org/D14639
___
cfe-commits mailing
srhines updated this revision to Diff 41560.
srhines added a comment.
Update vector ABI for Android ARM targets.
Summary:
Looking into some recent issues with LLDB's expression parser highlighted that
upstream clang passes vector types differently than the Android Open Source
Project's clang for
Author: pcc
Date: Tue Dec 1 15:58:54 2015
New Revision: 254464
URL: http://llvm.org/viewvc/llvm-project?rev=254464&view=rev
Log:
docs: Add design documentation for forward-edge CFI for indirect calls.
Modified:
cfe/trunk/docs/ControlFlowIntegrityDesign.rst
Modified: cfe/trunk/docs/ControlFl
sgundapa created this revision.
sgundapa added reviewers: vkalintiris, echristo.
sgundapa added a subscriber: cfe-commits.
This patch is a fix to r252901 which changed the behavior of
clang driver. In the presence of "-nostdlib" none of the standard
libraries should be passed to link line.
http
Testcase?
> On 2015-Dec-01, at 14:58, Sumanth Gundapaneni via cfe-commits
> wrote:
>
> sgundapa created this revision.
> sgundapa added reviewers: vkalintiris, echristo.
> sgundapa added a subscriber: cfe-commits.
>
> This patch is a fix to r252901 which changed the behavior of
> clang driver
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
Testcase?
http://reviews.llvm.org/D15130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> On 2015-Dec-01, at 09:15, Aaron Ballman via cfe-commits
> wrote:
>
> Author: aaronballman
> Date: Tue Dec 1 11:15:13 2015
> New Revision: 254423
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254423&view=rev
> Log:
> It appears that this horrible mutating copy constructor is unused. Kill
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
OK, a couple of trivial changes then I think this is fine to commit.
Comment at: include/clang/Basic/AttrDocs.td:351-355
@@ +350,7 @@
+
+* Only one use of ``pass_object_size``
sgundapa updated this revision to Diff 41570.
sgundapa added a comment.
Added a few tests in this new patch set
http://reviews.llvm.org/D15130
Files:
lib/Driver/Tools.cpp
test/Driver/nostdlib.c
Index: test/Driver/nostdlib.c
==
On Tue, Dec 1, 2015 at 3:42 PM, Duncan P. N. Exon Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> > On 2015-Dec-01, at 09:15, Aaron Ballman via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
> > Author: aaronballman
> > Date: Tue Dec 1 11:15:13 2015
> > New Revision: 254423
LegalizeAdulthood added a subscriber: LegalizeAdulthood.
LegalizeAdulthood added a comment.
I'm wondering if there isn't an existing module that would be a good fit for
this check. Why not in the modernize module?
http://reviews.llvm.org/D15121
__
sgundapa updated this revision to Diff 41582.
http://reviews.llvm.org/D15130
Files:
lib/Driver/Tools.cpp
test/Driver/nostdlib.c
Index: test/Driver/nostdlib.c
===
--- test/Driver/nostdlib.c
+++ test/Driver/nostdlib.c
@@ -9,3 +9,1
jamesr updated this revision to Diff 41581.
jamesr added a comment.
Updates the macros to avoid defining anything if _LIBCPP_THREAD_ANNOTATION is
already defined and to define _LIBCPP_THREAD_ANNOTATION to nothing if __clang__
is not set, __has_attribute(acquire_capability) is not set, or
_LIBCP
jamesr added a comment.
In http://reviews.llvm.org/D14731#299152, @mclow.lists wrote:
> Where are the tests?
There aren't any yet. I investigated a few avenues for testing but none seem
very useful.
The most obvious testing strategy would be to write some code that fails the
-Wthread-safety
jamesr added a subscriber: aaron.ballman.
jamesr added a comment.
It looks like Aaron Ballman was involved with adding parsing for these
attributes in clang - perhaps he has an idea of a better way to detect these
than __has_attribute(acquire_capability).
http://reviews.llvm.org/D14731
Author: matze
Date: Tue Dec 1 19:12:06 2015
New Revision: 254477
URL: http://llvm.org/viewvc/llvm-project?rev=254477&view=rev
Log:
Force test to a target that supports thread_local
This should fix darwin bots.
Modified:
clang-tools-extra/trunk/test/clang-tidy/cert-static-object-exception.cp
rnk added a subscriber: rnk.
rnk added a comment.
Were these changes made to AOSP Clang to match upstream GCC, or some custom
Android version of GCC? Where would one go to find ground truth on how these
types should be passed?
http://reviews.llvm.org/D14639
_
rsmith added a comment.
In http://reviews.llvm.org/D15121#300033, @LegalizeAdulthood wrote:
> I'm wondering if there isn't an existing module that would be a good fit for
> this check. Why not in the modernize module?
This isn't really modernization, it's a bug fix. ADL has always been the ri
joker.eph added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:290
@@ +289,3 @@
+ // setup for LTO compiles invoked via the gold plugin and the llvm-lto tool.
+ if (!CodeGenOpts.ThinLTOIndexFile.empty() && !CodeGenOpts.DisableLLVMOpts) {
+legacy::PassManager *MPM =
srhines added a comment.
In http://reviews.llvm.org/D14639#300077, @rnk wrote:
> Were these changes made to AOSP Clang to match upstream GCC, or some custom
> Android version of GCC? Where would one go to find ground truth on how these
> types should be passed?
These changes are reverting to
Author: kcc
Date: Tue Dec 1 20:08:26 2015
New Revision: 254481
URL: http://llvm.org/viewvc/llvm-project?rev=254481&view=rev
Log:
[sanitizer coverage] document -fsanitize-coverage=trace-bb
Modified:
cfe/trunk/docs/SanitizerCoverage.rst
Modified: cfe/trunk/docs/SanitizerCoverage.rst
URL:
htt
Author: chapuni
Date: Tue Dec 1 21:13:50 2015
New Revision: 254485
URL: http://llvm.org/viewvc/llvm-project?rev=254485&view=rev
Log:
clang/test/Driver/crash-report-modules.m: Avoid using /tmp/.
Temporary directories should be controlled with $LIT_PRESERVES_TMP.
Modified:
cfe/trunk/test/Driv
mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.
Thanks Paul, LGTM.
http://reviews.llvm.org/D15127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
majnemer created this revision.
majnemer added a reviewer: rnk.
majnemer added a subscriber: cfe-commits.
majnemer added a dependency: D15139: [IR] Reformulate LLVM's EH funclet IR.
Depends on D15139.
http://reviews.llvm.org/D15140
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCleanup.cpp
li
martell added a comment.
@rnk you are correct.
mingw-w64 has been updated accordingly
http://sourceforge.net/p/mingw-w64/mingw-w64/ci/61c374ded91a7de66f42f85a9f0cf9ee20/
So where do we go from here ?
Kind Regards
Martell
http://reviews.llvm.org/D14180
___
98 matches
Mail list logo
