Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

2015-11-18 Thread Evgeniy Dushistov via cfe-commits
Dushistov marked an inline comment as done. Dushistov added a comment. > Should the leak be reported when the object is passed to > QApplication::postEvent? No, QApplication::postEvent == QCoreApplication::postEvent, it is just the same function, because of QApplication inherit from QCoreAppli

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

2015-11-18 Thread Alexey Bataev via cfe-commits
ABataev added a comment. John, any comments? http://reviews.llvm.org/D13336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

2015-11-18 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks! LGTM. I'll commit. http://reviews.llvm.org/D14170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D14779: Adding checker to detect excess padding in records

2015-11-18 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. This is a partial review. I did not look at the padding calculations closely. Have you run this over codebases other than clang? Are there any false positives? > Even with the default of 8, this checker is too noisy to justify turning on > by default. Clang+LLVM has

r253541 - Revert "Fix debian build after r253512."

2015-11-18 Thread Pete Cooper via cfe-commits
Author: pete Date: Wed Nov 18 23:55:44 2015 New Revision: 253541 URL: http://llvm.org/viewvc/llvm-project?rev=253541&view=rev Log: Revert "Fix debian build after r253512." This reverts commit r253519. This likely broke the bots in http://lab.llvm.org:8011/builders/clang-ppc64-elf-linux2/builds/2

Re: [PATCH] D14652: [analyzer] Improve modeling of static initializers.

2015-11-18 Thread Yury Gribov via cfe-commits
ygribov added inline comments. Comment at: test/Analysis/inline.cpp:308 @@ +307,3 @@ +clang_analyzer_eval(0 != void_string); // expected-warning{{TRUE}} +clang_analyzer_eval(0 != ((char *)void_string)[1]); // expected-warning{{TRUE}} + } zaks.anna wrote:

<    1   2