kfunk added inline comments.
Comment at: bindings/python/clang/cindex.py:1589
@@ +1588,3 @@
+def is_assignment(self):
+return BinaryOperator.Assign.value <= self.value <
BinaryOperator.Comma.value
+
TIL chaining comparisons in Python is OK... :)
I fi
berenm created this revision.
berenm added a reviewer: djasper.
berenm added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This fixes bug #25329, as well as misalignments like the following:
int a, b = 2;
int c= 3;
http://reviews.llvm.org/D14325
Files:
lib/Format/W
Author: angelgarcia
Date: Wed Nov 4 04:27:51 2015
New Revision: 252041
URL: http://llvm.org/viewvc/llvm-project?rev=252041&view=rev
Log:
Improve modernize-make-unique matcher.
Summary: "std::unique_ptr" is not the same type as "std::unique_ptr>", unless we insert a "hasCanonicalType" in the
mid
a.sidorin created this revision.
a.sidorin added a reviewer: sepavloff.
a.sidorin added a subscriber: cfe-commits.
a.sidorin set the repository for this revision to rL LLVM.
This patch implements some expression-related AST node import (patch #2).
Supported nodes:
ArrayTypeTraitExpr
ExpressionTra
RedX2501 marked 2 inline comments as done.
Comment at: bindings/python/tests/cindex/test_cursor.py:333
@@ +332,3 @@
+# not exposed yet
+# ".*" : BinaryOperator.PtrMemD,
+"->*" : BinaryOperator.PtrMemI,
kfunk wrote:
> What about this? How is
RedX2501 updated this revision to Diff 39176.
RedX2501 added a comment.
Changed points raised during review.
http://reviews.llvm.org/D10833
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_cursor.py
include/clang-c/Index.h
include/clang/AST/OperationKinds.h
tes
rengolin added a comment.
Hi Asiri,
Can I propose a different approach?
We now have a silent buildbot, which will never email people about breakages,
but can be publicly monitored by you, me and others. I'm assuming you have
access to at least one x86 and one ARM machines, so that you could se
erikjv added a comment.
GCC doesn't define this, but icc does. Just like e.g. __AVX512CD__, it can be
used to conditionally enable code that uses the instruction as a fast
implementation for an algorithm.
http://reviews.llvm.org/D11752
___
cfe-com
erikjv created this revision.
erikjv added a reviewer: klimek.
erikjv added a subscriber: cfe-commits.
When reparsing a translation unit with preamble generation turned on,
no includes are found. This is due to the fact that all SLocs from
AST/PCH files are skipped as they are 'loaded', and inclus
rmaprath added a comment.
In http://reviews.llvm.org/D14293#280982, @rengolin wrote:
> Hi Asiri,
>
> Can I propose a different approach?
>
> We now have a silent buildbot, which will never email people about breakages,
> but can be publicly monitored by you, me and others. I'm assuming you have
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
http://reviews.llvm.org/D14316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: erikjv
Date: Wed Nov 4 08:34:43 2015
New Revision: 252045
URL: http://llvm.org/viewvc/llvm-project?rev=252045&view=rev
Log:
Initialize member field.
Modified:
cfe/trunk/include/clang/Frontend/FrontendOptions.h
Modified: cfe/trunk/include/clang/Frontend/FrontendOptions.h
URL:
http:/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I would like to see one more test, just to make sure that a Var subject doesn't
also allow it on a parameter:
void f(int a [[clang::internal_linkage]]);
Aside from that, LGTM!
Author: aaronballman
Date: Wed Nov 4 08:43:43 2015
New Revision: 252047
URL: http://llvm.org/viewvc/llvm-project?rev=252047&view=rev
Log:
Silence "enumeral and non-enumeral type in conditional expression" warning; NFC.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/
a.sidorin updated this revision to Diff 39198.
a.sidorin added a comment.
Thank you for you reply!
This version contains more radical solution. Also, I took an another look at
the CStringChecker and its way of handling checkDeadSymbols.
Repository:
rL LLVM
http://reviews.llvm.org/D14277
Fi
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Core/SymbolManager.cpp:457
@@ -461,6 +456,3 @@
case SymExpr::MetadataKind:
-KnownLive = MetadataInUse.count(sym) &&
-isLiveRegion(cast(sym)->getRegion());
-if (KnownLive)
- MetadataInUs
berenm updated this revision to Diff 39201.
berenm added a comment.
[clang-format] Count the number of braces and parens on the line instead of
remembering only one.
http://reviews.llvm.org/D14325
Files:
lib/Format/WhitespaceManager.cpp
unittests/Format/FormatTest.cpp
Index: unittests/For
berenm added a comment.
I've also added a fix for the other issue reported on the same bug. I could
split the two reviews if necessary.
http://reviews.llvm.org/D14325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
djasper added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:163-171
@@ -162,9 +162,11 @@
unsigned MinColumn = 0;
unsigned MaxColumn = UINT_MAX;
unsigned StartOfSequence = 0;
unsigned EndOfSequence = 0;
bool FoundAssignmentOnLine = false;
- bool Fo
junbuml added a comment.
If we want to add a check for CallSites in EHRs in inliner, we may be able to
borrow things done in BranchProbabilityInfo::calcColdCallHeuristics, but for
exception handing intrinsics, not for cold, and make getInlineThreshold()
return a lower threshold so that we can
Author: scanon
Date: Wed Nov 4 09:25:38 2015
New Revision: 252050
URL: http://llvm.org/viewvc/llvm-project?rev=252050&view=rev
Log:
Allow compound assignment expressions to be contracted when licensed by the
language or pragma.
Modified:
cfe/trunk/lib/CodeGen/CGExprScalar.cpp
Modified: cfe
scanon updated this revision to Diff 39205.
scanon added a comment.
Additionally test contraction of compound assignment expressions.
http://reviews.llvm.org/D14200
Files:
include/clang/Basic/LangOptions.def
lib/Frontend/CompilerInvocation.cpp
test/CodeGen/aarch64-neon-fma.c
test/CodeGe
Author: aaronballman
Date: Wed Nov 4 10:09:04 2015
New Revision: 252055
URL: http://llvm.org/viewvc/llvm-project?rev=252055&view=rev
Log:
Improving the diagnostic for cases where the attribute only appertains to a
function with a prototype.
Modified:
cfe/trunk/include/clang/Basic/Attr.td
On Fri, Oct 9, 2015 at 10:37 AM, Aaron Ballman wrote:
> On Fri, Oct 9, 2015 at 8:53 AM, Aaron Ballman wrote:
>> On Thu, Oct 8, 2015 at 6:10 PM, Richard Smith wrote:
>>> On Thu, Oct 8, 2015 at 2:59 PM, Adrian Zgorzalek wrote:
Same story:
warning: 'ownership_takes' attribute only
Author: hans
Date: Wed Nov 4 10:11:56 2015
New Revision: 252056
URL: http://llvm.org/viewvc/llvm-project?rev=252056&view=rev
Log:
clang-cl: Parse the /guard:cf[-] flag (PR25400)
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/
jroelofs added a comment.
> Counter proposal, we mark all the currently failing (-fno-exceptions) test
> cases with:
>
> // XFAIL: libcpp-no-exceptions
>
>
> This has the following advantages:
>
> - No need to change buildbots to skip tests
> - The bots will catch any regressions
rengolin added a comment.
In http://reviews.llvm.org/D14293#281176, @jroelofs wrote:
> I think this ^ is a reasonable solution.
I'm fine with that, as long as everyone's happy.
160 XFAILs are ok (as long as you're fixing them), disabling the tests makes no
sense. :)
cheers,
--renato
http:/
rmaprath added a comment.
In http://reviews.llvm.org/D14293#281183, @rengolin wrote:
> In http://reviews.llvm.org/D14293#281176, @jroelofs wrote:
>
> > I think this ^ is a reasonable solution.
>
>
> I'm fine with that, as long as everyone's happy.
>
> 160 XFAILs are ok (as long as you're fixing t
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lib/Sema/SemaDecl.cpp:5374
@@ +5373,3 @@
+
+ // Virtual functions cannot be marked as 'notail'.
+ if (auto *Attr = ND.getAttr())
craig.topper added a comment.
Does icc have an intrinsic for it?
http://reviews.llvm.org/D11752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nwilson
Date: Wed Nov 4 12:18:35 2015
New Revision: 252061
URL: http://llvm.org/viewvc/llvm-project?rev=252061&view=rev
Log:
[Concepts] Add diagnostics which fall under [dcl.spec.concept]p1
Summary: Diagnose when the 'concept' specifier is used on a typedef or function
parameter.
Revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252061: [Concepts] Add diagnostics which fall under
[dcl.spec.concept]p1 (authored by nwilson).
Changed prior to commit:
http://reviews.llvm.org/D14316?vs=39151&id=39215#toc
Repository:
rL LLVM
http
eugenis added a comment.
Hi Eric,
could you please clarify what exactly you are looking for here?
Repository:
rL LLVM
http://reviews.llvm.org/D10677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
rsmith accepted this commit.
Users:
ismailp (Author)
rsmith (Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
http://reviews.llvm.org/rL251335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
rsmith accepted this commit.
Users:
dim (Author)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
joerg (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL250657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
rsmith accepted this commit.
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL248426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
rsmith accepted this commit.
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL248379
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
rsmith accepted this commit.
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL248424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
yaron.keren accepted this revision.
yaron.keren added a reviewer: yaron.keren.
yaron.keren added a comment.
This revision is now accepted and ready to land.
The formatting is wrong, aligned to the right, clang-format the new code.
Can we control getInstalledDir() when running under LIT so this co
zaks.anna added a comment.
See the comment below, otherwise, LGTM.
Comment at: lib/StaticAnalyzer/Checkers/Checkers.td:23
@@ +22,3 @@
+
+def OptIn : Package<"optin">;
+
Please, add a comment describing for how this package should be used as you do
in the commit
rsmith added a subscriber: rsmith.
rsmith raised a concern with this commit.
/cfe/trunk/lib/CodeGen/CGAtomic.cpp:941-943 According to the GCC documentation
for libatomic:
> for i = __atomic_add_fetch (ptr, j, model) the code generated will be
>
>tmp = __atomic_fetch_add (ptr, j, model);
rsmith added inline comments.
Comment at: test/CodeGenCXX/attribute_internal_linkage.cpp:34-35
@@ +33,4 @@
+
+__attribute__((internal_linkage)) void A::f3() {
+}
+
We should reject this. We're just causing problems for ourselves if we allow
the linkage to change
eugenis added a comment.
Hm, the current implementation allows all of the following:
void f(int a [[clang::internal_linkage]]) { // 1
int b [[clang::internal_linkage]]; // 2
static int c [[clang::internal_linkage]]; // 3
}
I'll fix (1). Is it OK to allow (2) and (3)? The attribute has
zaks.anna added a comment.
Test cases need to be small and self contained.
You might be having a problem with reproducing with a simple test case, where
you define QCoreApplication::postEvent in the test file because it is not
considered to be in the system header. You can use special pragmas
The control expression for a _Generic selection expression should have
its type decayed and qualifiers stripped when determining which
selection it matches. e.g., the following should compile:
_Generic("test", char *: 1);
const int i = 12;
_Generic(i, int: 1);
This patch fixes PR16340.
~Aa
On Wed, Nov 4, 2015 at 2:20 PM, Evgeniy Stepanov wrote:
> eugenis added a comment.
>
> Hm, the current implementation allows all of the following:
>
> void f(int a [[clang::internal_linkage]]) { // 1
>
> int b [[clang::internal_linkage]]; // 2
> static int c [[clang::internal_linkage]]; //
Author: rsmith
Date: Wed Nov 4 13:26:32 2015
New Revision: 252063
URL: http://llvm.org/viewvc/llvm-project?rev=252063&view=rev
Log:
[modules] Generalize the workaround for multiple ambiguous definitions of
internal linkage entities in different modules from r250884 to apply to all
names, not just
dcoughlin created this revision.
dcoughlin added reviewers: zaks.anna, krememek.
dcoughlin added a subscriber: cfe-commits.
Currently the SATestBuild.py and SATestAdd.py buildbot scripts expect project
sources to be checked into the project repository. This patch changes these
scripts to additiona
berenm updated this revision to Diff 39232.
berenm added a comment.
[clang-format] Alignment code factorization.
http://reviews.llvm.org/D14325
Files:
lib/Format/WhitespaceManager.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
===
Author: alexfh
Date: Wed Nov 4 13:34:55 2015
New Revision: 252066
URL: http://llvm.org/viewvc/llvm-project?rev=252066&view=rev
Log:
Removed mentions of clang-modernize, added a short description of clang-tidy.
Modified:
cfe/trunk/docs/ClangTools.rst
Modified: cfe/trunk/docs/ClangTools.rst
U
jyknight added inline comments.
/cfe/trunk/lib/CodeGen/CGAtomic.cpp:941-943 Looks like GCC's behavior does
actually follow that spec.
I'm not sure why the library exposes these entry-points when you're not
supposed to use them. Oop. Sorry that I failed to notice that.
Users:
jyknight (Author
On Wed, Nov 4, 2015 at 11:36 AM, James Y Knight via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> jyknight added inline comments.
>
> /cfe/trunk/lib/CodeGen/CGAtomic.cpp:941-943 Looks like GCC's behavior does
> actually follow that spec.
>
> I'm not sure why the library exposes these entry-po
berenm updated this revision to Diff 39233.
berenm added a comment.
[clang-format] Remove deleted methods declaration.
http://reviews.llvm.org/D14325
Files:
lib/Format/WhitespaceManager.cpp
lib/Format/WhitespaceManager.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.
rnk added a comment.
This is an interesting test case, though:
inline int foo() {
static int __attribute__((internal_linkage)) x;
return x++;
}
If foo gets inlined, those call sites will use and update 'x'. If foo is not
inlined, one definition of foo will win, and every caller will
Author: alexfh
Date: Wed Nov 4 13:40:05 2015
New Revision: 252068
URL: http://llvm.org/viewvc/llvm-project?rev=252068&view=rev
Log:
Fixed header levels.
Modified:
cfe/trunk/docs/ClangTools.rst
Modified: cfe/trunk/docs/ClangTools.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/C
Author: alexfh
Date: Wed Nov 4 13:42:17 2015
New Revision: 252069
URL: http://llvm.org/viewvc/llvm-project?rev=252069&view=rev
Log:
Fixed a link.
Modified:
cfe/trunk/docs/ClangTools.rst
Modified: cfe/trunk/docs/ClangTools.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ClangToo
aaron.ballman added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:376
@@ -375,3 +375,3 @@
/// \brief Parse an expression statement.
StmtResult Parser::ParseExprStatement() {
// If a case keyword is missing, this is where it should be inserted.
> I don'
zaks.anna added a comment.
> > What is needed to turn this into a non-alpha checker?
>
>
> I guess that's question for maintainers) We have to consider that vfork is
> used rarely enough.
Please, make this into a non-alpha, turned on by default.
Thank you!
Anna.
http://reviews.llvm.org/
xazax.hun added a comment.
Hi!
I think it is great to support this model in these scripts. Do you plan to
check the list of the project urls in to the repository as well? I think it
would be great to do so, so one can easily reproduce a buildbot error locally,
or even run the whole testsuit. I
ahatanak added a comment.
Thanks, I'll see how the review for the llvm-side patch goes and commit both
patches after it is approved.
http://reviews.llvm.org/D12922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
eugenis added a comment.
How do I check if a Var is a local variable?
Comment at: test/CodeGenCXX/attribute_internal_linkage.cpp:35-36
@@ +34,4 @@
+__attribute__((internal_linkage)) void A::f3() {
+}
+
+// Forward declaration w/o an attribute.
OK, done. Still al
eugenis updated this revision to Diff 39245.
Repository:
rL LLVM
http://reviews.llvm.org/D13925
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/AST/Decl.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/
On Sun, Nov 1, 2015 at 10:20 AM, Manuel Klimek wrote:
> On Fri, Oct 23, 2015 at 9:31 PM Sean Silva wrote:
>
>> On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek wrote:
>>
>>> On Tue, Oct 20, 2015 at 10:41 AM Sean Silva
>>> wrote:
>>>
On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek
wrote
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D14311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
eugenis updated this revision to Diff 39249.
Repository:
rL LLVM
http://reviews.llvm.org/D13925
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/AST/Decl.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/
eugenis added a comment.
In http://reviews.llvm.org/D13925#281349, @eugenis wrote:
> Hm, the current implementation allows all of the following:
>
> void f(int a [[clang::internal_linkage]]) { // 1
>
> int b [[clang::internal_linkage]]; // 2
> static int c [[clang::internal_linkage]]; //
dcoughlin marked an inline comment as done.
dcoughlin added a comment.
http://reviews.llvm.org/D14303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dcoughlin
Date: Wed Nov 4 15:33:41 2015
New Revision: 252080
URL: http://llvm.org/viewvc/llvm-project?rev=252080&view=rev
Log:
[analyzer] Add 'optin' checker package and move localizability checkers into it.
This commit creates a new 'optin' top-level checker package and moves several of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252080: [analyzer] Add 'optin' checker package and move
localizability checkers into it. (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D14303?vs=39102&id=39251#toc
Repositor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252081: Fix some Clang-tidy modernize warnings, other minor
fixes. (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D14311?vs=39134&id=39252#toc
Repository:
rL LLVM
http
Author: eugenezelenko
Date: Wed Nov 4 15:37:17 2015
New Revision: 252081
URL: http://llvm.org/viewvc/llvm-project?rev=252081&view=rev
Log:
Fix some Clang-tidy modernize warnings, other minor fixes.
Differential revision: http://reviews.llvm.org/D14311
Modified:
cfe/trunk/lib/AST/ASTContext.
dcoughlin added a comment.
In http://reviews.llvm.org/D14345#281475, @xazax.hun wrote:
> Hi!
>
> I think it is great to support this model in these scripts. Do you plan to
> check the list of the project urls in to the repository as well?
The project URLs are implicitly included in the downloa
alexfh added a comment.
Ping.
http://reviews.llvm.org/D14191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
Ping.
http://reviews.llvm.org/D14192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer created this revision.
majnemer added a reviewer: rsmith.
majnemer added a subscriber: cfe-commits.
http://reviews.llvm.org/D14349
Files:
lib/Lex/PPMacroExpansion.cpp
test/SemaCXX/make_integer_seq.cpp
Index: test/SemaCXX/make_integer_seq.cpp
=
It'd be simpler and would more directly match the C specification (and
would handle a few other cases better, such as placeholder types and atomic
types) if you instead passed the operand through DefaultLvalueConversion
rather than matching against the decayed form of the type.
On Wed, Nov 4, 2015
On Wed, Nov 4, 2015 at 2:45 PM, Richard Smith wrote:
> It'd be simpler and would more directly match the C specification (and
> would handle a few other cases better, such as placeholder types and atomic
> types) if you instead passed the operand through DefaultLvalueConversion
>
or rather, Defa
Author: djasper
Date: Wed Nov 4 16:49:32 2015
New Revision: 252089
URL: http://llvm.org/viewvc/llvm-project?rev=252089&view=rev
Log:
clang-format: Turn on wrapping before "else" for WebKit style.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL:
http:
djasper added a comment.
I like it :-)
Comment at: lib/Format/WhitespaceManager.cpp:151
@@ -150,13 +150,3 @@
-// Walk through all of the changes and find sequences of "=" to align. To do
-// so, keep track of the lines and whether or not an "=" was found on align. If
-// a "=
nwilson created this revision.
nwilson added reviewers: rsmith, faisalv, hubert.reinterpretcast, aaron.ballman.
nwilson added a subscriber: cfe-commits.
Diagnose when a function concept declaration has parameter(s)
http://reviews.llvm.org/D14352
Files:
include/clang/Basic/DiagnosticSemaKinds.t
dim added a subscriber: dim.
dim added auditors: 3.7-release, cfe-commits, tstellarAMD, hfinkel.
dim added a comment.
This got reported again in PR25397, and occurs during compilation of mpich.
Looks like a good candidate for 3.7.1.
Users:
hfinkel (Author, Auditor)
3.7-release (Auditor)
berenm marked an inline comment as done.
Comment at: lib/Format/WhitespaceManager.cpp:150-151
@@ -149,109 +149,4 @@
}
-// Walk through all of the changes and find sequences of "=" to align. To do
-// so, keep track of the lines and whether or not an "=" was found on align. If
ping
On Fri, Oct 16, 2015 at 2:51 PM, Akira Hatanaka wrote:
> ahatanak created this revision.
> ahatanak added a subscriber: cfe-commits.
>
> clang doesn't print a very user-friendly message when an invalid register
> is used for a global register variable:
>
> For example, when the following co
rnk added a comment.
> ! In http://reviews.llvm.org/D14180#280193, @martell wrote:
>
> > You can then change the mingw headers to use
> > `__has_builtin(_InterlockedCompareExchange)` to provide compatibility with
> > either mode.
>
>
> Yes I could do this but this still won't work with t
hubert.reinterpretcast added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7575
@@ +7574,3 @@
+// following restrictions:
+// — The declaration’s parameter list shall be equivalent to an empty
+// parameter list.
I think the U+2014 s
klimek created this revision.
klimek added a reviewer: rsmith.
klimek added a subscriber: cfe-commits.
http://reviews.llvm.org/D14353
Files:
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/private3/private.h
test/Modules/Inputs/private3/public.h
test/Modules/private.modulemap
Index: test/Modul
hubert.reinterpretcast added inline comments.
Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.spec.concept/p5.cpp:7
@@ +6,2 @@
+template
+concept bool fcpi(int i = 0) { return true; } // expected-error {{function
concept cannot have any parameters}}
hubert.
Dushistov updated this revision to Diff 39265.
Dushistov added a comment.
Fix line length issue
http://reviews.llvm.org/D14170
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/Inputs/qt-simulator.h
test/Analysis/qt_malloc.cpp
Index: test/Analysis/qt_malloc.cpp
=
Dushistov updated this revision to Diff 39264.
Dushistov added a comment.
I reduce testcase to almost minimal variant.
http://reviews.llvm.org/D14170
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/Inputs/qt-simulator.h
test/Analysis/qt_malloc.cpp
Index: test/Analysis/
tberghammer created this revision.
tberghammer added a reviewer: echristo.
tberghammer added a subscriber: cfe-commits.
Add new compiler flag to enable the generation of dwarf accelerator tables
The dwarf accelerator tables already generated on darwin platforms. This CL
ands a new flag to clang
On Wed, Nov 4, 2015 at 5:46 PM, Richard Smith wrote:
> On Wed, Nov 4, 2015 at 2:45 PM, Richard Smith wrote:
>>
>> It'd be simpler and would more directly match the C specification (and
>> would handle a few other cases better, such as placeholder types and atomic
>> types) if you instead passed t
LGTM, thanks!
On Wed, Nov 4, 2015 at 4:00 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Wed, Nov 4, 2015 at 5:46 PM, Richard Smith
> wrote:
> > On Wed, Nov 4, 2015 at 2:45 PM, Richard Smith
> wrote:
> >>
> >> It'd be simpler and would more directly match the C spec
Author: aaronballman
Date: Wed Nov 4 18:06:05 2015
New Revision: 252104
URL: http://llvm.org/viewvc/llvm-project?rev=252104&view=rev
Log:
The control expression for a _Generic selection expression should have
its type decayed and qualifiers stripped when determining which
selection it matches. Fi
rsmith added inline comments.
Comment at: lib/Lex/ModuleMap.cpp:235-237
@@ -234,5 +234,1 @@
return IsPrivateRole &&
- // FIXME: Should we map RequestingModule to its top-level module here
- //too? This check is redundant with the isSubModuleOf check in
-
Thanks! Commit in r252104.
~Aaron
On Wed, Nov 4, 2015 at 7:05 PM, Richard Smith wrote:
> LGTM, thanks!
>
> On Wed, Nov 4, 2015 at 4:00 PM, Aaron Ballman via cfe-commits
> wrote:
>>
>> On Wed, Nov 4, 2015 at 5:46 PM, Richard Smith
>> wrote:
>> > On Wed, Nov 4, 2015 at 2:45 PM, Richard Smith
>>
klimek updated this revision to Diff 39287.
klimek added a comment.
Remove unnecessary if and fix segfault.
http://reviews.llvm.org/D14353
Files:
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/private3/private.h
test/Modules/Inputs/private3/public.h
test/Modules/private.modulemap
Index: tes
klimek marked 2 inline comments as done.
klimek added a comment.
Addressed comments.
http://reviews.llvm.org/D14353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson created this revision.
probinson added reviewers: echristo, dblaikie, aprantl.
probinson added a subscriber: cfe-commits.
We were forgetting the template parameters on the forward declaration of a
template class.
http://reviews.llvm.org/D14358
Files:
lib/CodeGen/CGDebugInfo.cpp
t
Author: rnk
Date: Wed Nov 4 18:24:01 2015
New Revision: 252107
URL: http://llvm.org/viewvc/llvm-project?rev=252107&view=rev
Log:
Fix nullptr crash in -Wthread-safety-beta
Modified:
cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyCommon.h
cfe/trunk/test/SemaCXX/warn-thread-safety-an
probinson added a comment.
In debug-info-template-member.cpp, some things came out in a different order;
that's the only change there.
http://reviews.llvm.org/D14358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
1 - 100 of 123 matches
Mail list logo
