> On Oct 19, 2015, at 4:40 PM, Michael Gottesman via cfe-commits
> wrote:
>
>>
>> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits
>> wrote:
>>
>> Author: d0k
>> Date: Thu Oct 15 10:29:40 2015
>> New Revision: 250418
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=250418&vie
Is it possible to add a unittest that exercises this extension point
in-tree? For example the way I did for AA extension hooks?
On Mon, Oct 19, 2015 at 9:00 PM Michael Gottesman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Oct 19, 2015, at 4:40 PM, Michael Gottesman via cfe-commits <
Let me play with it a bit (I did not read the code, I just was tracking down
the linkage error).
Michael
> On Oct 20, 2015, at 12:07 AM, Chandler Carruth wrote:
>
> Is it possible to add a unittest that exercises this extension point in-tree?
> For example the way I did for AA extension hooks
Author: marshall
Date: Tue Oct 20 02:37:11 2015
New Revision: 250802
URL: http://llvm.org/viewvc/llvm-project?rev=250802&view=rev
Log:
Detect relaxed constexpr rules for gcc versions
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/
Author: d0k
Date: Tue Oct 20 02:50:21 2015
New Revision: 250803
URL: http://llvm.org/viewvc/llvm-project?rev=250803&view=rev
Log:
Put back dead code that's used out-of-tree.
Partially reverts r250418.
Modified:
cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp
cfe/trunk/lib/Tooling/Core/CMakeLis
Author: d0k
Date: Tue Oct 20 02:53:14 2015
New Revision: 250804
URL: http://llvm.org/viewvc/llvm-project?rev=250804&view=rev
Log:
Revert accidental commit. This isn't ready yet.
Modified:
cfe/trunk/lib/Tooling/Core/CMakeLists.txt
cfe/trunk/unittests/Tooling/CMakeLists.txt
Modified: cfe/t
Put it back in r250803. Tests very welcome ;)
- Benjamin
On Tue, Oct 20, 2015 at 9:14 AM, Michael Gottesman via cfe-commits
wrote:
> Let me play with it a bit (I did not read the code, I just was tracking down
> the linkage error).
>
> Michael
>
> On Oct 20, 2015, at 12:07 AM, Chandler Carruth
Thanks!
Michael
> On Oct 20, 2015, at 12:55 AM, Benjamin Kramer wrote:
>
> Put it back in r250803. Tests very welcome ;)
>
> - Benjamin
>
> On Tue, Oct 20, 2015 at 9:14 AM, Michael Gottesman via cfe-commits
> wrote:
>> Let me play with it a bit (I did not read the code, I just was tracking d
curdeius updated this revision to Diff 37832.
curdeius added a comment.
- AllowShortFunctionsOnASingleLine: true didn't work with BreakBeforeBraces:
Linux/Allman.
- Add test checking that non-empty functions in styles with
`BraceWrapping.AfterFunction = true` don't get merged into one line. Fix
curdeius marked 2 inline comments as done.
curdeius added a comment.
Applied comments.
Comment at: lib/Format/UnwrappedLineFormatter.cpp:190
@@ +189,3 @@
+(Style.AllowShortFunctionsOnASingleLine >= FormatStyle::SFS_Empty) &&
+(((Style.BraceWrapping.AfterFunction
angelgarcia updated this revision to Diff 37833.
angelgarcia added a comment.
Global variable -> static, and a few other additions.
> Will be good idea to add handling of cases where default constructor is empty
> and only call base class(es) default constructor/members default constructors
I
On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek wrote:
>
>> On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva
>>> wrote:
>>>
On Fri, Oct
On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek wrote:
> On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
>
>> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek wrote:
>>
>>> On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>>>
On Fri, Oct
On Tue, Oct 20, 2015 at 10:41 AM Sean Silva wrote:
> On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek wrote:
>
>> On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
>>
>>> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek
>>> wrote:
>>>
On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-comm
vkalintiris updated this revision to Diff 37850.
vkalintiris marked 6 inline comments as done.
vkalintiris added a comment.
Sorry for the delay.
Addressed reviewer comments and modifed CMake to check that
LIBCXX_INSTALL_SUPPORT_HEADERS is not turned off when LIBCXX_LIBC_IS_MUSL is ON.
http://re
Author: adibiagio
Date: Tue Oct 20 06:19:54 2015
New Revision: 250816
URL: http://llvm.org/viewvc/llvm-project?rev=250816&view=rev
Log:
[x86] Fix maskload/store intrinsic definitions in avxintrin.h
According to the Intel documentation, the mask operand of a maskload and
maskstore intrinsics is al
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250816: [x86] Fix maskload/store intrinsic definitions in
avxintrin.h (authored by adibiagio).
Changed prior to commit:
http://reviews.llvm.org/D13861?vs=37741&id=37852#toc
Repository:
rL LLVM
http:
andreadb added a comment.
In http://reviews.llvm.org/D13861#270811, @delena wrote:
> LGTM
Thanks Elena!
Committed revision250816.
Repository:
rL LLVM
http://reviews.llvm.org/D13861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
ABataev updated this revision to Diff 37854.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D13336
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/Serialization/ASTBitCodes.h
lib/AST/ASTContext.cpp
lib/AST/Type.cpp
lib/AST
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. Yay!
Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:59-60
@@ +58,4 @@
+ "= default;");
+ // FIXME: this can generate a -Wpedantic warning if there is a sem
angelgarcia updated this revision to Diff 37859.
angelgarcia added a comment.
Remove the fixme.
http://reviews.llvm.org/D13871
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseDefaultCheck.cpp
clang-tidy/modernize/UseDefault
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
Replace empty bodies of default constructors and destructors with '= default'.
http://reviews.llvm.org/D13889
Files:
clang-modernize/Core/IncludeDirectives.cpp
clang-m
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
Herald added a subscriber: klimek.
Replace empty bodies of default constructors and destructors with '= default'.
http://reviews.llvm.org/D13890
Files:
include/clang/AST
klimek added a reviewer: bkramer.
klimek added a comment.
+benjamin, who has been doing those changes lately...
http://reviews.llvm.org/D13890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
klimek added a reviewer: bkramer.
klimek added a comment.
+benjamin, who has been doing those changes lately...
http://reviews.llvm.org/D13891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
Replace empty bodies of default constructors and destructors with '= default'.
http://reviews.llvm.org/D13892
Files:
lib/asan/asan_fake_stack.h
lib/msan/msan_allocator
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D13889
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Looks good with one comment.
Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:141-143
@@ -140,5 +141,1 @@
-MemRegionManager::~MemRegionManager() {
- // All regions and the
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg with comments.
Comment at: lib/tsan/rtl/tsan_mutex.cc:130
@@ -129,3 @@
-InternalDeadlockDetector::InternalDeadlockDetector() {
- // Rely on zero initialization because s
angelgarcia updated this revision to Diff 37867.
angelgarcia added a comment.
Put comment back.
http://reviews.llvm.org/D13890
Files:
include/clang/AST/ASTConsumer.h
include/clang/AST/CanonicalType.h
include/clang/AST/DeclFriend.h
include/clang/AST/DeclTemplate.h
include/clang/AST/Exp
bkramer added a comment.
feel free to submit
http://reviews.llvm.org/D13890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
angelgarcia updated this revision to Diff 37868.
angelgarcia added a comment.
Put comments back.
http://reviews.llvm.org/D13892
Files:
lib/asan/asan_fake_stack.h
lib/msan/msan_allocator.h
lib/sanitizer_common/sanitizer_bitvector.h
lib/tsan/rtl/tsan_clock.h
lib/tsan/rtl/tsan_mutex.cc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250823: Apply modernize-use-default to compiler-rt.
(authored by angelgarcia).
Changed prior to commit:
http://reviews.llvm.org/D13892?vs=37868&id=37869#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: angelgarcia
Date: Tue Oct 20 07:56:27 2015
New Revision: 250824
URL: http://llvm.org/viewvc/llvm-project?rev=250824&view=rev
Log:
Apply modernize-use-default to clang-tools-extra.
Summary: Replace empty bodies of default constructors and destructors with '=
default'.
Reviewers: klimek
angelgarcia created this revision.
angelgarcia added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
It breaks the build for the ASTMatchers
http://reviews.llvm.org/D13893
Files:
include/clang/AST/ASTConsumer.h
include/clang/AST/CanonicalType.h
include/clang/AST/DeclFriend.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250827: Roll-back r250822. (authored by angelgarcia).
Changed prior to commit:
http://reviews.llvm.org/D13893?vs=37875&id=37878#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13893
Files:
cfe/tr
On 10/20/2015 04:38 AM, Manuel Klimek wrote:
> On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
>> get cmake to generate clang module map files and add explicit module build
>> steps?
>
> I have some experience hacking on cmake, and from my experience I think
> this shouldn't be too hard to get
On Tue, Oct 20, 2015 at 3:38 PM Brad King wrote:
> On 10/20/2015 04:38 AM, Manuel Klimek wrote:
> > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
> >> get cmake to generate clang module map files and add explicit module
> build steps?
> >
> > I have some experience hacking on cmake, and from
vkalintiris added inline comments.
Comment at: src/locale.cpp:958
@@ -957,3 +961,3 @@
return static_cast(__classic_lower_table()[static_cast(c)]);
-#elif defined(__GLIBC__) || defined(__EMSCRIPTEN__) || defined(__NetBSD__)
return isascii(c) ?
EricWF wrot
bkramer created this revision.
bkramer added reviewers: klimek, sbenza.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Firstly this changes the type of parent map to be keyed on DynTypedNode to
simplify the following changes. This comes with a DenseMapInfo for
DynTyped
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Yay, another yak shaved \o/
http://reviews.llvm.org/D13897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: d0k
Date: Tue Oct 20 10:08:46 2015
New Revision: 250831
URL: http://llvm.org/viewvc/llvm-project?rev=250831&view=rev
Log:
[AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap.
Firstly this changes the type of parent map to be keyed on DynTypedNode to
simplify the following ch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250831: [AST] Put TypeLocs and NestedNameSpecifierLocs into
the ParentMap. (authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D13897?vs=37882&id=37884#toc
Repository:
rL LLVM
http:/
sbenza created this revision.
sbenza added reviewers: alexfh, aaron.ballman.
sbenza added a subscriber: cfe-commits.
Fix bug in suggested fix that truncated variable names to 1 character.
Also, rework the suggested fix to try to remove unnecessary whitespace.
http://reviews.llvm.org/D13899
Files
On Mon, Oct 19, 2015 at 6:00 PM, David Blaikie wrote:
>
>
> On Mon, Oct 19, 2015 at 2:49 PM, Samuel Benzaquen via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: sbenza
>> Date: Mon Oct 19 16:49:51 2015
>> New Revision: 250742
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=250
Author: cbieneman
Date: Tue Oct 20 11:39:25 2015
New Revision: 250834
URL: http://llvm.org/viewvc/llvm-project?rev=250834&view=rev
Log:
[CMake] Make external compiler-rt install scripts relative to
CMAKE_INSTALL_PREFIX.
This change makes LLVM_BUILD_EXTERNAL_COMPILER_RT work correctly when
overr
Author: rnk
Date: Tue Oct 20 13:12:08 2015
New Revision: 250839
URL: http://llvm.org/viewvc/llvm-project?rev=250839&view=rev
Log:
Look through using decls when classifying implicit member access
Clang will now accept this valid C++11 code:
struct A { int field; };
struct B : A {
using A::
Author: cbieneman
Date: Tue Oct 20 13:12:12 2015
New Revision: 250840
URL: http://llvm.org/viewvc/llvm-project?rev=250840&view=rev
Log:
[CMake] Make clang/tools subdirectories controlled via options
Setting CLANG_TOOL_*_BUILD=Off on the CMake command line will disable inclusion
of a clang/tools
rjmccall added a comment.
Needs more tests.
1. Dependent template instantiation.
2. Non-dependent template instantiation.
3. Indexes which are themselves pseudo-objects.
4. Templated getters and setters.
5. Non-POD by-value argument types.
Comment at: include/clang/AST/BuiltinT
On Tue, Oct 20, 2015 at 12:50 AM, Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Tue Oct 20 02:50:21 2015
> New Revision: 250803
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250803&view=rev
> Log:
> Put back dead code that's used out-of-tree.
>
Migh
Nevermind, I see this was floated/discussed in the review thread of the
original commit ( 250418 )
On Tue, Oct 20, 2015 at 11:46 AM, David Blaikie wrote:
>
>
> On Tue, Oct 20, 2015 at 12:50 AM, Benjamin Kramer via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: d0k
>> Date: Tue
Author: rnk
Date: Tue Oct 20 13:45:57 2015
New Revision: 250844
URL: http://llvm.org/viewvc/llvm-project?rev=250844&view=rev
Log:
Add back null check removed accidentally in r250554
Fixes PR25262
Added:
cfe/trunk/test/Frontend/force-include-not-found.c
Modified:
cfe/trunk/lib/Lex/HeaderS
On Tue, Oct 20, 2015 at 8:39 AM, Samuel Benzaquen wrote:
>
> On Mon, Oct 19, 2015 at 6:00 PM, David Blaikie wrote:
>
>>
>>
>> On Mon, Oct 19, 2015 at 2:49 PM, Samuel Benzaquen via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: sbenza
>>> Date: Mon Oct 19 16:49:51 2015
>>> New
sfantao created this revision.
sfantao added reviewers: hfinkel, rsmith, echristo, ABataev, chandlerc.
sfantao added a subscriber: cfe-commits.
One of the goals of programming models that support offloading (e.g. OpenMP) is
to enable users to offload with little effort, by annotating the code wit
sfantao updated this revision to Diff 37903.
sfantao added a comment.
Move clang-offload-bundler to to a separate review:
http://reviews.llvm.org/D13909.
This patch depends on http://reviews.llvm.org/D13909.
http://reviews.llvm.org/D9888
Files:
include/clang/Basic/DiagnosticDriverKinds.td
tra updated this revision to Diff 37912.
tra added a comment.
Herald added a subscriber: klimek.
Changed header wrapping strategy. Previous version was attempting to
make CUDA headers work for host/device compilations separately. In the
end host and device compilations ended up with different view
sbenza added a comment.
Minor comments only.
Comment at: clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:29
@@ +28,3 @@
+ callExpr(callee(functionDecl(isVariadic(),
+ unless(hasName("__builtin_va_start")
+ .bind("callvararg
Author: majnemer
Date: Tue Oct 20 15:49:21 2015
New Revision: 250854
URL: http://llvm.org/viewvc/llvm-project?rev=250854&view=rev
Log:
[-fms-extensions] Allow missing exception specifications in redeclarations as
an extension
Microsoft's ATL headers make use of this MSVC extension, add support
Author: rnk
Date: Tue Oct 20 16:04:13 2015
New Revision: 250856
URL: http://llvm.org/viewvc/llvm-project?rev=250856&view=rev
Log:
Re-land r250592 without rejecting field refs in unevaluated contexts
This time, I went with the first approach from
http://reviews.llvm.org/D6700, where clang actually
On Tue, Oct 20, 2015 at 6:45 AM, Manuel Klimek wrote:
> On Tue, Oct 20, 2015 at 3:38 PM Brad King wrote:
>
>> On 10/20/2015 04:38 AM, Manuel Klimek wrote:
>> > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
>> >> get cmake to generate clang module map files and add explicit module
>> build st
EricWF added a comment.
Thanks for the update, I think this should be good to go. I'll give it a final
once over tonight.
Comment at: src/locale.cpp:958
@@ -957,3 +961,3 @@
return static_cast(__classic_lower_table()[static_cast(c)]);
-#elif defined(__GLIBC__) || defined(__
tra created this revision.
tra added reviewers: echristo, pcc.
tra added a subscriber: cfe-commits.
This will be used for CUDA where we need to link with vendor-supplied bitcode
library and with a bitcode library pretending to be libm for GPUs.
Linking options for particular file depend on the
On 10/20/2015 02:56 PM, Angel Garcia Gomez via cfe-commits wrote:
Author: angelgarcia
Date: Tue Oct 20 07:56:27 2015
New Revision: 250824
URL: http://llvm.org/viewvc/llvm-project?rev=250824&view=rev
Log:
Apply modernize-use-default to clang-tools-extra.
Summary: Replace empty bodies of default
On Tue, Oct 20, 2015 at 2:24 PM, Tobias Grosser via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 10/20/2015 02:56 PM, Angel Garcia Gomez via cfe-commits wrote:
>
>> Author: angelgarcia
>> Date: Tue Oct 20 07:56:27 2015
>> New Revision: 250824
>>
>> URL: http://llvm.org/viewvc/llvm-project
On 10/20/2015 11:37 PM, David Blaikie wrote:
On Tue, Oct 20, 2015 at 2:24 PM, Tobias Grosser via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
On 10/20/2015 02:56 PM, Angel Garcia Gomez via cfe-commits wrote:
Author: angelgarcia
Date: Tue Oct 20 07:56:27 2015
mgehre updated this revision to Diff 37925.
mgehre added a comment.
removed __builtin_va_start; change f->foo() to f.foo()
http://reviews.llvm.org/D13787
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguide
Author: dblaikie
Date: Tue Oct 20 16:45:52 2015
New Revision: 250862
URL: http://llvm.org/viewvc/llvm-project?rev=250862&view=rev
Log:
Revert "Apply modernize-use-default to clang-tools-extra."
Breaks the build in GCC 4.7.2 (see
http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3 for example)
Reverted in r250862
On Tue, Oct 20, 2015 at 2:39 PM, Tobias Grosser wrote:
> On 10/20/2015 11:37 PM, David Blaikie wrote:
>
>>
>>
>> On Tue, Oct 20, 2015 at 2:24 PM, Tobias Grosser via cfe-commits
>> mailto:cfe-commits@lists.llvm.org>> wrote:
>>
>> On 10/20/2015 02:56 PM, Angel Garcia Gomez
sbenza accepted this revision.
sbenza added a comment.
This revision is now accepted and ready to land.
Thanks for check.
http://reviews.llvm.org/D13787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
george.burgess.iv updated this revision to Diff 37935.
george.burgess.iv added a comment.
Rebased
http://reviews.llvm.org/D13263
Files:
include/clang/AST/Expr.h
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds
mgehre added a comment.
Thanks for the good review!
Comment at: clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:26
@@ +25,3 @@
+ Finder->addMatcher(
+ varDecl(hasType(pointsTo(cxxRecordDecl(hasName("__va_list_tag")
+ .bind("va_list"),
sben
Author: chapuni
Date: Tue Oct 20 17:36:16 2015
New Revision: 250866
URL: http://llvm.org/viewvc/llvm-project?rev=250866&view=rev
Log:
Revert r247977, "clang/test/lit.cfg: *-ps4 doesn't have appropriate driver yet.
Mark it as "non-clang-driver"."
They, "tests requiring clang-driver", should work
sfantao created this revision.
sfantao added a reviewer: bkramer.
sfantao added a subscriber: cfe-commits.
If the user configured clang with a custom GCC toolchain that will take
precedence on what the ToolChainTest.cpp expects to evaluate. This was causing
the test to fail in these cases.
This
zaks.anna added a comment.
Should this be closed?
http://reviews.llvm.org/D12906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1638
@@ +1637,3 @@
+
+Note that to ensure correct execution the user MUST make certain that no
+other translation unit has an implicit instantiation of the same entity. In
> I don't t
aaron.ballman added inline comments.
Comment at:
test/clang-tidy/cppcoreguidelines-pro-bounds-array-to-pointer-decay.cpp:13
@@ +12,3 @@
+
+void pointerfun(int* p);
+void arrayfun(int p[]);
> Currently, the diag is
> ```
> diag(MatchedCast->getExprLoc(), "do not (
Sorry, I have just seen all this. Thank you for reverting it, David.
On Tue, Oct 20, 2015 at 11:48 PM, David Blaikie wrote:
> Reverted in r250862
>
> On Tue, Oct 20, 2015 at 2:39 PM, Tobias Grosser wrote:
>
>> On 10/20/2015 11:37 PM, David Blaikie wrote:
>>
>>>
>>>
>>> On Tue, Oct 20, 2015 at 2
eugenis created this revision.
eugenis added a reviewer: rsmith.
eugenis added subscribers: cfe-commits, EricWF, rnk.
eugenis set the repository for this revision to rL LLVM.
The attrubite is applicable to functions and variables and changes the linkage
of the subject to internal.
Following the
dcoughlin added a comment.
Hi Sean,
Sorry it took me so long to get back to you.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:266
@@ +265,3 @@
+ /// \sa shouldWidenLoops
+ bool WidenLoops;
+
Is this field used?
Comment at:
majnemer added a subscriber: majnemer.
Comment at: include/clang/Basic/Attr.td:2114
@@ +2113,3 @@
+ let Spellings = [GCC<"internal_linkage">];
+ let Subjects = SubjectList<[Function,Var]>;
+ let Documentation = [InternalLinkageDocs];
Space between `Function` an
majnemer added a subscriber: majnemer.
Comment at: include/clang/Basic/Attr.td:1463
@@ +1462,3 @@
+ let Spellings = [GNU<"unique_instantiation">];
+ let Subjects = SubjectList<[Function, CXXRecord], ErrorDiag>;
+ let Documentation = [UniqueInstantiationDocs];
W
Author: ctopper
Date: Tue Oct 20 21:34:10 2015
New Revision: 250876
URL: http://llvm.org/viewvc/llvm-project?rev=250876&view=rev
Log:
Use ArrayRef and MutableArrayRef instead of a pointer and size. NFC
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe/trunk/lib/Basic/TargetInfo.cpp
george.burgess.iv updated this revision to Diff 37965.
george.burgess.iv added a comment.
Rebased
http://reviews.llvm.org/D13704
Files:
include/clang/Basic/AttrDocs.td
lib/Sema/SemaOverload.cpp
test/CodeGen/overloadable.c
test/Sema/overloadable.c
Index: test/Sema/overloadable.c
===
eugenis added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:1580-1585
@@ -1577,3 +1579,8 @@
+
+ if (InternalLinkageAttr *Internal = D->getAttr()) {
+S.Diag(Attr.getRange().getBegin(), diag::warn_attribute_ignored)
+<< Attr.getName();
+S.Diag(Internal->get
Author: ctopper
Date: Tue Oct 20 23:52:38 2015
New Revision: 250880
URL: http://llvm.org/viewvc/llvm-project?rev=250880&view=rev
Log:
Use std::find instead of a manual loop.
Modified:
cfe/trunk/lib/Basic/TargetInfo.cpp
Modified: cfe/trunk/lib/Basic/TargetInfo.cpp
URL:
http://llvm.org/viewvc
Author: ctopper
Date: Tue Oct 20 23:52:40 2015
New Revision: 250881
URL: http://llvm.org/viewvc/llvm-project?rev=250881&view=rev
Log:
Use range-based for loops. NFC.
Modified:
cfe/trunk/lib/Basic/TargetInfo.cpp
Modified: cfe/trunk/lib/Basic/TargetInfo.cpp
URL:
http://llvm.org/viewvc/llvm-pr
Author: ctopper
Date: Tue Oct 20 23:52:34 2015
New Revision: 250878
URL: http://llvm.org/viewvc/llvm-project?rev=250878&view=rev
Log:
Fix bad indentation.
Modified:
cfe/trunk/lib/Basic/TargetInfo.cpp
Modified: cfe/trunk/lib/Basic/TargetInfo.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/t
Author: ctopper
Date: Tue Oct 20 23:52:36 2015
New Revision: 250879
URL: http://llvm.org/viewvc/llvm-project?rev=250879&view=rev
Log:
Parse into an unsigned type instead of a signed type and then checking for
positive and casting to unsigned. Since we know the string starts with a digit
it could
zaks.anna added inline comments.
Comment at: lib/Analysis/BodyFarm.h:43
@@ +42,3 @@
+ /// \brief Merge the attributes found in model files.
+ /// Note, this adds all attributes found in the model file without any sanity
+ /// checks.
Why do we not have sanity c
danielmarjamaki added a comment.
I tested this on 2199 debian projects.. and got 16 warnings.
ftp://ftp.se.debian.org/debian/pool/main/t/tf5/tf5_5.0beta8.orig.tar.gz
expr.c:738:22: warning: comparisons such as 'a < b != c' do not have their
mathematical meaning [-Wparentheses]
if (
ahatanak created this revision.
ahatanak added reviewers: dexonsmith, echristo.
ahatanak added a subscriber: cfe-commits.
Another patch which fixes a bug in clang where it creates a function but
doesn't attach function attributes to it.
http://reviews.llvm.org/D13928
Files:
lib/CodeGen/C
91 matches
Mail list logo
