sbenza added a comment.
Minor comments only.
================
Comment at: clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:29
@@ +28,3 @@
+ callExpr(callee(functionDecl(isVariadic(),
+ unless(hasName("__builtin_va_start")))))
+ .bind("callvararg"),
----------------
No need to mention __builtin_va_start anymore.
================
Comment at: test/clang-tidy/cppcoreguidelines-pro-type-vararg.cpp:31
@@ +30,3 @@
+template <typename T>
+void CallFooIfAvailableImpl(T& t, decltype(t.foo())*) {
+ t->foo();
----------------
nit: t.foo() here vs t->foo() in the next line.
http://reviews.llvm.org/D13787
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
