> Generally good. How about only report error when SM.getKind() == DK_Error?
Good idea. I've committed it with more flexible diagnostic kinds as r265592.
Tim.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
> On Apr 1, 2016, at 12:04 PM, Tim Northover wrote:
>
>
>> On 31 Mar 2016, at 16:51, Steven Wu wrote:
>>
>> The original handler is not there to workaround a crash. It is to avoid
>> generate a crash report (report_fatal_error) when the input bitcode contains
>> invalid assembly.
>
> Ah,
> On 31 Mar 2016, at 16:51, Steven Wu wrote:
>
> The original handler is not there to workaround a crash. It is to avoid
> generate a crash report (report_fatal_error) when the input bitcode contains
> invalid assembly.
Ah, I see now. That test needs tweaking too, since it doesn't actually p
The original handler is not there to workaround a crash. It is to avoid
generate a crash report (report_fatal_error) when the input bitcode contains
invalid assembly.
It is an oversight to exit(0) even when it failed. Can you make the diagnostic
handler fatal for Errors kinds instead of removin
Author: tnorthover
Date: Thu Mar 31 14:19:24 2016
New Revision: 265038
URL: http://llvm.org/viewvc/llvm-project?rev=265038&view=rev
Log:
Diagnostics: remove dodgy handler for bitcode inlineasm diagnostics.
Whatever crash it was there to present appears to have been fixed in the
backend now, and i
