> On Apr 1, 2016, at 12:04 PM, Tim Northover <tnortho...@apple.com> wrote: > > >> On 31 Mar 2016, at 16:51, Steven Wu <steve...@apple.com> wrote: >> >> The original handler is not there to workaround a crash. It is to avoid >> generate a crash report (report_fatal_error) when the input bitcode contains >> invalid assembly. > > Ah, I see now. That test needs tweaking too, since it doesn't actually > produce the crash report even after my change (probably because it's a > %clang_cc1 test). Probably need assertion build or some cmake setting to actually show the crash log. > > How does the patch attached here look? I originally tried reusing the real > InlineAsmDiagHandler but that was disastrous (it needs a real AST I think, > which obviously doesn't exist when compiling a .bc file). Generally good. How about only report error when SM.getKind() == DK_Error?
Steven > > Cheers. > > Tim. > > <asm-diagnostics.diff> _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
