Re: [PATCH] D20158: [find-all-symbols] Save relative file path for each symbol.

2016-05-11 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL269173: [find-all-symbols] Save relative file path for each symbol. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20158?vs=56879&id=56881#toc Repository: rL LLVM http://rev

Re: [PATCH] D20158: [find-all-symbols] Save relative file path for each symbol.

2016-05-11 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:81 @@ -81,1 +80,3 @@ + /// \brief The file path where the symbol comes from. It's a relative file + /// path based on the build directory. std::string FilePath; bkramer wrot

Re: [PATCH] D20158: [find-all-symbols] Save relative file path for each symbol.

2016-05-11 Thread Benjamin Kramer via cfe-commits
bkramer added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:81 @@ -81,1 +80,3 @@ + /// \brief The file path where the symbol comes from. It's a relative file + /// path based on the build directory. std::string FilePath; hokein wrot

Re: [PATCH] D20158: [find-all-symbols] Save relative file path for each symbol.

2016-05-11 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. LG! Repository: rL LLVM http://reviews.llvm.org/D20158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D20158: [find-all-symbols] Save relative file path for each symbol.

2016-05-11 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:81 @@ -81,1 +80,3 @@ + /// \brief The file path where the symbol comes from. It's a relative file + /// path based on the build directory. std::string FilePath; One question