hokein added inline comments. ================ Comment at: include-fixer/find-all-symbols/SymbolInfo.h:81 @@ -81,1 +80,3 @@ + /// \brief The file path where the symbol comes from. It's a relative file + /// path based on the build directory. std::string FilePath; ---------------- bkramer wrote: > hokein wrote: > > One question is that whether should we add a `BuildDir` in `SymbolInfo`. > > With `BuildDir`, we can check the build directory in include-fixer make > > sure they are the same :). > Hmm. If both the symbol finder and include fixer run on the same compilation > database this can never happen, right? Yeah. So don't do it now.
Repository: rL LLVM http://reviews.llvm.org/D20158 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
