This revision was automatically updated to reflect the committed changes.
Closed by commit rL270086: Check for nullptr argument. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D20141?vs=56832&id=57825#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20141
Files:
cfe/t
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
OK, if the function explicitly says it accepts null values and if we check
elsewhere in the function, I'm personally OK adding the checks.
http://reviews.llvm.org/D20141
__
If you have a check that doesn't have a test/is never triggered - simple
thing to do is just make it an assert & run some testing of your own
(selfhost, etc) then if there's insufficient evidence that it's needed,
ship it and wait until it fails on a buildbot, etc. Then reduce the test
case and che
tra added a comment.
I've never seen it triggered. Fix is based on the comment above the function
that D==nullptr is acceptable and the fact that we are checking D in other
places in this function.
Two cases where nullptr D is passed explicitly has something to do with
-fblocks, but that does
jlebar added a comment.
Can we have a test?
http://reviews.llvm.org/D20141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
