If you have a check that doesn't have a test/is never triggered - simple thing to do is just make it an assert & run some testing of your own (selfhost, etc) then if there's insufficient evidence that it's needed, ship it and wait until it fails on a buildbot, etc. Then reduce the test case and check that in.
- Dave On Tue, May 10, 2016 at 4:25 PM, Artem Belevich via cfe-commits < cfe-commits@lists.llvm.org> wrote: > tra added a comment. > > I've never seen it triggered. Fix is based on the comment above the > function that D==nullptr is acceptable and the fact that we are checking D > in other places in this function. > > Two cases where nullptr D is passed explicitly has something to do with > -fblocks, but that does not seem to be used neither with CUDA nor with > 'IsForDefinition' which was brought in to deal with a strange case of > redefining C++ symbols in C. This is probably why it's not triggered. > > > http://reviews.llvm.org/D20141 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
