Re: [PATCH] D19259: Initial version of misc-unused-using-decl check

2016-04-26 Thread Alexander Kornienko via cfe-commits
alexfh closed this revision. alexfh added a comment. This seems to have been committed as r266735. http://reviews.llvm.org/D19259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19259: Initial version of misc-unused-using-decl check

2016-04-19 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one nit. Thank you! Comment at: clang-tidy/misc/MiscTidyModule.cpp:123 @@ -121,1 +122,3 @@ +CheckFactories.registerCheck( +"misc-unused-using-decls");

Re: [PATCH] D19259: Initial version of misc-unused-using-decl check

2016-04-19 Thread Daniel Jasper via cfe-commits
djasper updated this revision to Diff 54183. http://reviews.llvm.org/D19259 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/UnusedAliasDeclsCheck.h clang-tidy/misc/UnusedUsingDeclsCheck.cpp clang-tidy/misc/UnusedUsingDeclsCheck.h docs/clang-tid

Re: [PATCH] D19259: Initial version of misc-unused-using-decl check

2016-04-19 Thread Daniel Jasper via cfe-commits
djasper marked 3 inline comments as done. Comment at: clang-tidy/misc/MiscTidyModule.cpp:123 @@ -121,1 +122,3 @@ +CheckFactories.registerCheck( +"misc-unused-using-decls"); CheckFactories.registerCheck( alexfh wrote: > I think, all "misc-unused-"

Re: [PATCH] D19259: Initial version of misc-unused-using-decl check

2016-04-19 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Awesome! Thank you for tackling this! A few comments. Comment at: clang-tidy/misc/CMakeLists.txt:38 @@ -37,2 +37,3 @@ UnusedRAIICheck.cpp UniqueptrResetReleaseCheck.cpp + UnusedUsingDeclsCheck.cpp Please fix file sorting around the