ariccio added a comment.
In http://reviews.llvm.org/D18498#384711, @mspertus wrote:
> I installed both VS2015 and VS2013 on my laptop and saw the correct solution
> files built by cmake.
Btw, make sure you're running the latest updates for both Visual Studio, else
you'll get funny build error
mspertus closed this revision.
mspertus added a comment.
Closing diff after commit
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus added a comment.
Commited as revision 264603
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus added a comment.
This is still showing as "Needs review" Are there any further changes required
or can someone accept it? I installed both VS2015 and VS2013 on my laptop and
saw the correct solution files built by cmake.
http://reviews.llvm.org/D18498
__
ariccio added inline comments.
Comment at: utils/ClangVisualizers/CMakeLists.txt:3
@@ +2,3 @@
+# tries to create a corresponding executable, which we don't want.
+if (LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION)
+ set(CLANG_VISUALIZERS clang.natvis)
Hmm, that's gonna
mspertus updated this revision to Diff 51762.
mspertus added a comment.
Incorporating ariccio's comments and fixing some html
http://reviews.llvm.org/D18498
Files:
CMakeLists.txt
utils/ClangVisualizers/CMakeLists.txt
utils/ClangVisualizers/clang.natvis
utils/clang.natvis
www/hacking.h
mspertus marked an inline comment as done.
mspertus added a comment.
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus marked an inline comment as done.
Comment at: utils/ClangVisualizers/CMakeLists.txt:2
@@ +1,3 @@
+# Do this by hand instead of using add_llvm_utilities(), which
+# tries to create a corresponding executable, which we don't want
+if (LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION
ariccio added a comment.
Assuming everything builds correctly, LGTM.
Your CMake is better than mine, so I'm not sure if there're better ways to do
this ;)
Comment at: utils/ClangVisualizers/CMakeLists.txt:2
@@ +1,3 @@
+# Do this by hand instead of using add_llvm_utilities(), w
ariccio added a comment.
In http://reviews.llvm.org/D18498#384274, @zturner wrote:
> Ahh that's surprising. If it works even with the none tag, i guess my
> concerns are not valid
I'm only partly surprised... It's not the first time that a Microsoft product
behaves surprisingly :)
http://re
mspertus updated this revision to Diff 51759.
mspertus added a comment.
Now that we are generating projects for native visualizers, have it properly
reflected in the directory structure
http://reviews.llvm.org/D18498
Files:
CMakeLists.txt
utils/ClangVisualizers/CMakeLists.txt
utils/Clang
Yea sounds fine
On Sun, Mar 27, 2016 at 12:20 PM Mike Spertus wrote:
> mspertus added a comment.
>
> I understand your concerns, but on balance, I don't see a better course of
> action than what I've done. If I have some time, I'll submit a CMake change
> so we can eventually migrate to having CM
mspertus added a comment.
I understand your concerns, but on balance, I don't see a better course of
action than what I've done. If I have some time, I'll submit a CMake change so
we can eventually migrate to having CMake generate a Natvis tag, but that will
take a long time to propagate, so I
Ahh that's surprising. If it works even with the none tag, i guess my
concerns are not valid
On Sun, Mar 27, 2016 at 12:11 PM Mike Spertus wrote:
> mspertus added a comment.
>
> No. Testing shows that it works fine in the project with the `` tag.
> VS2015 empirically looks at the extension.
>
>
>
mspertus added a comment.
No. Testing shows that it works fine in the project with the `` tag.
VS2015 empirically looks at the extension.
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
If it's not using a natvis tag in the vcxproj (which it isn't since CMake
doesn't support it during generation) then the new natvis project file
support won't work right? In which case the files would need to be copied
into documents\vs2015, otherwise it won't work, unless I'm misunderstanding
some
mspertus added a comment.
I'm not sure I understand. I'm not installing anything for VS2013. You still
have to manually copy into `Documents\VS2013`. The purpose of this change is to
eliminate this manual step for VS2015 by leveraging the new Natvis project
support. Am I missing something?
ht
Code paths. For vs2013 you're installing the natvis files, can we just do
that for vs2015 as well?
On Sun, Mar 27, 2016 at 11:23 AM Mike Spertus wrote:
> mspertus added a comment.
>
> What do you mean by "making both paths the same"?
>
>
> http://reviews.llvm.org/D18498
>
>
>
>
__
mspertus added a comment.
What do you mean by "making both paths the same"?
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Yea, CMake doesn't actually support natvis files. You'd have to actually
patch CMake to make it work.
Can you make the vs2015 and vs2013 paths the same? It will still work for
2015 i think, just that 2015 also supports putting them in the project file
On Sun, Mar 27, 2016 at 10:04 AM Mike Spertus
mspertus added a comment.
Hmmm, I just tried adding ` set_source_files_properties(utils/clang.natvis
LANGUAGE natvis)` similar to what you suggest in
http://lists.llvm.org/pipermail/llvm-dev/2016-January/093887.html, but it still
produces the `None` tag in the `.vcxproj` file. Any suggestion wh
mspertus added a comment.
In http://reviews.llvm.org/D18498#384233, @zturner wrote:
> For vs2015, the files still need to be in the project right? (In the
> vcxproj with a tag)
This change puts the natvis files in the project for VS2015 but it appears to
use the `none` tag
http://schem
For vs2015, the files still need to be in the project right? (In the
vcxproj with a tag)
On Sun, Mar 27, 2016 at 9:09 AM Mike Spertus wrote:
> mspertus updated this revision to Diff 51741.
> mspertus added a comment.
>
> Apply whitespace comments from http://reviews.llvm.org/D18497 mutatis
> mut
mspertus updated this revision to Diff 51741.
mspertus added a comment.
Apply whitespace comments from http://reviews.llvm.org/D18497 mutatis mutandis
to this change
http://reviews.llvm.org/D18498
Files:
CMakeLists.txt
utils/clang.natvis
www/hacking.html
Index: www/hacking.html
24 matches
Mail list logo
