alexfh closed this revision.
alexfh added a comment.
Committed revision 245427.
http://reviews.llvm.org/D12076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Awesome! Thanks for converting this to a clang-tidy check!
I'll submit the patch for you.
http://reviews.llvm.org/D12076
___
cfe-commits mailing
alexfh added a comment.
In http://reviews.llvm.org/D12076#226476, @angelgarcia wrote:
> Split the tests in several files.
Thank you! Seems better like this.
A few more comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:293
@@ +292,3 @@
+return nullptr;
+ co
alexfh added a comment.
Some initial comments. I'll need a bit more time to review this thoroughly.
Comment at: test/clang-tidy/modernize-loop-convert.cpp:149
@@ +148,3 @@
+arr[i] = 0;
+ // CHECK-MESSAGES-NOT: :[[@LINE-2]]:3: warning: use range-based for loop
instead
+ //
