Committed r297702.
> On Mar 13, 2017, at 10:02 AM, Lobron, David wrote:
>
> Yes, please, if you don't mind! I'd like to commit both the path and the
> unit test, if possible.
>
> Thanks,
>
> David
>
>> On Mar 13, 2017, at 12:47 PM, Akira Hatanaka wrote:
>>
>> Do you need someone to commit
Yes, please, if you don't mind! I'd like to commit both the path and the unit
test, if possible.
Thanks,
David
> On Mar 13, 2017, at 12:47 PM, Akira Hatanaka wrote:
>
> Do you need someone to commit this patch for you?
>
>> On Mar 10, 2017, at 6:44 AM, Lobron, David wrote:
>>
>> Hi Akira,
Do you need someone to commit this patch for you?
> On Mar 10, 2017, at 6:44 AM, Lobron, David wrote:
>
> Hi Akira,
>
> Thank you very much! Please let me know if I need to take any further steps
> beyond this email to cfe-commits in order for the patch and the unit test to
> be committed.
>
Hi Akira,
Thank you very much! Please let me know if I need to take any further steps
beyond this email to cfe-commits in order for the patch and the unit test to be
committed.
Thanks,
David
> On Mar 9, 2017, at 4:46 PM, Akira Hatanaka wrote:
>
> Hi David,
>
> The patch looks good to me.
Hi David,
The patch looks good to me.
> On Mar 9, 2017, at 1:01 PM, Lobron, David wrote:
>
> Hi Akira,
>
>> My concern is that the patch changes the encoding of @encode(id)
>> on Darwin, which I think isn’t what you are trying to fix. If you compile
>> the following code with command “clang
Hi Akira,
> My concern is that the patch changes the encoding of @encode(id) on
> Darwin, which I think isn’t what you are trying to fix. If you compile the
> following code with command “clang -cc1 -triple x86_64-apple-macosx”, the
> type encoding changes after applying the patch.
>
> const c
> On Mar 6, 2017, at 10:17 AM, Lobron, David wrote:
>
> Hi Akira,
>
> Pardon my slowness in addressing your question.
>
>> This patch changes the encoding of an id conforming to a protocol, which I
>> think was not intended: For example:
>>
>> @encode(id)
>>
>> Would passing IVD to the call
Hi Akira,
Pardon my slowness in addressing your question.
> This patch changes the encoding of an id conforming to a protocol, which I
> think was not intended: For example:
>
> @encode(id)
>
> Would passing IVD to the call to getObjCEncodingForType in
> CGObjCGNU::GenerateClass solve the pro
Hi Akira,
Pardon my slow reply here- I was traveling and just got back to work email. I
will check into this as soon as I can, and get back to you.
Thank you,
David
> On Feb 20, 2017, at 12:04 AM, Akira Hatanaka wrote:
>
> This patch changes the encoding of an id conforming to a protocol, w
This patch changes the encoding of an id conforming to a protocol, which I
think was not intended: For example:
@encode(id)
Would passing IVD to the call to getObjCEncodingForType in
CGObjCGNU::GenerateClass solve the problem?
> On Feb 15, 2017, at 1:59 PM, Lobron, David via cfe-commits
> wr
Hi All,
I am re-submitting my patch for Bug 30413, this time with a test case included
as well (ivar-type-encoding.m). The test case file should be added to
clang/test/CodeGenObjC. The test verifies that correct metadata is emitted by
clang for an object-valued instance variable. I've verifi
11 matches
Mail list logo
