Re: Patch for Bug 30413, including test case

2017-03-13 Thread Akira Hatanaka via cfe-commits
Committed r297702. > On Mar 13, 2017, at 10:02 AM, Lobron, David wrote: > > Yes, please, if you don't mind! I'd like to commit both the path and the > unit test, if possible. > > Thanks, > > David > >> On Mar 13, 2017, at 12:47 PM, Akira Hatanaka wrote: >> >> Do you need someone to commit

Re: Patch for Bug 30413, including test case

2017-03-13 Thread Lobron, David via cfe-commits
Yes, please, if you don't mind! I'd like to commit both the path and the unit test, if possible. Thanks, David > On Mar 13, 2017, at 12:47 PM, Akira Hatanaka wrote: > > Do you need someone to commit this patch for you? > >> On Mar 10, 2017, at 6:44 AM, Lobron, David wrote: >> >> Hi Akira,

Re: Patch for Bug 30413, including test case

2017-03-13 Thread Akira Hatanaka via cfe-commits
Do you need someone to commit this patch for you? > On Mar 10, 2017, at 6:44 AM, Lobron, David wrote: > > Hi Akira, > > Thank you very much! Please let me know if I need to take any further steps > beyond this email to cfe-commits in order for the patch and the unit test to > be committed. >

Re: Patch for Bug 30413, including test case

2017-03-10 Thread Lobron, David via cfe-commits
Hi Akira, Thank you very much! Please let me know if I need to take any further steps beyond this email to cfe-commits in order for the patch and the unit test to be committed. Thanks, David > On Mar 9, 2017, at 4:46 PM, Akira Hatanaka wrote: > > Hi David, > > The patch looks good to me.

Re: Patch for Bug 30413, including test case

2017-03-09 Thread Akira Hatanaka via cfe-commits
Hi David, The patch looks good to me. > On Mar 9, 2017, at 1:01 PM, Lobron, David wrote: > > Hi Akira, > >> My concern is that the patch changes the encoding of @encode(id) >> on Darwin, which I think isn’t what you are trying to fix. If you compile >> the following code with command “clang

Re: Patch for Bug 30413, including test case

2017-03-09 Thread Lobron, David via cfe-commits
Hi Akira, > My concern is that the patch changes the encoding of @encode(id) on > Darwin, which I think isn’t what you are trying to fix. If you compile the > following code with command “clang -cc1 -triple x86_64-apple-macosx”, the > type encoding changes after applying the patch. > > const c

Re: Patch for Bug 30413, including test case

2017-03-06 Thread Akira Hatanaka via cfe-commits
> On Mar 6, 2017, at 10:17 AM, Lobron, David wrote: > > Hi Akira, > > Pardon my slowness in addressing your question. > >> This patch changes the encoding of an id conforming to a protocol, which I >> think was not intended: For example: >> >> @encode(id) >> >> Would passing IVD to the call

Re: Patch for Bug 30413, including test case

2017-03-06 Thread Lobron, David via cfe-commits
Hi Akira, Pardon my slowness in addressing your question. > This patch changes the encoding of an id conforming to a protocol, which I > think was not intended: For example: > > @encode(id) > > Would passing IVD to the call to getObjCEncodingForType in > CGObjCGNU::GenerateClass solve the pro

Re: Patch for Bug 30413, including test case

2017-02-23 Thread Lobron, David via cfe-commits
gt;> >> Hi All, >> >> I am re-submitting my patch for Bug 30413, this time with a test case >> included as well (ivar-type-encoding.m). The test case file should be added >> to clang/test/CodeGenObjC. The test verifies that correct metadata is >> emitt

Re: Patch for Bug 30413, including test case

2017-02-19 Thread Akira Hatanaka via cfe-commits
its > wrote: > > Hi All, > > I am re-submitting my patch for Bug 30413, this time with a test case > included as well (ivar-type-encoding.m). The test case file should be added > to clang/test/CodeGenObjC. The test verifies that correct metadata is > emitted by clang fo

Patch for Bug 30413, including test case

2017-02-15 Thread Lobron, David via cfe-commits
Hi All, I am re-submitting my patch for Bug 30413, this time with a test case included as well (ivar-type-encoding.m). The test case file should be added to clang/test/CodeGenObjC. The test verifies that correct metadata is emitted by clang for an object-valued instance variable. I&#x

Re: Patch for Bug 30413

2017-02-10 Thread Vedant Kumar via cfe-commits
> On Feb 10, 2017, at 8:29 AM, Lobron, David wrote: > > Hi Vedant, > > Thanks for the reply! Yes, I have a small test case- I actually attached it > to the original bug report (https://llvm.org/bugs/show_bug.cgi?id=30413), but > I will go ahead and try adding it to clang/test/CodeGenObjC, or

Re: Patch for Bug 30413

2017-02-10 Thread Lobron, David via cfe-commits
Hi Vedant, Thanks for the reply! Yes, I have a small test case- I actually attached it to the original bug report (https://llvm.org/bugs/show_bug.cgi?id=30413), but I will go ahead and try adding it to clang/test/CodeGenObjC, or extend a case if possible. Is it OK to make changes to CodeGenOb

Re: Patch for Bug 30413

2017-02-09 Thread Vedant Kumar via cfe-commits
Hi David, Thanks for tracking this down. Do you have a small reproducer to use as a test case? Ideally, you'd add a regression test to clang/test/CodeGenObjC, or extend an existing one. vedant > On Feb 7, 2017, at 6:42 PM, Lobron, David via cfe-commits > wrote: > > Hello clang developers, >

Patch for Bug 30413

2017-02-07 Thread Lobron, David via cfe-commits
Hello clang developers, I discovered a bug that affects Objective-C programs compiled with clang on Linux. The current code was not emitting Objective-C class name metadata, which made it impossible for programs to do runtime type introspection. I opened a bug report that describes the proble