Re: [libcxx] r285456 - Added 'inline' attribute to basic_string's destructor

2016-10-30 Thread Eric Fiselier via cfe-commits
Hi All, This problem was caused by the definition of _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY. The issue was fixed in r285531, which also adds linkage tests for std::strings destructor. @Adtiya feel free to recommit this change. /Eric On Fri, Oct 28, 2016 at 7:00 PM, Mehdi Amini via cfe-commit

Re: [libcxx] r285456 - Added 'inline' attribute to basic_string's destructor

2016-10-28 Thread Mehdi Amini via cfe-commits
Hi Adtiya, I had to revert in r285485 to unbreak this build bot: http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_build/10737/ (LTO bootstrap of clang). Let’s iterate on the revision on Phabricator to fi

[libcxx] r285456 - Added 'inline' attribute to basic_string's destructor

2016-10-28 Thread Aditya Kumar via cfe-commits
Author: hiraditya Date: Fri Oct 28 16:27:24 2016 New Revision: 285456 URL: http://llvm.org/viewvc/llvm-project?rev=285456&view=rev Log: Added 'inline' attribute to basic_string's destructor Author: laxmansole Reviewers: howard.hinnant mclow.lists Subscribers: EricWF, flyingforyou, eva