[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -34,29 +35,22 @@ } -def get_line2func_list(args, clang_args): +def get_line2func_list(clang_cmd: Command): ret = collections.defaultdict(list) # Use clang's JSON AST dump to get the mangled name -json_dump_args = [args.clang] + clang_args + ["-fsyntax-only",

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -34,29 +35,22 @@ } -def get_line2func_list(args, clang_args): +def get_line2func_list(clang_cmd: Command): ret = collections.defaultdict(list) # Use clang's JSON AST dump to get the mangled name -json_dump_args = [args.clang] + clang_args + ["-fsyntax-only",

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -34,29 +35,22 @@ } -def get_line2func_list(args, clang_args): +def get_line2func_list(clang_cmd: Command): ret = collections.defaultdict(list) # Use clang's JSON AST dump to get the mangled name -json_dump_args = [args.clang] + clang_args + ["-fsyntax-only",

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

arichardson wrote: Looks like only squash and merge is possible here, so I'll commit the baseline test separately before landing this. https://github.com/llvm/llvm-project/pull/65333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

https://github.com/arichardson review_requested https://github.com/llvm/llvm-project/pull/65333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

https://github.com/arichardson review_requested https://github.com/llvm/llvm-project/pull/65333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

https://github.com/arichardson created https://github.com/llvm/llvm-project/pull/65333: I was trying to update a test that redirected stderr to a file and hit errors because the `2>%t.out` was being passed as a positional argument to clang. Instead of re-implementing basic shell parsing in this