nightlark wrote:
Yes, still looking into this -- got a bit busier through around mid-May though.
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
DeinAlptraum wrote:
@nightlark (ping) are you still looking into this?
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,36 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm==8.1.0"]
henryiii wrote:
Is there a reason you've pinned to setuptools_scm exactly, but not setuptools?
I would generally avoid this, unless there's a really good reason to pin it.
@@ -0,0 +1,36 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm==8.1.0"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = {text
Endilll wrote:
@nightlark Thank you for the write-up about things that can go wrong.
> open question: what email to list as the author?
This is a good question I don't know answer to. Debian packages from our APT
repository seems to specify `LLVM Packaging Team
` as the maintainer and their em
trolldbois wrote:
> > Also I barely know anything about how to package this stuff correctly, and
> > what the consequences would be if we get it wrong.
>
> Also regarding @Endilll. Nothing can go wrong really. This is still not
> connected to the CD and you would need permission from [`clang`
LecrisUT wrote:
Ok, can you preface the sentences with a "check if" so it doesn't create
confusions :sweat_smile:
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
LecrisUT wrote:
> Also I barely know anything about how to package this stuff correctly, and
> what the consequences would be if we get it wrong.
Also regarding @Endilll. Nothing can go wrong really. This is still not
connected to the CD and you would need permission from [`clang` pypi
projec
nightlark wrote:
@LecrisUT all of the situations listed work fine -- the top level bullet points
are the "hypothetical issues" that someone trying to use it have encountered,
and the sub-bullet points are ways to check that the potential issue was
addressed and is not an issue.
https://githu
LecrisUT wrote:
> - The python bindings aren't placed in the right folder to import them when
> the package is pip installed
They are *not*? I tried it and it imported fine, same as you noticed.
> - Installing directly from a git URL or source archives for a release won't
> work
Similarly,
nightlark wrote:
For reviewers, here's a summary of the potential issues that come to mind and
what has been done to verify things are working as expected:
* The packaging metadata (keywords, name, author/contact info, etc) don't match
what we expect
- check the pyproject.toml and make sur
nightlark wrote:
@Endilll - do you have way to contact them directly to tell them about this PR?
I suspect they are not seeing any notifications for the mentions here, and will
require telling them "in-person" at a meeting. I have a PR (opened >1 month
ago) in the repository for the libclang p
Endilll wrote:
> @Endilll @LecrisUT what else do you think needs to be done here to get this
> approved?
I still would like to hear from @sighingnow. One of the reasons is that I think
I've seen them attending one of the open meetings we have, so they might be
around somewhere. Also I barely
https://github.com/LecrisUT edited
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/LecrisUT approved this pull request.
My review is that it looks good to go for the scope that it serves. Follow up
changes I would recommend is to align the CI and `pyproject.toml` across the
other python projects, but it seems that it has been broken for a while, so
it's a
DeinAlptraum wrote:
@Endilll @LecrisUT what else do you think needs to be done here to get this
approved?
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
https://github.com/nightlark edited
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,36 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm==8.1.0"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = {text
@@ -0,0 +1,36 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm==8.1.0"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = {text
@@ -0,0 +1,36 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm==8.1.0"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = {text
@@ -0,0 +1,36 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm==8.1.0"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = {text
https://github.com/DeinAlptraum commented:
Sorry, saw this but had no time to answer. Unfortunately I'm also not familiar
with Python packaging so can't be of much help here
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,36 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm==8.1.0"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = {text
https://github.com/Endilll commented:
Thank you for working on this
I know too little of packaging in Python to approve, but let's try to get more
eyes on this.
CC @DeinAlptraum @sighingnow
https://github.com/llvm/llvm-project/pull/125806
___
cfe-com
@@ -0,0 +1,3 @@
+node: $Format:%H$
+node-date: $Format:%cI$
+describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$
nightlark wrote:
Another thought, I expect most end users will eventually be installing from a
PyPI package -- the sdist and wheel files uplo
nightlark wrote:
@Endilll the Python bindings seem like part of LLVM that you have expertise in,
if you also want to review this PR.
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/nightlark edited
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nightlark updated
https://github.com/llvm/llvm-project/pull/125806
>From a4c09eda556104fbe5a8acdb830215b2a4ebd131 Mon Sep 17 00:00:00 2001
From: Ryan Mast
Date: Tue, 4 Feb 2025 21:59:28 -0800
Subject: [PATCH] [libclang/python] Enable packaging libclang bindings
---
.gitattr
@@ -0,0 +1,3 @@
+node: $Format:%H$
+node-date: $Format:%cI$
+describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$
nightlark wrote:
I didn't see an option for `git describe` to list out describes relative to all
possible tags -- just listing all tags might
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
@@ -0,0 +1,3 @@
+node: $Format:%H$
+node-date: $Format:%cI$
+describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$
LecrisUT wrote:
Awesome findings. I could go either way on if it's expected behaviour or not.
Iirc the current format does not include all ta
https://github.com/nightlark edited
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nightlark updated
https://github.com/llvm/llvm-project/pull/125806
>From 4dd3356f37229c415c6b6e3dfec8c8020122124d Mon Sep 17 00:00:00 2001
From: Ryan Mast
Date: Tue, 4 Feb 2025 21:59:28 -0800
Subject: [PATCH] [libclang/python] Enable packaging libclang bindings
---
.gitattr
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
https://github.com/nightlark edited
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,3 @@
+node: $Format:%H$
+node-date: $Format:%cI$
+describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$
nightlark wrote:
The more open ended match is the standard one that setuptools_scm documents,
but we can make it more flexible.
I tried the
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
https://github.com/LecrisUT commented:
Other than missing new-line at the end of file, it looks fine.
License classifiers will soon be (or already are) deprecated, so check up with
setuptools and when they support PEP639.
https://github.com/llvm/llvm-project/pull/125806
___
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
@@ -0,0 +1,3 @@
+node: $Format:%H$
+node-date: $Format:%cI$
+describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$
LecrisUT wrote:
Nitpick about the describe tags. Why not be more explicit with
`llvmorg-[0-9]*]`?
Anyway did you double check that it works
https://github.com/LecrisUT edited
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nightlark wrote:
Hey, I'm new to the process of contributing to LLVM, so let me know of any best
practices or things I might have missed in the contributed guide.
I'm looking at improving the situation for packaging libclang bindings on PyPI
and ideally would like maintain the things needed he
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ryan Mast (nightlark)
Changes
Add files for packaging libclang Python bindings as a sdist tarball and pure
Python wheel. setuptools_scm is used to derive version numbers from git tags
for a future workflow that automates publishing update
https://github.com/nightlark edited
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/nightlark created
https://github.com/llvm/llvm-project/pull/125806
Add files for packaging libclang Python bindings as a sdist tarball and pure
Python wheel. setuptools_scm is used to derive version numbers from git tags
for a future workflow that automates publishing update
55 matches
Mail list logo
