Endilll wrote: @nightlark Thank you for the write-up about things that can go wrong. > open question: what email to list as the author?
This is a good question I don't know answer to. Debian packages from our APT repository seems to specify `LLVM Packaging Team <pkg-llvm-t...@lists.alioth.debian.org>` as the maintainer and their email. Sorry for not articulating my concerns clearly enough. I'm not too concerned with bugs, as bugs will be eventually found and fixed, but I'm concerned with bugs that we'll have hard time fixing due to backwards compatibility concerns. One such thing I can imagine is users depending on a particular version string format, then we realize it doesn't match what the rest of LLVM does, and have hard time fixing that. > do you have way to contact them directly to tell them about this PR? Apparently I mixed them up with another person who contributes to llvm-libc, so the answer is likely "no". > Are there any other people we could ask to review as an alternative, maybe > @henryiii? Sure. They are not going to have an experience with LLVM in particular, which is sad, but they will help us where we lack experience the most, i.e. Python packaging stuff. ------------- @nightlark I guess I should make it clear that it's mostly up to me as a maintainer to find reviewers that I think this patch needs, so you shouldn't feel that you're the one blocking progress here. But I appreciate the help explaining what can go wrong, and even suggesting reviewers. Also, the fact that I'm on leave since the beginning of this week doesn't help making progress. https://github.com/llvm/llvm-project/pull/125806 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
