https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/108224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> > Thanks! Making sure I follow along, basically you're saying this patch is
> > good because it keeps the ^^ token reserved, and if/when OpenCL supports
> > C++, it can then use this token for reflection in C++ (if that's chosen by
> > WG21 for the syntax) or use it for i
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AnastasiaStulova wrote:
> Thanks! Making sure I follow along, basically you're saying this patch is
> good because it keeps the ^^ token reserved, and if/when OpenCL supports C++,
> it can then use this token for reflection in C++ (if that's chosen by WG21
> for the syntax) or use it for its o
AaronBallman wrote:
> I think that the diagnostic change is reasonable. Clang doesn't support
> OpenCL C++ at present so we won't need to worry about it. However the mission
> of C++ for OpenCL is to track C++ and track OpenCL i.e. we may want to update
> to C++ with reflection. So it would be
AnastasiaStulova wrote:
I think that the diagnostic change is reasonable. Clang doesn't support OpenCL
C++ at present so we won't need to worry about it. However the mission of C++
for OpenCL is to track C++ and track OpenCL i.e. we may want to update to C++
with reflection. So it would be goo
AaronBallman wrote:
> The changes to the lexer look fine.
>
> I do have a question though Both the OpenCL 3.0 2.0 "C language
> specification" mention "^^ as being reserved"
> (https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html)
>
> However it does not appear to be the
cor3ntin wrote:
The changes to the lexer look fine.
I do have a question though
Both the OpenCL 3.0 2.0 "C language specification" mention "^^ as being
reserved"
(https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html)
However it does not appear to be the case - in the Ope
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b9c2e2e3e910f8283f52c574fd8b6a7981d6cb0d
81c7e305213deaa55131d044f17029a62e185025 --e
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Aaron Ballman (AaronBallman)
Changes
OpenCL has a reserved operator (^^), the use of which was diagnosed as an error
(735c6cdebdcd4292928079cb18a90f0dd5cd65fb). However, OpenCL also encourages
working with the blocks language extensi
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/108224
OpenCL has a reserved operator (^^), the use of which was diagnosed as an error
(735c6cdebdcd4292928079cb18a90f0dd5cd65fb). However, OpenCL also encourages
working with the blocks language extension. This
11 matches
Mail list logo
