https://github.com/zahiraam approved this pull request.
Looks good. Thanks.
https://github.com/llvm/llvm-project/pull/138374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
May be an [NFC] in the title of the PR?
https://github.com/llvm/llvm-project/pull/138374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ojhunt wrote:
> LGTM, but I have only done a very isolated change on this code before.
Righto, I'll wait for @zahiraam and/or @AaronBallman as well
https://github.com/llvm/llvm-project/pull/138374
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
https://github.com/fmayer approved this pull request.
LGTM, but I have only done a very isolated change on this code before.
https://github.com/llvm/llvm-project/pull/138374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/ojhunt updated
https://github.com/llvm/llvm-project/pull/138374
>From 60eeaf0edd0a58bcdac4afad44ed097efdcd83f3 Mon Sep 17 00:00:00 2001
From: Oliver Hunt
Date: Fri, 2 May 2025 19:20:27 -0700
Subject: [PATCH] [clang] rename FPOptions.def's macro to FP_OPTION
While investigati
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
clang/include/clang/Basic/LangOptions.h clang/lib/A
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Oliver Hunt (ojhunt)
Changes
While investigating the recent warnings around FEM_Indeterminate I noticed that
the macro name for FPOptions.def was given the very generic name `OPTION`.
This PR renames it to FP_OPTION instead.
---
Full dif
https://github.com/ojhunt created
https://github.com/llvm/llvm-project/pull/138374
While investigating the recent warnings around FEM_Indeterminate I noticed that
the macro name for FPOptions.def was given the very generic name `OPTION`.
This PR renames it to FP_OPTION instead.
>From f3351a66
