github-actions[bot] wrote: <!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning: <details> <summary> You can test this locally with the following command: </summary> ``````````bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/include/clang/Basic/LangOptions.h clang/lib/AST/JSONNodeDumper.cpp clang/lib/AST/TextNodeDumper.cpp clang/lib/Basic/LangOptions.cpp `````````` </details> <details> <summary> View the diff from clang-format here. </summary> ``````````diff diff --git a/clang/include/clang/Basic/LangOptions.h b/clang/include/clang/Basic/LangOptions.h index a7c2d48fd..491e8bee9 100644 --- a/clang/include/clang/Basic/LangOptions.h +++ b/clang/include/clang/Basic/LangOptions.h @@ -856,7 +856,7 @@ public: // Define a fake option named "First" so that we have a PREVIOUS even for the // real first option. static constexpr storage_type FirstShift = 0, FirstWidth = 0; -#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ +#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ static constexpr storage_type NAME##Shift = \ PREVIOUS##Shift + PREVIOUS##Width; \ static constexpr storage_type NAME##Width = WIDTH; \ @@ -974,7 +974,7 @@ public: // We can define most of the accessors automatically: // TODO: consider enforcing the assertion that value fits within bits // statically. -#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ +#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ TYPE get##NAME() const { \ return static_cast<TYPE>((Value & NAME##Mask) >> NAME##Shift); \ } \ @@ -1085,7 +1085,7 @@ public: } bool operator!=(FPOptionsOverride other) const { return !(*this == other); } -#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ +#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ bool has##NAME##Override() const { \ return OverrideMask & FPOptions::NAME##Mask; \ } \ diff --git a/clang/lib/AST/JSONNodeDumper.cpp b/clang/lib/AST/JSONNodeDumper.cpp index 8bf7d0916..3c5e8d3de 100644 --- a/clang/lib/AST/JSONNodeDumper.cpp +++ b/clang/lib/AST/JSONNodeDumper.cpp @@ -1864,7 +1864,7 @@ void JSONNodeDumper::visitVerbatimLineComment( llvm::json::Object JSONNodeDumper::createFPOptions(FPOptionsOverride FPO) { llvm::json::Object Ret; -#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ +#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ if (FPO.has##NAME##Override()) \ Ret.try_emplace(#NAME, static_cast<unsigned>(FPO.get##NAME##Override())); #include "clang/Basic/FPOptions.def" diff --git a/clang/lib/AST/TextNodeDumper.cpp b/clang/lib/AST/TextNodeDumper.cpp index 95c631124..3af6276b4 100644 --- a/clang/lib/AST/TextNodeDumper.cpp +++ b/clang/lib/AST/TextNodeDumper.cpp @@ -1114,7 +1114,7 @@ const char *TextNodeDumper::getCommandName(unsigned CommandID) { } void TextNodeDumper::printFPOptions(FPOptionsOverride FPO) { -#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ +#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ if (FPO.has##NAME##Override()) \ OS << " " #NAME "=" << FPO.get##NAME##Override(); #include "clang/Basic/FPOptions.def" diff --git a/clang/lib/Basic/LangOptions.cpp b/clang/lib/Basic/LangOptions.cpp index 6b4ce9794..7e6966209 100644 --- a/clang/lib/Basic/LangOptions.cpp +++ b/clang/lib/Basic/LangOptions.cpp @@ -219,7 +219,7 @@ FPOptions FPOptions::defaultWithoutTrailingStorage(const LangOptions &LO) { FPOptionsOverride FPOptions::getChangesSlow(const FPOptions &Base) const { FPOptions::storage_type OverrideMask = 0; -#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ +#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ if (get##NAME() != Base.get##NAME()) \ OverrideMask |= NAME##Mask; #include "clang/Basic/FPOptions.def" @@ -227,14 +227,14 @@ FPOptionsOverride FPOptions::getChangesSlow(const FPOptions &Base) const { } LLVM_DUMP_METHOD void FPOptions::dump() { -#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ +#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ llvm::errs() << "\n " #NAME " " << get##NAME(); #include "clang/Basic/FPOptions.def" llvm::errs() << "\n"; } LLVM_DUMP_METHOD void FPOptionsOverride::dump() { -#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ +#define FP_OPTION(NAME, TYPE, WIDTH, PREVIOUS) \ if (has##NAME##Override()) \ llvm::errs() << "\n " #NAME " Override is " << get##NAME##Override(); #include "clang/Basic/FPOptions.def" `````````` </details> https://github.com/llvm/llvm-project/pull/138374 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits