https://github.com/Prabhuk closed
https://github.com/llvm/llvm-project/pull/124992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5193,12 +5193,12 @@ bool Sema::CheckCallingConvAttr(const ParsedAttr
&Attrs, CallingConv &CC,
CC = CC_X86RegCall;
break;
case ParsedAttr::AT_MSABI:
-CC = Context.getTargetInfo().getTriple().isOSWindows() ? CC_C :
-
@@ -74,7 +74,7 @@ static CCMangling getCallingConvMangling(const ASTContext
&Context,
if (FD->isMain() && FD->getNumParams() == 2)
return CCM_WasmMainArgcArgv;
- if (!Triple.isOSWindows() || !Triple.isX86())
+ if (!Triple.isOSWindowsOrUEFI() || !Triple.isX86()
@@ -74,7 +74,7 @@ static CCMangling getCallingConvMangling(const ASTContext
&Context,
if (FD->isMain() && FD->getNumParams() == 2)
return CCM_WasmMainArgcArgv;
- if (!Triple.isOSWindows() || !Triple.isX86())
+ if (!Triple.isOSWindowsOrUEFI() || !Triple.isX86()
@@ -5193,12 +5193,12 @@ bool Sema::CheckCallingConvAttr(const ParsedAttr
&Attrs, CallingConv &CC,
CC = CC_X86RegCall;
break;
case ParsedAttr::AT_MSABI:
-CC = Context.getTargetInfo().getTriple().isOSWindows() ? CC_C :
-
Prabhuk wrote:
Besides the places I have updated "isOSWindows()" with "isWindowsOrUEFI()",
there are quite a few occurrences of isOSWindows() checks within Clang code.
Which one of these must be included to make sure the mangling and other ABI
related decisions made for X86_64 UEFI targets are
https://github.com/Prabhuk created
https://github.com/llvm/llvm-project/pull/124992
UEFI targets for X86_64 architecture must use appropriate mangling,
calling convention and integer size schemes.
>From 666e3cf583979789ca86e8e6a2dfc6ee28c1487b Mon Sep 17 00:00:00 2001
From: prabhukr
Date: Wed
