================
@@ -74,7 +74,7 @@ static CCMangling getCallingConvMangling(const ASTContext 
&Context,
       if (FD->isMain() && FD->getNumParams() == 2)
         return CCM_WasmMainArgcArgv;
 
-  if (!Triple.isOSWindows() || !Triple.isX86())
+  if (!Triple.isOSWindowsOrUEFI() || !Triple.isX86())
----------------
frobtech wrote:

As we discussed offline, I'd really rather see all sites like this use a 
predicate that's specific to what matters to the call site in precise terms.  
This predicate is really an answer to the question rather than the question 
that should be asked.  It presumes the answer is "Windows or UEFI targets", 
when the question it should be asking is something more like, "What C++ ABI 
name mangling regime is in use by this target?"

https://github.com/llvm/llvm-project/pull/124992
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to