[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-27 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/66997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-27 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66997 >From 5670ee4eab71549c686cb583e7ab0a14c51dce68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 21 Sep 2023 12:01:30 +0200 Subject: [PATCH] [clang][Diagnostics] Make 'note' color CYAN Jus

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-27 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66997 >From 8d7c79946f8afecf3313bcccbb5b45133242bf8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 21 Sep 2023 12:01:30 +0200 Subject: [PATCH] [clang][Diagnostics] Make 'note' color CYAN Jus

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-26 Thread via cfe-commits
cor3ntin wrote: > I keep forgetting to add release notes and @AaronBallman hasn't reminded me > in a while - is this work a release note? Yes! https://github.com/llvm/llvm-project/pull/66997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-26 Thread Timm Baeder via cfe-commits
tbaederr wrote: I keep forgetting to add release notes and @AaronBallman hasn't reminded me in a while - is this work a release note? https://github.com/llvm/llvm-project/pull/66997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-26 Thread Christopher Di Bella via cfe-commits
cjdb wrote: > Not really, CYAN is only cyan if that's what your terminal decides to render > the color 6 as, you can configure it to be orange if you want. Oh, interesting. In that case, I see no problems. https://github.com/llvm/llvm-project/pull/66997

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-26 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. A shed by any other color would store bikes as well. https://github.com/llvm/llvm-project/pull/66997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-26 Thread via cfe-commits
cor3ntin wrote: > This doesn't really fix the problem, it just shuffles it around. I expect > people with blue(ish) terminals will experience the same issue after this is > applied, so we ought to try and detect what colours to print out, and then > have compatible themes. Not really, CYAN is

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-26 Thread Christopher Di Bella via cfe-commits
cjdb wrote: > This is a one-liner that fixes the problem on terminals with a dark > background and the solution also works on light backgrounds. So, basically > all of them. Before approving this change, I want confirmation that it doesn't adversely impact popular themes. The Tomorrow Night B

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-26 Thread Timm Baeder via cfe-commits
tbaederr wrote: I know, this only fixes the problem in the vast majority of cases. I don't know of any tool implementing dynamic background color checking so it can adjust the foreground color though. This is a one-liner that fixes the problem on terminals with a dark background and the solut

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-26 Thread Christopher Di Bella via cfe-commits
cjdb wrote: This doesn't really fix the problem, it just shuffles it around. I expect people with blue(ish) terminals will experience the same issue after this is applied, so we ought to try and detect what colours to print out, and then have compatible themes. https://github.com/llvm/llvm-pr

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Just using BLACK makes it invisible in terminals with a dark background. See this screenshot: ![Screenshot from 2023-09-21 12-03-15](https://github.com/llvm/llvm-project/assets/49720664/245a9c4f-da27-4dbd-a14e-15a01adbc734) With current

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-21 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/66997 Just using BLACK makes it invisible in terminals with a dark background. See this screenshot: ![Screenshot from 2023-09-21 12-03-15](https://github.com/llvm/llvm-project/assets/49720664/245a9c4f-da27-4dbd-a14e