https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66997
>From 5670ee4eab71549c686cb583e7ab0a14c51dce68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= <tbae...@redhat.com> Date: Thu, 21 Sep 2023 12:01:30 +0200 Subject: [PATCH] [clang][Diagnostics] Make 'note' color CYAN Just using BLACK makes it invisible in terminals with a dark background. --- clang/docs/ReleaseNotes.rst | 2 ++ clang/lib/Frontend/TextDiagnostic.cpp | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index a17efab57bcdfa3..fb52b90ae4a3cb9 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -212,6 +212,8 @@ Improvements to Clang's diagnostics (`#51567: <https://github.com/llvm/llvm-project/issues/51567>`_) - Clang now diagnoses narrowing implicit conversions on variable initializers in immediate function context and on constexpr variable template initializers. +- Clang now prints its 'note' diagnostic in cyan instead of black, to be more compatible + with terminals with dark background colors. This is also more consistent with GCC. Bug Fixes in This Version ------------------------- diff --git a/clang/lib/Frontend/TextDiagnostic.cpp b/clang/lib/Frontend/TextDiagnostic.cpp index eaa6e8d29a1dece..779dead5d058d1a 100644 --- a/clang/lib/Frontend/TextDiagnostic.cpp +++ b/clang/lib/Frontend/TextDiagnostic.cpp @@ -24,8 +24,7 @@ using namespace clang; -static const enum raw_ostream::Colors noteColor = - raw_ostream::BLACK; +static const enum raw_ostream::Colors noteColor = raw_ostream::CYAN; static const enum raw_ostream::Colors remarkColor = raw_ostream::BLUE; static const enum raw_ostream::Colors fixitColor = _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
