@@ -285,15 +285,43 @@ void ExprEngine::VisitCast(const CastExpr *CastE, const
Expr *Ex,
ExplodedNodeSet dstPreStmt;
getCheckerManager().runCheckersForPreStmt(dstPreStmt, Pred, CastE, *this);
- if (CastE->getCastKind() == CK_LValueToRValue ||
- CastE->getCastKind() =
@@ -1,5 +1,5 @@
// RUN: %clang_analyze_cc1 -triple x86_64-unknown-unknown -verify %s \
-// RUN: -analyzer-checker=core,debug.ExprInspection
+// RUN: -analyzer-checker=debug.ExprInspection -analyzer-disable-checker=core
ziqingluo-90 wrote:
Oh, I was going to
@@ -1,5 +1,5 @@
// RUN: %clang_analyze_cc1 -triple x86_64-unknown-unknown -verify %s \
-// RUN: -analyzer-checker=core,debug.ExprInspection
+// RUN: -analyzer-checker=debug.ExprInspection -analyzer-disable-checker=core
steakhal wrote:
Why do you disable core
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/139188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -282,15 +282,48 @@ ProgramStateRef ExprEngine::handleLValueBitCast(
void ExprEngine::VisitCast(const CastExpr *CastE, const Expr *Ex,
ExplodedNode *Pred, ExplodedNodeSet &Dst) {
- ExplodedNodeSet dstPreStmt;
- getCheckerManager().runCheckersForP
https://github.com/steakhal approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/139188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -285,15 +285,43 @@ void ExprEngine::VisitCast(const CastExpr *CastE, const
Expr *Ex,
ExplodedNodeSet dstPreStmt;
getCheckerManager().runCheckersForPreStmt(dstPreStmt, Pred, CastE, *this);
- if (CastE->getCastKind() == CK_LValueToRValue ||
- CastE->getCastKind() =
ziqingluo-90 wrote:
This fix should solve https://github.com/llvm/llvm-project/issues/71174, and
https://github.com/llvm/llvm-project/issues/137417
https://github.com/llvm/llvm-project/pull/139188
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
ziqingluo-90 wrote:
Thanks for reviewing!
https://github.com/llvm/llvm-project/pull/139188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ziqingluo-90 updated
https://github.com/llvm/llvm-project/pull/139188
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
@@ -285,15 +285,43 @@ void ExprEngine::VisitCast(const CastExpr *CastE, const
Expr *Ex,
ExplodedNodeSet dstPreStmt;
getCheckerManager().runCheckersForPreStmt(dstPreStmt, Pred, CastE, *this);
- if (CastE->getCastKind() == CK_LValueToRValue ||
- CastE->getCastKind() =
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/139188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal commented:
LGTM overall. Thank you!
I'm also in favor of following the LLVM coding style.
https://github.com/llvm/llvm-project/pull/139188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/NagyDonat edited
https://github.com/llvm/llvm-project/pull/139188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/NagyDonat commented:
Overall LGTM, thanks for fixing this crash!
I dropped one (somewhat paranoid) inline question.
Moreover, I would suggest following the [coding
standard](https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)
https://github.com/ziqingluo-90 updated
https://github.com/llvm/llvm-project/pull/139188
>From 95ac7cf69dbd683f70b123446115fe3893844526 Mon Sep 17 00:00:00 2001
From: Ziqing Luo
Date: Thu, 8 May 2025 17:48:41 -0700
Subject: [PATCH 1/2] [StaticAnalyzer] Handle __builtin_bit_cast
Previously, CSA
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Ziqing Luo (ziqingluo-90)
Changes
I am investigating a CSA crash: https://godbolt.org/z/fEExYqoWM. If one
changes the `__builtin_bit_cast` to a C-style cast, the test will be fine. So
the problem is specific to `__buil
https://github.com/ziqingluo-90 created
https://github.com/llvm/llvm-project/pull/139188
I am investigating a CSA crash: https://godbolt.org/z/fEExYqoWM. If one
changes the `__builtin_bit_cast` to a C-style cast, the test will be fine. So
the problem is specific to `__builtin_bit_cast`.
Loo
18 matches
Mail list logo