https://github.com/NagyDonat commented:
Overall LGTM, thanks for fixing this crash! I dropped one (somewhat paranoid) inline question. Moreover, I would suggest following the [coding standard](https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly) and use `UpperCamelCase` for the variables that are freshly introduced (and perhaps also for the variables that were already existing, if you touch most references to them and could easily rename them). Unfortunately we cannot "jump to" this naming standard by globally renaming many variables (because that would heavily pollute the git history), but I think we should gradually transition by following the standard in new variables and perhaps renaming the variables in the code that we touch. (As a personal preference, I consistently update the variable names when I edit some code, but objectively it's also OK to keep the old names to preserve consistency with adjacent existing code.) https://github.com/llvm/llvm-project/pull/139188 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
