elizabethandrews wrote:
> > > Ah, I remember now why the SYCL flag / mode was abused here (the default
> > > AS Map for SPIR-V is problematic in this case); I believe that using the
> > > `spirv64-amd-amdhsa` triple instead of `spirv64-unknown-unknown` will
> > > work, and allow for the remova
https://github.com/elizabethandrews closed
https://github.com/llvm/llvm-project/pull/109182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AlexVlx wrote:
> > Ah, I remember now why the SYCL flag / mode was abused here (the default AS
> > Map for SPIR-V is problematic in this case); I believe that using the
> > `spirv64-amd-amdhsa` triple instead of `spirv64-unknown-unknown` will work,
> > and allow for the removal of the SYCL ref
elizabethandrews wrote:
> Ah, I remember now why the SYCL flag / mode was abused here (the default AS
> Map for SPIR-V is problematic in this case); I believe that using the
> `spirv64-amd-amdhsa` triple instead of `spirv64-unknown-unknown` will work,
> and allow for the removal of the SYCL re
https://github.com/elizabethandrews updated
https://github.com/llvm/llvm-project/pull/109182
>From de0278d21e737c7ac8cd0165f05484c40aeb46fa Mon Sep 17 00:00:00 2001
From: Elizabeth Andrews
Date: Wed, 18 Sep 2024 12:34:06 -0700
Subject: [PATCH 1/3] [Clang][NFC] Remove incorrect SYCL tests
The t
elizabethandrews wrote:
> > > Instead of removing the test case altogether, does it not suffice to
> > > remove the SYCL reference / SYCL specific flag, which I interpret as the
> > > problem being addressed? SYCL per se is not a target, but rather a
> > > language? Apologies if I'm missing so
AlexVlx wrote:
> > Instead of removing the test case altogether, does it not suffice to remove
> > the SYCL reference / SYCL specific flag, which I interpret as the problem
> > being addressed? SYCL per se is not a target, but rather a language?
> > Apologies if I'm missing something.
>
> I t
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (elizabethandrews)
Changes
The tests added for SYCL device compilation in
https://github.com/llvm/llvm-project/pull/88182 are incorrect SYCL tests. Code
technically should not have been emitted in SYCL device compilation for these
t
elizabethandrews wrote:
> Instead of removing the test case altogether, does it not suffice to remove
> the SYCL reference / SYCL specific flag, which I interpret as the problem
> being addressed? SYCL per se is not a target, but rather a language?
> Apologies if I'm missing something.
I trie
AlexVlx wrote:
Instead of removing the test case altogether, does it not suffice to remove
the SYCL reference / SYCL specific flag, which I interpret as the problem being
addressed? SYCL per se is not a target, but rather a language? Apologies if I'm
missing something.
https://github.com/llv
https://github.com/elizabethandrews created
https://github.com/llvm/llvm-project/pull/109182
The tests added for SYCL device compilation in
https://github.com/llvm/llvm-project/pull/88182 are incorrect SYCL tests. Code
technically should not have been emitted in SYCL device compilation for the
11 matches
Mail list logo
