elizabethandrews wrote: > > > Ah, I remember now why the SYCL flag / mode was abused here (the default > > > AS Map for SPIR-V is problematic in this case); I believe that using the > > > `spirv64-amd-amdhsa` triple instead of `spirv64-unknown-unknown` will > > > work, and allow for the removal of the SYCL references. > > > > > > I tried changing the triple. The address spaces changed for several tests > > but I do not know if change is correct or not since I am very unfamiliar > > with what the expected behavior here is. I have uploaded the changes for > > your review. Could you please verify the address space changes are correct. > > I do not want to be testing for the wrong thing in the CHECK lines. > > In some tests, using the new triple causes the test to crash. For those, I > > just removed the test itself. > > Personally I would like to submit the PR to remove the incorrect SYCL tests > > without changing the triple (unless you can verify these new test changes > > are correct), and have someone more familiar with this area of code to > > follow-up with the right tests for #88182 > > Apologies for the delay. Please see #109415 which addresses this matter. > Thank you.
Thanks for the fix! I will close this PR. https://github.com/llvm/llvm-project/pull/109182 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
