[clang] [CIR] Add rotate operation (PR #148426)

2025-07-16 Thread Peter Klausler via cfe-commits
klausler wrote: Agreed, it looks like the culprit was a patch to the test, and this patch was the first to take the rap. https://github.com/llvm/llvm-project/pull/148426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-16 Thread Erich Keane via cfe-commits
erichkeane wrote: > Did this patch undergo a Windows CI build? Clang-IR changes don't quite yet trigger MLIR/CIR builds yet, just the plain Clang builds, Andy has a patch that has recently received approval from the Infra Area Team to do so, it just needs a few final approvals. That said, are

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-16 Thread Peter Klausler via cfe-commits
klausler wrote: Did this patch undergo a Windows CI build? https://github.com/llvm/llvm-project/pull/148426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-win-fast` running on `as-builder-3` while building `clang` at step 6 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/2/builds/29057 Here is the relevant piece

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-arm64-windows-msvc` running on `linaro-armv8-windows-msvc-01` while building `clang` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/207/builds/4047 Here is the

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-16 Thread Sirui Mu via cfe-commits
@@ -2898,6 +2898,45 @@ def ByteSwapOp : CIR_BitOpBase<"byte_swap", CIR_UIntOfWidths<[16, 32, 64]>> { }]; } +//===--===// +// RotateOp +//===--

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-16 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/148426 >From 06a18f792e92ea4ff7f576f33d92c26c30045f85 Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Sun, 13 Jul 2025 20:14:41 +0800 Subject: [PATCH] [CIR] Add rotate operation --- clang/include/clang/CIR/Dialect/IR/C

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-15 Thread Henrich Lauko via cfe-commits
@@ -2898,6 +2898,45 @@ def ByteSwapOp : CIR_BitOpBase<"byte_swap", CIR_UIntOfWidths<[16, 32, 64]>> { }]; } +//===--===// +// RotateOp +//===--

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-15 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/148426 >From 4d0e8a07d8503187f00a57e688e5711c1dc73aea Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Sun, 13 Jul 2025 20:14:41 +0800 Subject: [PATCH] [CIR] Add rotate operation --- clang/include/clang/CIR/Dialect/IR/C

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-15 Thread Henrich Lauko via cfe-commits
@@ -2847,6 +2847,45 @@ def ByteSwapOp : CIR_BitOpBase<"byte_swap", CIR_UIntOfWidths<[16, 32, 64]>> { }]; } +//===--===// +// RotateOp +//===--

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-15 Thread Henrich Lauko via cfe-commits
@@ -2847,6 +2847,45 @@ def ByteSwapOp : CIR_BitOpBase<"byte_swap", CIR_UIntOfWidths<[16, 32, 64]>> { }]; } +//===--===// +// RotateOp +//===--

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Henrich Lauko via cfe-commits
@@ -2847,6 +2847,37 @@ def ByteSwapOp : CIR_BitOpBase<"byte_swap", CIR_UIntOfWidths<[16, 32, 64]>> { }]; } +//===--===// +// RotateOp +//===--

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Henrich Lauko via cfe-commits
@@ -219,6 +233,28 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID, mlir::Value arg = emitScalarExpr(e->getArg(0)); return RValue::get(builder.create(loc, arg)); } + + case Builtin::BI__builtin_rotateleft8: + case Builtin::BI__buil

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Sirui Mu via cfe-commits
@@ -57,6 +57,20 @@ static RValue emitBuiltinBitOp(CIRGenFunction &cgf, const CallExpr *e, return RValue::get(result); } +RValue CIRGenFunction::emitRotate(const CallExpr *e, bool isRotateLeft) { + mlir::Value input = emitScalarExpr(e->getArg(0)); + mlir::Value amount = em

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Sirui Mu via cfe-commits
@@ -219,6 +233,28 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID, mlir::Value arg = emitScalarExpr(e->getArg(0)); return RValue::get(builder.create(loc, arg)); } + + case Builtin::BI__builtin_rotateleft8: + case Builtin::BI__buil

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Sirui Mu via cfe-commits
@@ -2847,6 +2847,37 @@ def ByteSwapOp : CIR_BitOpBase<"byte_swap", CIR_UIntOfWidths<[16, 32, 64]>> { }]; } +//===--===// +// RotateOp +//===--

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/148426 >From 996ddacdb181385b5b26a54d884f00df38a835a7 Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Sun, 13 Jul 2025 20:14:41 +0800 Subject: [PATCH] [CIR] Add rotate operation --- clang/include/clang/CIR/Dialect/IR/C

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Sirui Mu via cfe-commits
https://github.com/Lancern edited https://github.com/llvm/llvm-project/pull/148426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Sirui Mu via cfe-commits
@@ -57,6 +57,20 @@ static RValue emitBuiltinBitOp(CIRGenFunction &cgf, const CallExpr *e, return RValue::get(result); } +RValue CIRGenFunction::emitRotate(const CallExpr *e, bool isRotateLeft) { + mlir::Value input = emitScalarExpr(e->getArg(0)); + mlir::Value amount = em

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Henrich Lauko via cfe-commits
@@ -219,6 +233,28 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID, mlir::Value arg = emitScalarExpr(e->getArg(0)); return RValue::get(builder.create(loc, arg)); } + + case Builtin::BI__builtin_rotateleft8: + case Builtin::BI__buil

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Henrich Lauko via cfe-commits
@@ -219,6 +233,28 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID, mlir::Value arg = emitScalarExpr(e->getArg(0)); return RValue::get(builder.create(loc, arg)); } + + case Builtin::BI__builtin_rotateleft8: + case Builtin::BI__buil

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Henrich Lauko via cfe-commits
@@ -57,6 +57,20 @@ static RValue emitBuiltinBitOp(CIRGenFunction &cgf, const CallExpr *e, return RValue::get(result); } +RValue CIRGenFunction::emitRotate(const CallExpr *e, bool isRotateLeft) { + mlir::Value input = emitScalarExpr(e->getArg(0)); + mlir::Value amount = em

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Henrich Lauko via cfe-commits
@@ -2847,6 +2847,37 @@ def ByteSwapOp : CIR_BitOpBase<"byte_swap", CIR_UIntOfWidths<[16, 32, 64]>> { }]; } +//===--===// +// RotateOp +//===--

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Henrich Lauko via cfe-commits
@@ -2847,6 +2847,37 @@ def ByteSwapOp : CIR_BitOpBase<"byte_swap", CIR_UIntOfWidths<[16, 32, 64]>> { }]; } +//===--===// +// RotateOp +//===--

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Henrich Lauko via cfe-commits
@@ -872,6 +872,21 @@ mlir::LogicalResult CIRToLLVMReturnOpLowering::matchAndRewrite( return mlir::LogicalResult::success(); } +mlir::LogicalResult CIRToLLVMRotateOpLowering::matchAndRewrite( +cir::RotateOp op, OpAdaptor adaptor, +mlir::ConversionPatternRewriter &rew

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-14 Thread Henrich Lauko via cfe-commits
@@ -2847,6 +2847,37 @@ def ByteSwapOp : CIR_BitOpBase<"byte_swap", CIR_UIntOfWidths<[16, 32, 64]>> { }]; } +//===--===// +// RotateOp +//===--

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Sirui Mu (Lancern) Changes This patch adds `cir.rotate` operation for the `__builtin_rotateleft` and `__builtin_rotateright` families of builtin calls. --- Full diff: https://github.com/llvm/llvm-project/pull/148426.diff 6 Files Affec

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sirui Mu (Lancern) Changes This patch adds `cir.rotate` operation for the `__builtin_rotateleft` and `__builtin_rotateright` families of builtin calls. --- Full diff: https://github.com/llvm/llvm-project/pull/148426.diff 6 Files Affecte

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-13 Thread Sirui Mu via cfe-commits
https://github.com/Lancern created https://github.com/llvm/llvm-project/pull/148426 This patch adds `cir.rotate` operation for the `__builtin_rotateleft` and `__builtin_rotateright` families of builtin calls. >From 1df58fbc1a0fa5aec67300eb240dd1ca21a30819 Mon Sep 17 00:00:00 2001 From: Sirui M