erichkeane wrote: > Did this patch undergo a Windows CI build?
Clang-IR changes don't quite yet trigger MLIR/CIR builds yet, just the plain Clang builds, Andy has a patch that has recently received approval from the Infra Area Team to do so, it just needs a few final approvals. That said, are we sure that this patch actually built those, and these failures aren't a result of something else? ``` C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\third-party\benchmark\src\sysinfo.cc(374): error C2065: 'CacheUnknown': undeclared identifier C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\third-party\benchmark\src\sysinfo.cc(374): error C2131: expression did not evaluate to a constant C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\third-party\benchmark\src\sysinfo.cc(374): note: a non-constant (sub-)expression was encountered C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\third-party\benchmark\src\sysinfo.cc(374): error C2051: case expression not constant ``` Seems a little strange to associate with this patch, it doesn't really look like anything on this patch? https://github.com/llvm/llvm-project/pull/148426 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
