[PATCH] D96730: [clangd] Modules can have a public API. NFC

2021-02-16 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG40cc63ea6eec: [clangd] Modules can have a public API. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D96730?vs=323822&id=32398

[PATCH] D96730: [clangd] Modules can have a public API. NFC

2021-02-16 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ClangdServer.h:349 + ModuleSet *Modules; const GlobalCompilationDatabase &CDB; nit: ` = nullptr`

[PATCH] D96730: [clangd] Modules can have a public API. NFC

2021-02-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Mono