kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
================
Comment at: clang-tools-extra/clangd/ClangdServer.h:349
+ ModuleSet *Modules;
const GlobalCompilationDatabase &CDB;
----------------
nit: ` = nullptr`
================
Comment at: clang-tools-extra/clangd/Module.cpp:7
+bool ModuleSet::addImpl(void *Key, std::unique_ptr<Module> M) {
+ if (!Map.try_emplace(Key, M.get()).second)
+ return false;
----------------
should we log/assert?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96730/new/
https://reviews.llvm.org/D96730
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
