[PATCH] D96716: [flang][driver] Add debug dump options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bd08dab5ff9: [flang][driver] Add debug dump options (authored by FarisRehman). Changed prior to commit: https://reviews.llvm.org/D96716?vs=324352

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added a comment. In D96716#2569594 , @awarzynski wrote: > We need `%f18` to be replaced with `%flang_fc1`, but we don't need > `-fsyntax-only`, right? Makes sense thanks, I'll remove before committing. Repository: rG LLVM Github Monorepo

[PATCH] D96716: [flang][driver] Add debug dump options

awarzynski added a comment. In D96716#2569160 , @FarisRehman wrote: > They do require updating as `-fdebug-dump-symbol` and > `-fdebug-dump-parse-tree` are otherwise not tested by the new driver in this > patch. Apologies, I wasn't clear (realized after

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added a comment. In D96716#2569102 , @awarzynski wrote: > This patch doesn't require the tests to be updated, does it? They do require updating as `-fdebug-dump-symbol` is otherwise not tested by the new driver in this patch. Repository:

[PATCH] D96716: [flang][driver] Add debug dump options

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. This patch doesn't require the tests to be updated, does it? Also: https://reviews.llvm.org/D96870. So it looks these are unrelated changes. Could you remove them before merging? Othe

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added inline comments. Comment at: flang/include/flang/Frontend/FrontendActions.h:54 +public: + std::unique_ptr semantics_; }; FarisRehman wrote: > awarzynski wrote: > > Do we need to expose it? Shouldn't this be private? > It will not compile if th

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman updated this revision to Diff 324352. FarisRehman marked an inline comment as done. FarisRehman added a comment. Make semantics_ private Make semantics_ in PrescanAndSemaAction private, adding semantics() and setSemantics(). Summary of changes: - Add semantics() and setSemantics()

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added inline comments. Comment at: flang/include/flang/Frontend/FrontendActions.h:54 +public: + std::unique_ptr semantics_; }; awarzynski wrote: > Do we need to expose it? Shouldn't this be private? It will not compile if the variable is private as

[PATCH] D96716: [flang][driver] Add debug dump options

awarzynski added a comment. I think that this patch does a great job demonstrating the use of frontend actions and how _action_ compiler flags map to them. Given how `Fortran::semantics::Semantics` are defined and created, I think that adding _semantics_ as a member variable to `PrescanAndSemaA

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman updated this revision to Diff 323929. FarisRehman added a comment. Rebase off main Rebase off main and update some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96716/new/ https://reviews.llvm.org/D96716 Files: clang/inclu

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.