This revision was automatically updated to reflect the committed changes.
Closed by commit rG196cc96f9a64: [clang] Allow LifetimeExtendedTemporary to
have no access specifier (authored by adamcz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94804/n
adamcz added inline comments.
Comment at: clang/lib/AST/DeclBase.cpp:986
+ isa(this) ||
+ isa(this))
return true;
hokein wrote:
> nit: personally I'd keep the old format style, just appending the new case.
I like the old formatting a little better
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
thanks.
Comment at: clang/lib/AST/DeclBase.cpp:986
+ isa(this) ||
+ isa(this))
return true;
nit: personally I'd keep the old format style, jus
adamcz created this revision.
adamcz added a reviewer: hokein.
adamcz requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The check only runs in debug mode during serialization, but
assert()-fail on:
struct S { const int& x = 7; };
in C++ m
