adamcz added inline comments.

================
Comment at: clang/lib/AST/DeclBase.cpp:986
+      isa<ClassScopeFunctionSpecializationDecl>(this) ||
+      isa<LifetimeExtendedTemporaryDecl>(this))
     return true;
----------------
hokein wrote:
> nit: personally I'd keep the old format style, just appending the new case.
I like the old formatting a little better too, but this is what clang-format 
wants to do and I think keeping the code clang-format clean is more valuable in 
this case. Otherwise everyone submitting here must ignore/silence formatting 
errors and can no longer auto-format this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94804/new/

https://reviews.llvm.org/D94804

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to