[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

alexfh added a comment. In D93688#2525947 , @alexfh wrote: > This patch causes practically infinite traversal times on code that contains > deeply nested lambdas. I'll try to get a suitable repro, but could you maybe > revert this in the meantime? Actua

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

alexfh added a comment. This patch causes practically infinite traversal times on code that contains deeply nested lambdas. I'll try to get a suitable repro, but could you maybe revert this in the meantime? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3a21e5de3dc: [ASTMatchers] Ensure that we can match inside lambdas (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93688/new/ htt

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:526 +TraverseStmt(LE->getTrailingRequiresClause()); + +TraverseStmt(LE->getBody()); --

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:526 +TraverseStmt(LE->getTrailingRequiresClause()); + +TraverseStmt(LE->getBody()); aaron.ballman wrote: > Do we also n

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

steveire updated this revision to Diff 314446. steveire marked 2 inline comments as done. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93688/new/ https://reviews.llvm.org/D93688 Files: clang/include/clang/ASTMat

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

steveire updated this revision to Diff 314445. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93688/new/ https://reviews.llvm.org/D93688 Files: clang/include/clang/ASTMatchers/ASTMatchersInternal.h clang/lib/AST

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:478-487 +} else if (auto *LE = dyn_cast(S)) { + + for (unsigned I = 0, N = LE->capture_size(); I != N; ++I) { +const auto *C = LE->capture_begin() + I; +{ +

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

steveire updated this revision to Diff 313296. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93688/new/ https://reviews.llvm.org/D93688 Files: clang/include/clang/ASTMatchers/ASTMatchersInternal.h clang/lib/AST

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because we don't know in ASTMatchFinder whether we're matching in AsIs or IgnoreUnlessSpelledInSource mode, w